From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D598A1A9F83 for ; Sun, 23 Nov 2025 01:56:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763862967; cv=none; b=nEUjidxiBR2Tg36KsN+jwfYnbX9A/81Yzz1xLnHIFs1MAdhX2jDejTf+uixaoeoyuuc3kZBZMD6j7K+TavsiSKD7BZRKQnlO+RcQ1o8OBtxyFRS307fl6KxA9+DSDGJ2Kxm2o2Z+YE1nGXGe1tSSnxSE7WhN2qPkq3Cty19K0uc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763862967; c=relaxed/simple; bh=+MFtgW/i9fsQtkxwW9d/Tr84YvplwLULxpsrXRDGyjY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eWsFB7DqCgh+L/OHDSGTePPVPuv4QjxE2or761K6WhsZQNfsiF0mFKI61Ob5/uR4SBORCZiVzN3IgcT9D95F4GeWe/BrO90G+9JyyQxWg/Kzes/5mmdMmQl4w6WHTtVjN+2Gbp4Kxi9ccGP/AbXkoiuWXKrJi28S6AocxNQYv6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cttqzave; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cttqzave" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b73545723ebso606114266b.1 for ; Sat, 22 Nov 2025 17:56:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763862964; x=1764467764; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hFfnRMxsFef8UuqVOMtfR2RwUPLNhAhZ9jQUdR5Ficw=; b=cttqzaveiHqYywr2LMU4dVmhMxc59vMi9blbQ0xylv+U1viQyYG1zfj+PjxLFjT2ng rgM6Zk6QhNOGX05IdPMG6APzW8Nd2M+eWIWV7dfS6jiD069s0ESulrNJIbQZ/mWQUN2W Syq6CwKOCnY6yUN7/aKMzq2pMCSQf6HEmnFoW7qm9pxoDECANi9wPGX3E/PV11YkVE1Z Dw3ca062GTb0a8ym8hw3vRq6Zukc07TT9EOqoJ9ANO71ml7/a8ufqWni1V7uO+XoTtdi nU2kbeiXNeseMoXVmcsz+JzcdyM6/BO29DsaIfJrD2EFfrsMxoU0yAPIGyyl2DMsMOKF sOQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763862964; x=1764467764; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hFfnRMxsFef8UuqVOMtfR2RwUPLNhAhZ9jQUdR5Ficw=; b=DWqhPzfU+z1igBq5fd74HsCjId87sYwJo+E4oDGt8pr63B9IoCE3Vjgj3UDnHYHrVP pvbdo8Zw6hn8w2x6BOpCvx9uQgacKzeG66+FnZsrlyiaf7rKiz/JV2a3Sl6mZMZNXl69 wE9i3vBuqkHoPnHp9zaQt6hySvUZLbg0WHHkIVY+08D+xzARh9Hf67ZWpMFX+puEelkc PhgOqLMls9h6M1Pb3mlKEIJMcZQ7L82HKJTWoU6Z0erfr96cxWZg+F+26E+e11ZkDm2K z/MQStlUrBC7hifmLjcWpl3gwn2k5PUTVW30CoIUe7ahaoZ0Ogx/3qRn/Ct/EF5zXOkW Dj7A== X-Forwarded-Encrypted: i=1; AJvYcCVEeofpPsf2havPurjfugv0CEqOPCKVlF+tPPfY8DC+Mm1OeSu+KDBD/iQUQBm0LHUfj0Q+ko/s3w1GtJk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz32WvagjbHeRR6OOzZl158EwYfSoZe0Di/OYD0Xuq+qlm8B5sp RA0tHdoge2vMol8cGIjbzearx44nU8+Zw1gu5jxbAanMZHRx4PnEZazy X-Gm-Gg: ASbGncsIl4brMObrMIUX6GhvP3oL6KHqyyQBmKSJVzwB+ix+4Y7wkFCDz36lD5pUF/F hG1aDvE+ck5ohXu9DvbNxJLRTSMponaDTSqz/gs1FlleIeuFaHXkdOXB19Bq25VqHAJFBqCKWI3 REbkil4+JLImhDRsxGb6inlqBqbSh6xtavn9i6CFOwIzT+LqDcD8v54pCEjuxGibe0QGcYmm3/B nRUANZNZMEwsYP2bi3zgPIKoIQo6DS17fNmlhwY7b8gg1+SigzdzsqUjoKIChtebl31jmOvqs5i bgWWe0QPyUNHaouPqMzdxHjkfcFhLYz1maensiiNfM4qm3AX5lNjH3l4bGzWlTnkvL0WMtQFNBG hMuA6r8BJM+Wi1iBTBSoTdVzUYMiJywZ8mgFiJVwYi139QSwxNlh8yvMLf8dzZcZN7fzq45LkDq H4zmay+ayYxwZXdw== X-Google-Smtp-Source: AGHT+IFIwca2o53gjcqixsgLvQiiS7Tt32GJtgXalAxMUoDDVTzlUHKIoEE5lRjCpBf07TXRPziyRQ== X-Received: by 2002:a17:907:2d8d:b0:b72:f621:aac with SMTP id a640c23a62f3a-b7671a77455mr763934666b.39.1763862964001; Sat, 22 Nov 2025 17:56:04 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654d56a70sm883475966b.22.2025.11.22.17.56.03 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Nov 2025 17:56:03 -0800 (PST) Date: Sun, 23 Nov 2025 01:56:03 +0000 From: Wei Yang To: Zi Yan Cc: David Hildenbrand , Lorenzo Stoakes , Andrew Morton , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Miaohe Lin , Naoya Horiguchi , Wei Yang , Balbir Singh , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] mm/huge_memory: fix folio split stats counting Message-ID: <20251123015603.fmzmkwxjqkgd4oop@master> Reply-To: Wei Yang References: <20251122025529.1562592-1-ziy@nvidia.com> <20251122025529.1562592-5-ziy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251122025529.1562592-5-ziy@nvidia.com> User-Agent: NeoMutt/20170113 (1.7.2) On Fri, Nov 21, 2025 at 09:55:29PM -0500, Zi Yan wrote: >The "return " statements for error checks at the beginning of >__folio_split() skip necessary count_vm_event() and count_mthp_stat() at >the end of the function. Fix these by replacing them with >"ret = ; goto out;". > >Signed-off-by: Zi Yan Sounds reasonable, Thanks. Reviewed-by: Wei Yang -- Wei Yang Help you, Help me