From: Breno Leitao <leitao@debian.org>
To: aleksander.lobakin@intel.com,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: michal.swiatkowski@linux.intel.com, michal.kubiak@intel.com,
maciej.fijalkowski@intel.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, Breno Leitao <leitao@debian.org>
Subject: [PATCH net-next 8/8] fm10k: extract GRXRINGS from .get_rxnfc
Date: Mon, 24 Nov 2025 10:19:12 -0800 [thread overview]
Message-ID: <20251124-gxring_intel-v1-8-89be18d2a744@debian.org> (raw)
In-Reply-To: <20251124-gxring_intel-v1-0-89be18d2a744@debian.org>
Commit 84eaf4359c36 ("net: ethtool: add get_rx_ring_count callback to
optimize RX ring queries") added specific support for GRXRINGS callback,
simplifying .get_rxnfc.
Remove the handling of GRXRINGS in .get_rxnfc() by moving it to the new
.get_rx_ring_count().
This simplifies the RX ring count retrieval and aligns fm10k with the new
ethtool API for querying RX ring parameters.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
index bf2029144c1d..76e42abca965 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
@@ -734,22 +734,11 @@ static int fm10k_get_rssh_fields(struct net_device *dev,
return 0;
}
-static int fm10k_get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd,
- u32 __always_unused *rule_locs)
+static u32 fm10k_get_rx_ring_count(struct net_device *dev)
{
struct fm10k_intfc *interface = netdev_priv(dev);
- int ret = -EOPNOTSUPP;
- switch (cmd->cmd) {
- case ETHTOOL_GRXRINGS:
- cmd->data = interface->num_rx_queues;
- ret = 0;
- break;
- default:
- break;
- }
-
- return ret;
+ return interface->num_rx_queues;
}
static int fm10k_set_rssh_fields(struct net_device *dev,
@@ -1160,7 +1149,7 @@ static const struct ethtool_ops fm10k_ethtool_ops = {
.set_ringparam = fm10k_set_ringparam,
.get_coalesce = fm10k_get_coalesce,
.set_coalesce = fm10k_set_coalesce,
- .get_rxnfc = fm10k_get_rxnfc,
+ .get_rx_ring_count = fm10k_get_rx_ring_count,
.get_regs = fm10k_get_regs,
.get_regs_len = fm10k_get_regs_len,
.self_test = fm10k_self_test,
--
2.47.3
next prev parent reply other threads:[~2025-11-24 18:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 18:19 [PATCH net-next 0/8] net: intel: migrate to .get_rx_ring_count() ethtool callback Breno Leitao
2025-11-24 18:19 ` [PATCH net-next 1/8] i40e: extract GRXRINGS from .get_rxnfc Breno Leitao
2025-11-25 3:48 ` Jakub Kicinski
2025-11-25 9:21 ` Breno Leitao
2025-11-25 6:50 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-11-24 18:19 ` [PATCH net-next 2/8] iavf: " Breno Leitao
2025-11-25 6:50 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-11-24 18:19 ` [PATCH net-next 3/8] ice: " Breno Leitao
2025-11-25 6:49 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-11-24 18:19 ` [PATCH net-next 4/8] idpf: " Breno Leitao
2025-11-25 6:48 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-11-25 9:22 ` Breno Leitao
2025-11-25 6:49 ` Loktionov, Aleksandr
2025-11-24 18:19 ` [PATCH net-next 5/8] igb: " Breno Leitao
2025-11-25 6:49 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-11-24 18:19 ` [PATCH net-next 6/8] igc: " Breno Leitao
2025-11-25 6:49 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-11-24 18:19 ` [PATCH net-next 7/8] ixgbevf: " Breno Leitao
2025-11-25 6:48 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-11-24 18:19 ` Breno Leitao [this message]
2025-11-25 6:49 ` [Intel-wired-lan] [PATCH net-next 8/8] fm10k: " Loktionov, Aleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124-gxring_intel-v1-8-89be18d2a744@debian.org \
--to=leitao@debian.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.kubiak@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®