From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id D817414A8E
	for <linux-kernel@vger.kernel.org>; Mon, 24 Nov 2025 06:15:21 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1763964924; cv=none; b=JFr3sRIEa/D4kKCY1Va2RhsgjqwVGB6tg14iFBZIOiwYUyWrixnhVJMLaJplU4238/vjV3T0KNeYlkNn0ngg/tYbfIeJc7tGew5yV1+xOjmiAh2Y3YT5qLyMTqwsK0bBKlsPs7jGkEc+IWoJSOun3fRYlN6lRo8dX0lvPCeiYds=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1763964924; c=relaxed/simple;
	bh=v6tKl2qVuFLiG1Gcm7G1tL3Ntw9ZzCJMnnFdTTsFu6U=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=fph4EgktM036A1K65S2AcLQeEYjm1pqegsNIlvqbTIBuQBUdHMTHpThJHKOgRAXpHC/VL6+c2iQnk/Vl46uedQHea7s7ZcETavmI44FCx01Q/pPTI2HkwbbFja2UyhxzUFU9oQdWJhgUHgnkQOSfg1cOGPjhoDG5YJEF8cyj9Ws=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id A4CA668B05; Mon, 24 Nov 2025 07:15:17 +0100 (CET)
Date: Mon, 24 Nov 2025 07:15:17 +0100
From: Christoph Hellwig <hch@lst.de>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Hugh Dickins <hughd@google.com>, Christoph Hellwig <hch@lst.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@gentwo.org>,
	David Rientjes <rientjes@google.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Harry Yoo <harry.yoo@oracle.com>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	Brendan Jackman <jackmanb@google.com>, Zi Yan <ziy@nvidia.com>,
	Eric Biggers <ebiggers@kernel.org>, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/11] mempool: factor out a mempool_alloc_from_pool
 helper
Message-ID: <20251124061517.GB16260@lst.de>
References: <20251113084022.1255121-1-hch@lst.de> <20251113084022.1255121-7-hch@lst.de> <a8a2c740-2208-5692-cfc6-f475ae0f7d45@google.com> <7b1265bc-835e-4c7d-af75-f237c46bc3a7@suse.cz>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7b1265bc-835e-4c7d-af75-f237c46bc3a7@suse.cz>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Sun, Nov 23, 2025 at 12:34:40PM +0100, Vlastimil Babka wrote:
> Looking closer I noticed we're also not doing as the comment says about
> passing the limited flags to mempool_alloc_from_pool() on the first attempt.

It does, that's gfp_temp.