From: David Sterba <dsterba@suse.cz>
To: David Sterba <dsterba@suse.cz>
Cc: Daniel Vacek <neelx@suse.com>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: simplify async csum synchronization
Date: Mon, 24 Nov 2025 19:09:04 +0100 [thread overview]
Message-ID: <20251124180904.GR13846@twin.jikos.cz> (raw)
In-Reply-To: <20251118120716.GT13846@twin.jikos.cz>
On Tue, Nov 18, 2025 at 01:07:16PM +0100, David Sterba wrote:
> On Thu, Nov 13, 2025 at 11:17:30AM +0100, Daniel Vacek wrote:
> > We don't need the redundant completion csum_done which marks the
> > csum work has been executed. We can simply flush_work() instead.
> >
> > This way we can slim down the btrfs_bio structure by 32 bytes matching
> > it's size to what it used to be before introducing the async csums.
> > Hence not making any change with respect to the structure size.
> > ---
> > This is a simple fixup for "btrfs: introduce btrfs_bio::async_csum" in
> > for-next and can be squashed into it.
> >
> > v2: metadata is not checksummed here so use the endio_workers workqueue
> > unconditionally. Thanks to Qu Wenruo.
>
> This looks quite useful regarding the size reduction of btrfs_bio,
> please fold it to the patch. Thanks.
The 6.19 branch is now frozen so this patch will be applied separately
later.
next prev parent reply other threads:[~2025-11-24 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 10:17 Daniel Vacek
2025-11-18 12:07 ` David Sterba
2025-11-24 18:09 ` David Sterba [this message]
2026-01-07 17:00 ` Daniel Vacek
2026-01-08 14:35 ` David Sterba
2026-01-08 17:00 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124180904.GR13846@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neelx@suse.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®