From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0375B2BE64F for ; Mon, 24 Nov 2025 18:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764008126; cv=none; b=BJH96AlFOvz7Dd9YiN5/dAHcXR2zUlZwin369S0dhWJHG999Vj7lYSxla5VcwH+2IwUv6o/YI+JOz0me81XSrYwSJX7YZzR7PjuWfln41+SRqKjvVQAc3UR68gvyWvrg9psFRWwqc4bBhlADXuEakM/C247NC4R0/I8FXwUCbNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764008126; c=relaxed/simple; bh=oaO9+ksMmAmFh8G3d/UWZR17wgRENiWkTx5pMqdCZ/s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PhKbKCooK5fCSyypKkRN1JMjfpVl0855yKQ2kZjnhnqip8O8pGAkZTIHZjFT/i77xjoUqNwzQCXdN/maoKRr2ZWMyc+Bf8kMAmbKy16yap2TQOgpGmblbOa3+woEiC9PKbdcecROBrhDqwugQG23p2O/AbeExZeixPPmR59ReP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=hmipOWQw; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="hmipOWQw" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-8b2ea2b9631so474462585a.3 for ; Mon, 24 Nov 2025 10:15:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1764008123; x=1764612923; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XAHO0RxAUU9BHjlHal7mcB9U9OIjPdFjUpW/PKR/KN4=; b=hmipOWQwwy+PGTCJJiKj+ngmq6blH/4QSn6Vu6Tg1jKfel9Vq2lNw4WEYwDgaL65ns TCfLu1EMnWe7OfUAFQAYwJzvSD4pKWz5jJoa4ek+nf4NIBjWju5gAbayU134tBtIIDmE KyXKtgTqbpNO48qi5Ekvj116WMwdXViNjMzJhoWbRJQoFjr8arIgvl2AAtQFfvfrRAK4 weQCDUqmN208FhB3SKQ1t7GDJCDsJUvZ3fwb5uwBBQz8f3VeL5izqgdtLGbz623VBvsX vfGb9gA0JW2osUYMwokP7iC9t48b+qKZWPYq2EdLH6XPmddjuD9sSwgZqDchZMiSmVeT cR4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764008123; x=1764612923; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XAHO0RxAUU9BHjlHal7mcB9U9OIjPdFjUpW/PKR/KN4=; b=q7Vsvuctg8OdhNa/4fJzqMN99PqRTpC30bee1nxdgIseSDRQC6n21zsJK7/e54TnAz rK48XolntT51O7wyYaWyGp+UWY33uA7v9jE9Ot/jFbmN3AfaMDShhz2jnk+EafHDch2U MzY6/dcTs00K/nY0qONMH59zrc+4e+lyyNCsajbN3esGaLCYvLHJ8ZZvxvKByEckop+Z ijlLMQrbdjWrVBveMW5kDt8GYXiZPuOgSjdpQQYYmKMRJOO6nmJBdsTr81mSQ4ToJT3x DEfCZ+6zGuHlivWsH5enJjvTfKbCyBjtiKNfxkfMBy7MdGJ2+LmC/yhYufR0S+j7jZBA 4FKA== X-Forwarded-Encrypted: i=1; AJvYcCVUWny4t40t4U3YXMcZGORXW2VV2BA42OjDVBYpBa+K+pd96S/whVYQ5ngSW8pz1QUdBLQ5iiM/a7Qc3NA=@vger.kernel.org X-Gm-Message-State: AOJu0YyfoYchtJgyRQadNdnuHI2Hdi95cx1glCQh+ufHNDU1WWdkNpSh vnVWNROvV9evzsiBjlgpks5H9lDrDwUAg5N3BjL4DCS2OM3meY55cY7b9MPN9rmqEnw= X-Gm-Gg: ASbGncv8HHV3LnOMgiysa2YT+QmaU4FtepfrdTPtPo2dRBrKgLC9hce5uerRjV0XFf+ wd0ZZ4iZZGEf0HPMHe4jN72NDjNkCrpqhkq3wYMkkeaNCTZAikzTVKqKjus5LD0HEhA27bozWhX jI76Oyu5LmNgnYmCeVy5QX52bXcBzMJ1W805AcBeztIZSQIliX5M98fdjjqGwW4p9yDPjc/7SbM a3jBjGr0dJgwBIpgkVWAYxXNt5YqDbfCzW2I0Puv/ouaVaOxSjyul+m+VXi505M3AKAXig2B7V4 RPx6iQt+by0mzjZATo9npnSaXEJTxgeH94/jblBx5uV2bHZL1RKi3+rD/GAUNzLpPX9Mbt5t4Nl xilXvyHu9owGNYtRWGETFDX1cF82eLt4WvwC/K0gaUsfg60V4quqFiJnGMVJKCzFYZ8ACwEm8Ck AM9JFuOJyERxLKWTSEc3HEntyENQiH4dWkXVgfuL4bFnHx2U6uxpi3GPkQ X-Google-Smtp-Source: AGHT+IGEDEsDVHu0ai07iEFLkFyQqkbEzzKRecphdpKKSUM3yi9cRx3p6uQMP7udunSiJx1xq9RjJw== X-Received: by 2002:a05:620a:c50:b0:8b2:e598:e319 with SMTP id af79cd13be357-8b33d4b4ea8mr1713953485a.49.1764008122703; Mon, 24 Nov 2025 10:15:22 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b3295c3306sm999887985a.31.2025.11.24.10.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 10:15:22 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vNb5t-00000001xAo-2h5U; Mon, 24 Nov 2025 14:15:21 -0400 Date: Mon, 24 Nov 2025 14:15:21 -0400 From: Jason Gunthorpe To: ankita@nvidia.com Cc: yishaih@nvidia.com, skolothumtho@nvidia.com, kevin.tian@intel.com, alex@shazbot.org, aniketa@nvidia.com, vsethi@nvidia.com, mochs@nvidia.com, Yunxiang.Li@amd.com, yi.l.liu@intel.com, zhangdongdong@eswincomputing.com, avihaih@nvidia.com, bhelgaas@google.com, peterx@redhat.com, pstanner@redhat.com, apopple@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, zhiw@nvidia.com, danw@nvidia.com, dnigam@nvidia.com, kjaju@nvidia.com Subject: Re: [PATCH v5 3/7] vfio/nvgrace-gpu: Add support for huge pfnmap Message-ID: <20251124181521.GV233636@ziepe.ca> References: <20251124115926.119027-1-ankita@nvidia.com> <20251124115926.119027-4-ankita@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251124115926.119027-4-ankita@nvidia.com> On Mon, Nov 24, 2025 at 11:59:22AM +0000, ankita@nvidia.com wrote: > +static size_t nvgrace_gpu_aligned_devmem_size(size_t memlength) > +{ > +#ifdef CONFIG_ARCH_SUPPORTS_PMD_PFNMAP > + return ALIGN(memlength, PMD_SIZE); > +#endif > +#ifdef CONFIG_ARCH_SUPPORTS_PUD_PFNMAP > + return ALIGN(memlength, PUD_SIZE); > +#endif > + return memlength; > +} This needs a comment why it is OK to change the size up? Seems really surprising (and wrong!). The commit message should explain it too. Jason