From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16434314D2A for ; Tue, 25 Nov 2025 11:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069672; cv=none; b=DT5jSDg3422HMP/m7NJFzem75i0OJmOrdmmEG6YkjxTQlIxPSe5CNpXoqyfhVqQ819gG7CwQ+UfT/AzWcm4/Lt+Iea8EPj0/fYV3M+VgweaXywNNUawQGgA1gCRWkyKFyzMmO4LKKcfMpu5po/epxar4/y70IrSwaPxA+TH7xc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069672; c=relaxed/simple; bh=lCQ3i0WjgmV/u/HtYvF3mEQpx4d5c2GPE9QqXAXdOds=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gSAKsXXWf3NsNp7b3S4LyyCZGb5W88QvAYc+7u77v0LmsfYsW9YNRQsl9y7yJuPk84RwSMks+h+qqfP8MKzfZhe+KpLV8x+LkuuK63+ODEil3QkhTTvbhsQ6S4qYtWKokbk2dvRO5i6LLtmGDmSKuzesS2yO4GOnlElpOyuKOZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kt89ymdO; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kt89ymdO" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-343806688c5so4592787a91.0 for ; Tue, 25 Nov 2025 03:21:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764069670; x=1764674470; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OOfabRqw58uXymfi0oKljc2zuZSidHR+PfYRIsIU/J4=; b=kt89ymdOikEzMyqdT0Lil8iA1qO30kxzToQeeE01Pb1PTfmOnKWQ/r2j9OLmgIbMzf KuPEUAINlREsVnVVeKGn2dXvAImoBWE17mILbrBxCTo+m+7U4Ok7BhBOVRFZO9zi0s77 KUIjobNryRC+B+pZERhxrgRbzcak+4Xt9AM4Ew0wfmHi4uMK26bgST9veTqPQnZjJAE3 msVANRQEPUBTReC4k03n3FovbM845TS8Wp8nddY2j8jUUEovotbaz+sMsTErkrWfFx0a u8T7XJzjyMiv1GEaddq/RYXOXE4Gt8VUnNaeG052tnkhsAO2Q3Zy6624EBDsaaZX0QBG DUZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764069670; x=1764674470; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OOfabRqw58uXymfi0oKljc2zuZSidHR+PfYRIsIU/J4=; b=PmkO7EoMee2/BeGUBgm6dXU/bxaNFe9ADg58cb53rjtsdnbSGMpewHjQ2A0FsKt/S/ BC6CjPuoUDU7HlUjaxMD/MWXiDt+Ll+0W83uUiXVXKpS5pHuPKLfXq6HPeEz9f7gW1w/ acn6+fNXJMa6ocXExza8QaW+t6wSVeXw9CDDOAbEq4KlCFA2Ka06gcKnKZ2lxZb5iOdT rugoXvOKnLAoxdCc9bHTSLh9sci7vG7T+/PSEkaymHs5BLxxzktIibdCq4VITIyzfh/z IBPZvCs212fnsHo2VNnPK1xJkgmXE4o3k2KAqrDqWe2m5AynR+SsNavp+MCRnLjz/RmP 9O4w== X-Forwarded-Encrypted: i=1; AJvYcCXtO7pb3xYQS9X3+23a0Dm5M9NBsHko2W3YO3tA/hunAfXTkLJD5yrpWZZnLewIYwiTFjL+CYvNYQuRDiU=@vger.kernel.org X-Gm-Message-State: AOJu0YzPHFLaVpF9AyM0Xb+Akfiog2HwBG/srMdQpBk58b9uNhmxh4+p D4dazUPgHDl5wJ3MwpaJoO3fAq1d2M2SGxWnSEvSk4xmrj7a7HmDUXEc X-Gm-Gg: ASbGncu2EjHJsgpV49OEfueQ6YlQIWdA415dqH81FGoxAJevGOlQGHJrAQKNgCi879X fys79cKGm1GMciZCxT3grmbadJbhqHp1D8dLcLHbu0otIIE6ps7RO2WG635v/cKzPy8FtQQNVYK iaMzEnYbJrbqXsYw7GlX2Pm9PnzPdzHlTdYc0aMdCTgnnBi2G8ZHFRj7BorXvLwzWTXUUHrX4Bo X9r0I42bBT+rvksTYcgR+MPjFIse3a9NFEaeFNCA8pSUZHhWokBETRDKXQXy0JwO6WTSwDbYBUZ 903yI/jTNEZkSC+G+rLI1mro8TJVZGaVTDT1O9/R5VfQE432iMYqprzPjuj4SOEHfwSbcnqgiBM MKrZUcPdddNOMexL0Fe17eGuMBbblGbEChxADtOVnS41DXDQbWG00GYkJ+CRNEPLZIgiykDquzg 75OijnKRrGHQMRGgdD8ETGwp6Rp5VjGJe7ZNZPB+CnoPu6VIuUGw/OMK2WZCFXu1ffWLhnVBMsv glZkBcCudzPPtxtdqPMnI5Oqbqx5QS+rejzjZ9i5aGWuXiniTOHrx/Xi4yacnMianJKT+wDdxS0 Pugt4oXrEmTJYlwvyHUoSXdHCYp+Y3WVvg== X-Google-Smtp-Source: AGHT+IEQSYwVhgcpMBagRBpg3X15saNeb55RL/ZmOsxu+d8Fsz4VHtaZZRevI+ps0r8yq5Ct+bZ2vA== X-Received: by 2002:a17:90b:4c4f:b0:343:edb0:1012 with SMTP id 98e67ed59e1d1-3475ed508e8mr2412235a91.21.1764069670258; Tue, 25 Nov 2025 03:21:10 -0800 (PST) Received: from cyberkunju.asia-south1-c.c.gen-lang-client-0196962068.internal (125.31.93.34.bc.googleusercontent.com. [34.93.31.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34727bcaf13sm16296250a91.1.2025.11.25.03.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 03:21:09 -0800 (PST) From: Navaneeth K To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, david.laight@runbox.com, Navaneeth K Subject: [PATCH v2 0/5] staging: rtl8723bs: FIELD_OFFSET macro cleanup Date: Tue, 25 Nov 2025 11:20:54 +0000 Message-ID: <20251125112059.16913-1-knavaneeth786@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series cleans up the rtl8723bs driver by removing the custom FIELD_OFFSET macro and replacing its usages with the standard offsetof() from . Changes in v2: - Split the series for proper bisectability: the FIELD_OFFSET macro definition is now removed in Patch 5 (after all usages are converted), rather than in Patch 1. - Patch 1: Now only removes unused RGTRY_OFT, RGTRY_SZ, BSSID_OFT, and BSSID_SZ macros (dead code not used anywhere in the driver). - Patch 2: Split long line to fit within 100 columns. Also added include to basic_types.h to support offsetof usage. - Patch 3: Fixed brace formatting issue caused by removing commented code. Removed unnecessary outer parentheses, moved the inline comment to its own line, and added braces to the else branch for consistent style. - Patch 5 (NEW): Remove FIELD_OFFSET definition now that it's unused. Navaneeth K (5): staging: rtl8723bs: remove unused registry and BSSID offset macros staging: rtl8723bs: use standard offsetof in cfg80211 operations staging: rtl8723bs: remove dead commented code from odm.c staging: rtl8723bs: replace FIELD_OFFSET usage with offsetof in rtw_mlme_ext.c staging: rtl8723bs: remove custom FIELD_OFFSET macro drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- drivers/staging/rtl8723bs/hal/odm.c | 13 +++++-------- drivers/staging/rtl8723bs/include/basic_types.h | 3 +-- drivers/staging/rtl8723bs/include/drv_types.h | 7 ------- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 3 ++- 5 files changed, 10 insertions(+), 20 deletions(-) -- 2.43.0