From: Borislav Petkov <bp@alien8.de>
To: Devang Vyas <devangnayanbhai.vyas@amd.com>
Cc: yazen.ghannam@amd.com, tony.luck@intel.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
Ramesh Garidapuri <ramesh.garidapuri@amd.com>
Subject: Re: [PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh
Date: Tue, 25 Nov 2025 13:18:02 +0100 [thread overview]
Message-ID: <20251125121802.GEaSWeeg36pHTqMAlR@fat_crate.local> (raw)
In-Reply-To: <20251124181335.284780-1-devangnayanbhai.vyas@amd.com>
On Mon, Nov 24, 2025 at 11:43:35PM +0530, Devang Vyas wrote:
> This patch updates the EDAC driver to include support
Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.
Also, do
$ git grep 'This patch' Documentation/process
for more details.
> for AMD SoC family 19h models 40h-4fh to support
> Ryzen 6000 CPUs/APUs ("Rembrandt").
>
> The added changes enhance the ability to detect and
> report memory errors on systems that utilize AMD SoCs
> from the specified family.
Lemme repeat my comment from last time:
"Use the commit message to explain why those need to load the EDAC driver at
all."
Your text still doesn't explain why amd64_edac should load on a client CPU:
https://en.wikipedia.org/wiki/Zen_3#Rembrandt
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2025-11-25 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 18:13 Devang Vyas
2025-11-25 12:18 ` Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-11-23 14:27 Devang Vyas
2025-11-23 15:33 ` Borislav Petkov
2025-11-23 16:41 ` Vyas, Devang nayanbhai
2025-11-23 17:57 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125121802.GEaSWeeg36pHTqMAlR@fat_crate.local \
--to=bp@alien8.de \
--cc=devangnayanbhai.vyas@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ramesh.garidapuri@amd.com \
--cc=tony.luck@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®