From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7F05241679 for ; Tue, 25 Nov 2025 20:42:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764103342; cv=none; b=rV3qE3gSN/dyRyrNQZAmSqw477VVuB80raXHXzD/lorbaxTK1oYc3d1cJkNZLuC2OWRsc7H2TT4ZZRveGUsvLt8pEXQYgiJesGaDOyPChwOph3DVhwgEcZ+fGSB20F83ge0ns7mpcwWMJfqun5UiuC/vD7gdY9nJQWzrPwflsDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764103342; c=relaxed/simple; bh=rAwu7od3Ig4NqIN7e2uSUs1FVPZ+2Q7sQSsIkrvJzeM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ncIdImTxqUoPm4w6TtWAWcCoPix3wzQt2DCw++VQ8ryXfVEQFcUUc2jLUsC/uY3pIqHbpHbDLRblx92Q3kPyu50sn/bAxB01IZv4OoMtNdpUh0epE/Co8iacJFitlcW9kgxZS3P+8rqnqx52XLHI47uliPNs1pM5xTeV/MDEptw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b0QRS2hQ; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b0QRS2hQ" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-429c5e0f94eso720530f8f.3 for ; Tue, 25 Nov 2025 12:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764103339; x=1764708139; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=g/AUE+w4FR4w7EMLBkAOfRzsYhVrT0p72HoCrpmdLCo=; b=b0QRS2hQm67bVPGSTSmH54qqfUVLqLzFloe49+w3W5Z/XmohG/rrL/6dxgD6WyHb6f K7cODg2etfBgU6AciC43CaGt/ZGeGqr/2lNvu9OIaih25U7pd7Bc7CF9Y1d2yB6gz2ts vm19rwniiAVp57hzxnUP35AgT+OELeRD8JFR8E9TPBVnhIrh1j1AN852yCXvteO+c4wR lu7y4dNBMBhMxaw27EmTmaVoyjZvej2qhIWR5MmEYiF7nEWpaX/sDupd10eVl7BvbktC nQE//JgJKnD/8X3U2sBPGlnmkXXgip1OtJOnBmid+tN0hprOtxzHoSRXnqb/gQUx1vZ3 GPCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764103339; x=1764708139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g/AUE+w4FR4w7EMLBkAOfRzsYhVrT0p72HoCrpmdLCo=; b=j7MwIRg24N3IwpGksJ7rpk0KggJHEOAfxAFFAxrvsE6/byik8NerfX8+XFUwX7N/MM sWbOIOVFp2M9LRjbHgEvoJuJVLJx1iUTi/NfddO1FvJFk8YgRBDxDglfukbZ+r5tYGG7 7wgIE178xpFjD5rEThTPD73Bt8vpZCTAK5TsaIfb76961yJNXpwZQphM1rE1hOD3T0J+ xx0mVO5M2aA/r/CZyFTiF0gbYWX5AaDyWXabB5Hw071d9RKnwyYXf9YlEYOXRYTqdgeH M7gOvJdt1tKCWFoyxiMYgce5uwG7gi6FJKMzYTpUMf4sRj2UMF1oI46f0QK7PDV4c4GQ BHAA== X-Forwarded-Encrypted: i=1; AJvYcCXBJY9JFyhe3Ckfx5NTfwq12pwfYJ55t9varfWEU9dJ175HbmVjYBS3G+/v+gRPBciJsY52A+XtlTwc9jo=@vger.kernel.org X-Gm-Message-State: AOJu0YzrAF8ejyvP0y4BswsvI2Fv9ACRu5C3oFETxe42UUDNz2qpq3Ww pzrYWDwoqO536OPaihp5YbG0Wre2T6FU/OCftR6HzsZNvP/qIFNpdpZk X-Gm-Gg: ASbGnctCnVR/Nm5TPHRGxWEfMUknEZa9AYdEniMVLIfV/4hYL+X1phTEkZtboYxMP0e fWRhkgnMbrFKq78+xXYq7ILSLghQlOVC4veDo0gNoGMny3uwYpwgilDuRSlkf2xhHy4ZArrV1QX ym1cOvKUDeFHUOlZWthXMjdnSVz5tqGxs7SafUCXZWhh0h+CLZQ3ZDDd5Vkhc7HTbnGoJqP5R5h RkL+6K4axKGCXHhex/oL+jIQ1/gp+gNCwTSK8pLd7VUcbDcKJpgpOBF6TknvTy653gz8i0GgGWS Sz+QaaFOchoD+Q+KOgsRa6p8m8EipdRy9R3FNsI12O9+nuTUV95x6uFnKC/pQR0yxIda+KW903j 3ONBdaLxIKUgPCxXKm0ZfLxFKSuRH1Sg1HDTEp6D7+qyL7jmC8BhYLZ9f1gkHYDNmXb4b+3ACkf 6PRU1sWLMdaid/kg== X-Google-Smtp-Source: AGHT+IHgNnBm5YWUVW6u0g8PR6nFQpSwsxhpHokFNGnunRVwV83McGAhdoS0yK0tHPys4trkbLZE7A== X-Received: by 2002:a05:600c:1551:b0:477:9f61:8c20 with SMTP id 5b1f17b1804b1-477c311cdd1mr102602195e9.2.1764103338948; Tue, 25 Nov 2025 12:42:18 -0800 (PST) Received: from skbuf ([2a02:2f04:d106:d600:a04c:7112:155f:2ee5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4790ab8b21fsm8353315e9.0.2025.11.25.12.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 12:42:18 -0800 (PST) Date: Tue, 25 Nov 2025 22:42:15 +0200 From: Vladimir Oltean To: Jonas Gorski Cc: Florian Fainelli , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?utf-8?B?w4FsdmFybyBGZXJuw6FuZGV6?= Rojas , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 4/7] net: dsa: b53: fix CPU port unicast ARL entries for BCM5325/65 Message-ID: <20251125204215.2lz44qdegapgncn5@skbuf> References: <20251125075150.13879-1-jonas.gorski@gmail.com> <20251125075150.13879-1-jonas.gorski@gmail.com> <20251125075150.13879-5-jonas.gorski@gmail.com> <20251125075150.13879-5-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251125075150.13879-5-jonas.gorski@gmail.com> <20251125075150.13879-5-jonas.gorski@gmail.com> On Tue, Nov 25, 2025 at 08:51:47AM +0100, Jonas Gorski wrote: > On BCM5325 and BCM5365, unicast ARL entries use 8 as the value for the > CPU port, so we need to translate it to/from 5 as used for the CPU port > at most other places. > + ent->port = (mac_vid >> ARLTBL_DATA_PORT_ID_S_25) & > + ARLTBL_DATA_PORT_ID_MASK_25; > + if (!is_multicast_ether_addr(ent->mac) && ent->port == B53_CPU_PORT) > + ent->port = B53_CPU_PORT_25; Why not use is_unicast_ether_addr() to have a more clear correlation between the commit message and the code?