From: Ludovic Desroches <ludovic.desroches@microchip.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
"Ludovic Desroches" <ludovic.desroches@microchip.com>
Subject: [PATCH 2/3] drm/gem-shmem: revert the 8-byte alignment constraint
Date: Wed, 26 Nov 2025 15:44:45 +0100 [thread overview]
Message-ID: <20251126-lcd_pitch_alignment-v1-2-991610a1e369@microchip.com> (raw)
In-Reply-To: <20251126-lcd_pitch_alignment-v1-0-991610a1e369@microchip.com>
Using drm_mode_size_dumb() to compute the size of dumb buffers introduced
an 8-byte alignment constraint on the pitch that wasn’t present before.
Let’s remove this constraint, which isn’t necessarily required and may
cause buffers to be allocated larger than needed.
Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
---
drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
index dc94a27710e5f48839a5d2e9e9ea5152ff22e438..93b9cff89080f94e5d6e4663ef642b4c36e93c71 100644
--- a/drivers/gpu/drm/drm_gem_shmem_helper.c
+++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
@@ -559,7 +559,7 @@ int drm_gem_shmem_dumb_create(struct drm_file *file, struct drm_device *dev,
{
int ret;
- ret = drm_mode_size_dumb(dev, args, SZ_8, 0);
+ ret = drm_mode_size_dumb(dev, args, 0, 0);
if (ret)
return ret;
--
2.51.0
next prev parent reply other threads:[~2025-11-26 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 14:44 [PATCH 0/3] revert the 8-byte pitch-alignment constraint for memory managers Ludovic Desroches
2025-11-26 14:44 ` [PATCH 1/3] drm/gem-dma: revert the 8-byte alignment constraint Ludovic Desroches
2025-12-02 17:02 ` Thomas Zimmermann
2025-11-26 14:44 ` Ludovic Desroches [this message]
2025-12-02 17:03 ` [PATCH 2/3] drm/gem-shmem: " Thomas Zimmermann
2025-11-26 14:44 ` [PATCH 3/3] drm/gem-vram: " Ludovic Desroches
2025-12-02 17:09 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126-lcd_pitch_alignment-v1-2-991610a1e369@microchip.com \
--to=ludovic.desroches@microchip.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®