mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: JiangJianJun <jiangjianjun3@huawei.com>
To: <James.Bottomley@HansenPartnership.com>,
	<martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <hare@suse.de>, <dlemoal@kernel.org>, <yangxingui@huawei.com>,
	<hewenliang4@huawei.com>, <yangyun50@huawei.com>,
	<wuyifeng10@huawei.com>, <wubo40@huawei.com>,
	<jiangjianjun3@huawei.com>
Subject: Re: [PATCH] scsi: scsi_error: the Error Handler base on SCSI Device
Date: Wed, 26 Nov 2025 11:07:28 +0800	[thread overview]
Message-ID: <20251126030728.2275040-1-jiangjianjun3@huawei.com> (raw)
In-Reply-To: <b62930b3-9b80-4b06-b922-c38c7e309048@acm.org>

> The current behavior should be retained as the default and the new
> behavior should only be enabled if a SCSI LLD requests the new behavior
> because many SCSI LLD .eh_host_reset_handler implementations are based
> on the assumption that no I/O is in progress if they are called.

However, the Device-Error-Handler does not call `eh_host_reset_handler`,
but instead calls `eh_device_reset_handler`. Only the Host-Error-Handler
will call `eh_host_reset_handler`. Therefore, any assumptions or designs
made by the SCSI LLD in `eh_host_reset_handler` will not effected.

Even so, is it still necessary to add a switch that allows the SCSI LLD
to decide whether to enable the Device-Error-Handler on its own?

Jun.


  reply	other threads:[~2025-11-26  3:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25 12:48 JiangJianJun
2025-11-25 16:36 ` Bart Van Assche
2025-11-26  3:07   ` JiangJianJun [this message]
2025-11-28 14:31 JiangJianJun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251126030728.2275040-1-jiangjianjun3@huawei.com \
    --to=jiangjianjun3@huawei.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dlemoal@kernel.org \
    --cc=hare@suse.de \
    --cc=hewenliang4@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=wubo40@huawei.com \
    --cc=wuyifeng10@huawei.com \
    --cc=yangxingui@huawei.com \
    --cc=yangyun50@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®