From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6817333C18B for ; Wed, 26 Nov 2025 16:00:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764172833; cv=none; b=D5gvtnAL1IyYMu9wKcNKBgPNFEpXucpPHVKbt3OruZfNnKnrLvkU48oSAkAKQ4eLqtSXUqbHQWxGcnl5yRCex9Q4B9CRYU1EBNQN0gd7CebXCu3mqFs5LsoWM/+NHC2zcBFvkLtU9tocCcmVHhanzZFTU72fRtbuB0pQ5TNJTIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764172833; c=relaxed/simple; bh=WBJ9UwUNrgy/X0b0BvnOXQpDRGyYIy7WU+2Gj+p774c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=S2s63JlmQHhgSDzO/jSaJyqaOUKlrP4V5Ht9J5V2lWxvU/Lu2mnVtdZrm0c+AUy8oUFW0jft2INPx13oRvkFzyJ642JWIzR8+rQrkluUQFXgkV+WxXzEpOItlvqqJM6GVyOXo4+802XB+AVGgucNAZcBzaIivndFOhjuUj5GTKQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GznyddyK; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GznyddyK" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-297e239baecso8048385ad.1 for ; Wed, 26 Nov 2025 08:00:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764172831; x=1764777631; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rZ9M6k/4ewqJkE2TX87HwTQsuW0EN1M63J7M16fS/j8=; b=GznyddyKpf8VEbt0x7coIKsZpiCgiyOza3ZG0WDpm3vX4OlWsyrTmM5SKHqAuS4UYz n7ypeJ0k6VsF3SxHF/VSEBykvU82dWT7h0LDSbjekroXMkqyUKeHI/hbvDpTzc5EH/x+ 5JwmQ6p/nn1JsN8tqBTx9jQFnu9RaSil8FV65Alz5KnFDxjf6h1C9Bt9B6/I6+P8zcJg mHq+ckc26vQki1ZAMEdh5Wg9iIHjhMPrPvbWoQwLwvKe5x0v32SUUFqQEI9TBtcLaeEk S+ZYHo0XPxBKP/yZ7iBmpQL/n7jq81Quoeq+xb6EB49q4GKsAg/yClET1L1bAZB14Psr o/Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764172831; x=1764777631; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rZ9M6k/4ewqJkE2TX87HwTQsuW0EN1M63J7M16fS/j8=; b=WtNGlXZ4Xjmy1f0iVZ89GH3n4ElG2F2shA20vZ8EC5n8TKVGPVf9CSePLZPjSwF3Pc cPi5v+1vPmFIV65CcOdlpfMhX/0AjHXX+U0XqRAC3zv9RZOnsqErtdq4cR0YkgOSewGA oKQk1+NbdLhTOH3fBINAHO6R3+o5pihfsOuf5DldrK4hJ1rU7jDdcM7cd/LZWuY4oUMi 7R7wZxCEXosVztXUtcbSNOAmyncTHTc4JXBUYnGUV5HO9gUcCbKRa8+FG71JraCdWmjU +CK5Kdpeo6OZHw7/1Auw/ryYONJAkdl4QmRFQpx3fXR5D0+1GTHRqSy5JHgQmItnMC4r 7STQ== X-Forwarded-Encrypted: i=1; AJvYcCWwxUmCQsEfKcCR5AVpYayH6PVqQu6jyJC7099XK2d8YtmBZU9DbW1UpMQZe04+S4uAppUrFOwlahEQjp4=@vger.kernel.org X-Gm-Message-State: AOJu0YzR5rHdYsHPyjoOZP334RJZHPZ48yJZgdJ+vmdgAIIY6ujZEq9T PUiKwBLw2BTdMfitFJ0t5FIVO1chdR5xgVl1gLaahptGN885Mlzt3wCQ X-Gm-Gg: ASbGncunDS2A53cl6TczS6rucG0Xiaahdlva48YP1pCBS6j34TlWSu4s1tWSNutCrJ2 Gwhg6XxHSn/1XRrMF+xcmS6Twli1cWb4giciG8Fk135oHUPmM1h/sISO88kXb4EyL3VsErBQkc4 jZMGcDWBbgktVHt9gjIyfvh3Ps+6TeE7zlMnT4dwTmVW/Fs8627EWqS6w709xGw7qRJ0PZ5RIiZ jktv8I65m29kyA3kxKHYAwrZ7mpk7iR5vZPOl+Mpla6TXAB+rykIQH9A6gizWDJJKd6juiqemS8 kRGrJ7ByLCb/1aPUbKEQKy55akFxnvzAx18wXG8dibXfu9q462xQvDIIhekK8zdR520EbnqS+gj ZRmL6P5lXQzBReSr+4zQgg+sL0YRzhxLZEGFSmqKdkuJy+oZatqKbK4XGT01EZ8fUlSm82LTMGI GJ3/dNcXJsGYVGip4h1yH+Kg== X-Google-Smtp-Source: AGHT+IHW4vl9EURMb8YJrD3dHKPOSvMXx6AkbqAkBsNYyyUqCnQUvs3T4dn6AYYdWnbh0jPv+aNGrQ== X-Received: by 2002:a17:903:384f:b0:297:f527:885f with SMTP id d9443c01a7336-29b5df697dfmr276743665ad.0.1764172830405; Wed, 26 Nov 2025 08:00:30 -0800 (PST) Received: from DESKTOP-P76LG1N.lan ([42.116.199.188]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b13a865sm203447045ad.33.2025.11.26.08.00.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 08:00:29 -0800 (PST) From: Nam Tran To: lee@kernel.org Cc: gregkh@linuxfoundation.org, pavel@kernel.org, rdunlap@infradead.org, christophe.jaillet@wanadoo.fr, krzk+dt@kernel.org, robh@kernel.org, conor+dt@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v18 2/3] leds: add basic support for TI/National Semiconductor LP5812 LED Driver Date: Wed, 26 Nov 2025 23:00:24 +0700 Message-Id: <20251126160024.141129-1-trannamatk@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251125134836.GC1127788@google.com> References: <20251125134836.GC1127788@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 25 Nov 2025, Lee Jones wrote: > > +static ssize_t parse_drive_mode(struct lp5812_chip *chip, const char *str) > > +{ > > + int i; > > + > > + chip->u_drive_mode.s_drive_mode.mix_sel_led_0 = false; > > + chip->u_drive_mode.s_drive_mode.mix_sel_led_1 = false; > > + chip->u_drive_mode.s_drive_mode.mix_sel_led_2 = false; > > + chip->u_drive_mode.s_drive_mode.mix_sel_led_3 = false; > > + > > + if (sysfs_streq(str, LP5812_MODE_DIRECT_NAME)) { > > + chip->u_drive_mode.s_drive_mode.led_mode = LP5812_MODE_DIRECT_VALUE; > > + return 0; > > + } > > + > > + for (i = 0; i < ARRAY_SIZE(chip_mode_map); i++) { > > + if (!sysfs_streq(str, chip_mode_map[i].mode_name)) > > + continue; > > + > > + chip->u_drive_mode.s_drive_mode.led_mode = chip_mode_map[i].mode; > > + chip->u_scan_order.s_scan_order.scan_order_0 = chip_mode_map[i].scan_order_0; > > + chip->u_scan_order.s_scan_order.scan_order_1 = chip_mode_map[i].scan_order_1; > > + chip->u_scan_order.s_scan_order.scan_order_2 = chip_mode_map[i].scan_order_2; > > + chip->u_scan_order.s_scan_order.scan_order_3 = chip_mode_map[i].scan_order_3; > > Where are all of these used? These fields are part of unions (u_drive_mode and u_scan_order). The bitfields are packed into drive_mode_val and scan_order_val, which are written to DEV_CONFIG1 and DEV_CONFIG2 in lp5812_set_drive_mode_scan_order(). > [...] > > > +union u_scan_order { > > What is 'u'? The u_* and s_* prefixes were originally meant to indicate union/struct, but they are not idiomatic. I will rename it to union lp5812_scan_order { struct { u8 order0:2; u8 order1:2; u8 order2:2; u8 order3:2; } bits; u8 val; }; and do the same for u_drive_mode. Thanks for reviewing. Best regards, Nam Tran