From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88697306D3F for ; Wed, 26 Nov 2025 16:26:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764174421; cv=none; b=hO0PBqewMz+tKlPV/0kai6A6MUjlBJLTqBL6oLv8kT3aQp7CVKjU1bPkXhBhKTZ+tHT3RaGIgAgOt+GJyJ2ij74Qm8ykAi8LOno/Kza5+IcJCRa182LnQ4JHMboDdroKs/gpAJcEN+sJjbSt8e8kK65bjBet2OKanzJHleut+Qc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764174421; c=relaxed/simple; bh=L+PYLEg2c7RuySHWZyUigZ3QXYcF5wMa5NkODsxLMlI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a66R28APgBmqIC++hluRaNst7nhDrDTZ4VS9gVFe7Mrvt9DDYtJ9KZT6C56itsHKcAfnfNC3/9EXO1qY5WIjcXu0phXd62uZhge7wcns9UYYig5Dv2AshtO5qMxEMqBFkDiEi47hIW4/ZyikgVhaRDGi/2X9zrVfP3UCk2uc8yI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VIHMarr3; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VIHMarr3" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42b4c7b2c8bso479f8f.1 for ; Wed, 26 Nov 2025 08:26:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764174418; x=1764779218; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EpAyOKJ6Yz2Bai7wo0vq2pKge/BoDT3YbbpyLjfi24o=; b=VIHMarr3xxC2MyDMxx6Lc1L+237Tgd6kvaOO4OOGiQ8/9FRx7LWU7M1aJxUoHvDB3z gISMV4BFpB8OJBbnnxoUO6dotKIUz+e6MTje3Q7tY0ow/P7xze4lS+RgKhQMWI2Jalr5 /TJ9ZyhDacjLOslRcHwhcq3NxFEy8khl9lX8HxVNRdeKn+ZOuiHJXve+06dB2mK5dfYX +CJoFGQ92koEZR3PaeHRvMX1bjiw7TCGntwwnTwyK0DfrJoITLXhBYFmQmFFOy0X3KPP z21z/jDEtAzJ7PiP/u469g8VtBiJ7KEvF7R3ahxs6NiR1+Q86aQV3CEmIQ7QVcXOF9Wa nmvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764174418; x=1764779218; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EpAyOKJ6Yz2Bai7wo0vq2pKge/BoDT3YbbpyLjfi24o=; b=AvyB/oaQixUf1QF23QnkS64EhqGQZ9h5lg2w5cKqolRLFZN/rz7jIic5pQBrwyljIN K07ElaLPVyKrw3DhnYdtBg9vzM17VoAl7rM3jF8VZXywzIdhSxgRNGmOPH5RrVvEaCKa Z39x4tAx12qaVjUwPsukjvMyddooDXyHJq6xngMFGidv3fna6/XPypIaAeW+W1IMG28G NBUqQgHJvzUtbfVMcxs3mxdqFG0dYTKuD8SGJiev551oGjvzT2d9NbBlfcK/fLcbY7f4 Cl6LuMN6tp6aZMHSnMdKyPCWdeGxNtFXW2hlUCbYIbGvd48aLRh/vi70vxPLRKWc6wvG ac9A== X-Forwarded-Encrypted: i=1; AJvYcCVHFAcSTSUoAYZYNyjAnWlEHuJ9PWicO+axBAWqnIPgiPErUAhs4IVr32lKTEAg9fo+0IZvkhCWy522Gow=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2unjuUx74cgRbNhiQCBNDV3Tody7Sweb+BXgLFrLVYrKQdaY7 oYv3Zw9Xj905ke4OrE42g/5nwPYxTZh0eTegl9M/lUVI2sftz/Ipom08 X-Gm-Gg: ASbGncsVoRMUp9aGDkhFp8Vw9gevw2jPz74TvBBWmhIOg6z9lJK67mQgg7TcE3sjv8B phaClKaq8XzuCsu6/xbvfNo/4CVm7E+boIVmsFA1D2cSpzm+Bp5ILT2CBLq8spgPO9rVrIjwmE3 vfok0W9nn38/a2ruIMX0rWgMzvQTcWA0wVpfc6zgfbyg7nADWD29YtNwi/tYlnCnL7l3UjwcC+N s+t5NQxs9CGYJQ1XH15usisq4uTNmg+JKnc47DXKQ4KSFQwas0fno5zp/SiUEilaHg1yMl5XqeP DR8WnaMDtnsSSh8FYS00sC/JL8xl0fKXD53V/TW3T3E1lII5/5JnIHdcbWCnvaIcyT3yEcfXX/9 BF3ILfCwWuQILIc8eHkN/9HIsOse1xSfj6LlAscMkEtCdPtojWH/eNz2VyL33umruwFqVl1Bjzd 4uPCM= X-Google-Smtp-Source: AGHT+IGkdeqnD9yqbzrAoeydZNYIWHAMmCvdoKJOZqbNkiAFeEcyG+FQDxy2mbwwlCwcRB6Wqs6rYQ== X-Received: by 2002:a5d:5885:0:b0:42b:3d45:22dd with SMTP id ffacd0b85a97d-42cc1d2443cmr12237765f8f.8.1764174417590; Wed, 26 Nov 2025 08:26:57 -0800 (PST) Received: from skbuf ([2a02:2f04:d106:d600:a04c:7112:155f:2ee5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34fddsm42129300f8f.14.2025.11.26.08.26.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 08:26:56 -0800 (PST) Date: Wed, 26 Nov 2025 18:26:54 +0200 From: Vladimir Oltean To: David Yang Cc: netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Russell King , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 3/4] net: dsa: yt921x: Add HSR offloading support Message-ID: <20251126162654.ajcwikzh4vijspxf@skbuf> References: <20251126093240.2853294-1-mmyangfl@gmail.com> <20251126093240.2853294-4-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251126093240.2853294-4-mmyangfl@gmail.com> On Wed, Nov 26, 2025 at 05:32:36PM +0800, David Yang wrote: > Add offloading for packet duplication supported by the YT921x switches. > > Signed-off-by: David Yang > --- I like the idea behind this patch from a purely technical perspective, but there's an important question. Do you, or people you know or have interacted with, use HSR/PRP on the YT921x switches, in order to find this change useful? If NETIF_F_HW_HSR_DUP is the only offload that the switch supports, then one can hardly say that the switch was designed to be an HSR accelerator. I'm working on some patches to make this feature generically available to most DSA switch drivers, rather than being arbitrarily implemented here and there. The usefulness of having this single offload generally available is where I am lacking some data points.