From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6EE52FFDDC for ; Wed, 26 Nov 2025 13:20:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764163258; cv=none; b=VtIz9ODe/eJjrMh6XZ5sYwGJqrsr4KV/Wt+j+edPe72tOkOAKBlami4mY21fXSAJ4W9vm45eYbbSfxEvA6y6FgIegrmE+b+13MqrTjIhs7xWD9hg/M2mjP0D2b5RWvRH6wGwxkQGnMwsIryB9pjqwDT6RxqunesbgE+Y2aTy624= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764163258; c=relaxed/simple; bh=nzDp/t4byu0WbD0bbyhRhaWJ9Ti7+cm8kOQq0LFu9Pw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=YUqzp0OwAgNFaIABukjvZ5aAEruYDtunApbEkaNy8QYEtk2ZJhQjwjonZGgVIcGZS8kV0XAjG18xK1C2LYBW8mvNEfI2kQije/0WY0CHi+jto+Fj632983iVGWuSza32lk97DQQp2vMeJ8aGYvpxypqPSE292vgeHy+DFvGLNJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eHlEOnSs; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eHlEOnSs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764163257; x=1795699257; h=date:from:to:cc:subject:message-id:mime-version; bh=nzDp/t4byu0WbD0bbyhRhaWJ9Ti7+cm8kOQq0LFu9Pw=; b=eHlEOnSsCxI3wBlcaJZZykuYUftMPVuJpVjq32HTVJUXVUZZGfaNItXz UN/an5sr789cjutItjcmON5cdyMxzIIu9VRGxtt4HTuHBttsrT1X8CGXA uSgoxNarBqB74BkfmUhBXIvNW5ZSJFFz30J76X33FcTbKD4h6K/cnZDdG GgJ2z+wQo/HDyXYLvb+CDdtYlgTuxeBSBclvmV0Ry/MSMZ8YRJlaoZr3N iwXHxHb1GSroqUBuDXbnKKIdwjY69zFyncOzLQHdj83Okje9RuwRTXU+b fFyuSNgOr6pyCBk4zk+Vfcdc0fuSCjAMVmg3RGMjg9tABwr2+rt3mKqLK w==; X-CSE-ConnectionGUID: /wczWjrKQK+sCtE8UAAIMQ== X-CSE-MsgGUID: 8lsJBu9AS/W6ppgVtEJL8w== X-IronPort-AV: E=McAfee;i="6800,10657,11624"; a="83592264" X-IronPort-AV: E=Sophos;i="6.20,228,1758610800"; d="scan'208";a="83592264" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2025 05:20:56 -0800 X-CSE-ConnectionGUID: fiH9OeleTAusKneAfkI5Cw== X-CSE-MsgGUID: 2WFP07rNSn2b9J+2zv9r+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,228,1758610800"; d="scan'208";a="193030303" Received: from lkp-server01.sh.intel.com (HELO 4664bbef4914) ([10.239.97.150]) by orviesa008.jf.intel.com with ESMTP; 26 Nov 2025 05:20:55 -0800 Received: from kbuild by 4664bbef4914 with local (Exim 4.98.2) (envelope-from ) id 1vOFS0-000000002uZ-2bJP; Wed, 26 Nov 2025 13:20:52 +0000 Date: Wed, 26 Nov 2025 21:20:21 +0800 From: kernel test robot To: Dave Penkler Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: drivers/staging/gpib/eastwood/fluke_gpib.c:1013:21: error: implicit declaration of function 'ioremap'; did you mean 'iounmap'? Message-ID: <202511262154.8otdh3pN-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Dave, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 30f09200cc4aefbd8385b01e41bde2e4565a6f0e commit: 165e8cc3cfec9ef51f3376b0d49b115294f34f3b staging: gpib: Add KBUILD files for GPIB drivers date: 1 year, 2 months ago config: s390-randconfig-r053-20251126 (https://download.01.org/0day-ci/archive/20251126/202511262154.8otdh3pN-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 8.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251126/202511262154.8otdh3pN-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202511262154.8otdh3pN-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/staging/gpib/eastwood/fluke_gpib.c: In function 'fluke_line_status': drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not used [-Wunused-but-set-variable] struct nec7210_priv *nec_priv; ^~~~~~~~ drivers/staging/gpib/eastwood/fluke_gpib.c: In function 'fluke_attach_impl': >> drivers/staging/gpib/eastwood/fluke_gpib.c:1013:21: error: implicit declaration of function 'ioremap'; did you mean 'iounmap'? [-Werror=implicit-function-declaration] nec_priv->iobase = ioremap(e_priv->gpib_iomem_res->start, ^~~~~~~ iounmap drivers/staging/gpib/eastwood/fluke_gpib.c:1013:19: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] nec_priv->iobase = ioremap(e_priv->gpib_iomem_res->start, ^ drivers/staging/gpib/eastwood/fluke_gpib.c:1050:33: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] e_priv->write_transfer_counter = ioremap(e_priv->write_transfer_counter_res->start, ^ In file included from drivers/staging/gpib/eastwood/fluke_gpib.c:10: At top level: drivers/staging/gpib/eastwood/fluke_gpib.h:140:18: warning: 'fluke_num_regs' defined but not used [-Wunused-const-variable=] static const int fluke_num_regs = 8; ^~~~~~~~~~~~~~ In file included from drivers/staging/gpib/include/nec7210.h:17, from drivers/staging/gpib/eastwood/fluke_gpib.h:13, from drivers/staging/gpib/eastwood/fluke_gpib.c:10: drivers/staging/gpib/include/nec7210_registers.h:21:18: warning: 'nec7210_num_registers' defined but not used [-Wunused-const-variable=] static const int nec7210_num_registers = 8; ^~~~~~~~~~~~~~~~~~~~~ In file included from drivers/staging/gpib/include/gpib_types.h:16, from drivers/staging/gpib/include/nec7210.h:16, from drivers/staging/gpib/eastwood/fluke_gpib.h:13, from drivers/staging/gpib/eastwood/fluke_gpib.c:10: drivers/staging/gpib/uapi/gpib_user.h:344:18: warning: 'request_service_bit' defined but not used [-Wunused-const-variable=] static const int request_service_bit = 0x40; ^~~~~~~~~~~~~~~~~~~ drivers/staging/gpib/uapi/gpib_user.h:264:18: warning: 'gpib_addr_max' defined but not used [-Wunused-const-variable=] static const int gpib_addr_max = 30; /* max address for primary/secondary gpib addresses */ ^~~~~~~~~~~~~ drivers/staging/gpib/uapi/gpib_user.h:212:22: warning: 'gpib_command_mask' defined but not used [-Wunused-const-variable=] static const uint8_t gpib_command_mask = 0x7f; ^~~~~~~~~~~~~~~~~ drivers/staging/gpib/uapi/gpib_user.h:53:18: warning: 'board_status_mask' defined but not used [-Wunused-const-variable=] static const int board_status_mask = ERR | TIMO | END | CMPL | SPOLL | ^~~~~~~~~~~~~~~~~ drivers/staging/gpib/uapi/gpib_user.h:52:18: warning: 'device_status_mask' defined but not used [-Wunused-const-variable=] static const int device_status_mask = ERR | TIMO | END | CMPL | RQS; ^~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +1013 drivers/staging/gpib/eastwood/fluke_gpib.c 55936779f49612 Dave Penkler 2024-09-18 973 55936779f49612 Dave Penkler 2024-09-18 974 static int fluke_attach_impl(gpib_board_t *board, const gpib_board_config_t *config, 55936779f49612 Dave Penkler 2024-09-18 975 unsigned int handshake_mode) 55936779f49612 Dave Penkler 2024-09-18 976 { 55936779f49612 Dave Penkler 2024-09-18 977 struct fluke_priv *e_priv; 55936779f49612 Dave Penkler 2024-09-18 978 struct nec7210_priv *nec_priv; 55936779f49612 Dave Penkler 2024-09-18 979 int isr_flags = 0; 55936779f49612 Dave Penkler 2024-09-18 980 int retval; 55936779f49612 Dave Penkler 2024-09-18 981 int irq; 55936779f49612 Dave Penkler 2024-09-18 982 struct resource *res; 55936779f49612 Dave Penkler 2024-09-18 983 dma_cap_mask_t dma_cap; 55936779f49612 Dave Penkler 2024-09-18 984 55936779f49612 Dave Penkler 2024-09-18 985 if (!fluke_gpib_pdev) { 55936779f49612 Dave Penkler 2024-09-18 986 pr_err("No gpib platform device was found, attach failed.\n"); 55936779f49612 Dave Penkler 2024-09-18 987 return -ENODEV; 55936779f49612 Dave Penkler 2024-09-18 988 } 55936779f49612 Dave Penkler 2024-09-18 989 55936779f49612 Dave Penkler 2024-09-18 990 retval = fluke_generic_attach(board); 55936779f49612 Dave Penkler 2024-09-18 991 if (retval) 55936779f49612 Dave Penkler 2024-09-18 992 return retval; 55936779f49612 Dave Penkler 2024-09-18 993 55936779f49612 Dave Penkler 2024-09-18 994 e_priv = board->private_data; 55936779f49612 Dave Penkler 2024-09-18 995 nec_priv = &e_priv->nec7210_priv; 55936779f49612 Dave Penkler 2024-09-18 996 nec_priv->offset = fluke_reg_offset; 55936779f49612 Dave Penkler 2024-09-18 997 board->dev = &fluke_gpib_pdev->dev; 55936779f49612 Dave Penkler 2024-09-18 998 55936779f49612 Dave Penkler 2024-09-18 999 res = platform_get_resource(fluke_gpib_pdev, IORESOURCE_MEM, 0); 55936779f49612 Dave Penkler 2024-09-18 1000 if (!res) { 55936779f49612 Dave Penkler 2024-09-18 1001 dev_err(&fluke_gpib_pdev->dev, "Unable to locate mmio resource for cb7210 gpib\n"); 55936779f49612 Dave Penkler 2024-09-18 1002 return -ENODEV; 55936779f49612 Dave Penkler 2024-09-18 1003 } 55936779f49612 Dave Penkler 2024-09-18 1004 55936779f49612 Dave Penkler 2024-09-18 1005 if (request_mem_region(res->start, 55936779f49612 Dave Penkler 2024-09-18 1006 resource_size(res), 55936779f49612 Dave Penkler 2024-09-18 1007 fluke_gpib_pdev->name) == NULL) { 55936779f49612 Dave Penkler 2024-09-18 1008 dev_err(&fluke_gpib_pdev->dev, "cannot claim registers\n"); 55936779f49612 Dave Penkler 2024-09-18 1009 return -ENXIO; 55936779f49612 Dave Penkler 2024-09-18 1010 } 55936779f49612 Dave Penkler 2024-09-18 1011 e_priv->gpib_iomem_res = res; 55936779f49612 Dave Penkler 2024-09-18 1012 55936779f49612 Dave Penkler 2024-09-18 @1013 nec_priv->iobase = ioremap(e_priv->gpib_iomem_res->start, 55936779f49612 Dave Penkler 2024-09-18 1014 resource_size(e_priv->gpib_iomem_res)); 55936779f49612 Dave Penkler 2024-09-18 1015 pr_info("gpib: iobase %lx remapped to %p, length=%d\n", 55936779f49612 Dave Penkler 2024-09-18 1016 (unsigned long)e_priv->gpib_iomem_res->start, 55936779f49612 Dave Penkler 2024-09-18 1017 nec_priv->iobase, (int)resource_size(e_priv->gpib_iomem_res)); 55936779f49612 Dave Penkler 2024-09-18 1018 if (!nec_priv->iobase) { 55936779f49612 Dave Penkler 2024-09-18 1019 dev_err(&fluke_gpib_pdev->dev, "Could not map I/O memory\n"); 55936779f49612 Dave Penkler 2024-09-18 1020 return -ENOMEM; 55936779f49612 Dave Penkler 2024-09-18 1021 } 55936779f49612 Dave Penkler 2024-09-18 1022 55936779f49612 Dave Penkler 2024-09-18 1023 res = platform_get_resource(fluke_gpib_pdev, IORESOURCE_MEM, 1); 55936779f49612 Dave Penkler 2024-09-18 1024 if (!res) { 55936779f49612 Dave Penkler 2024-09-18 1025 dev_err(&fluke_gpib_pdev->dev, "Unable to locate mmio resource for gpib dma port\n"); 55936779f49612 Dave Penkler 2024-09-18 1026 return -ENODEV; 55936779f49612 Dave Penkler 2024-09-18 1027 } 55936779f49612 Dave Penkler 2024-09-18 1028 if (request_mem_region(res->start, 55936779f49612 Dave Penkler 2024-09-18 1029 resource_size(res), 55936779f49612 Dave Penkler 2024-09-18 1030 fluke_gpib_pdev->name) == NULL) { 55936779f49612 Dave Penkler 2024-09-18 1031 dev_err(&fluke_gpib_pdev->dev, "cannot claim registers\n"); 55936779f49612 Dave Penkler 2024-09-18 1032 return -ENXIO; 55936779f49612 Dave Penkler 2024-09-18 1033 } 55936779f49612 Dave Penkler 2024-09-18 1034 e_priv->dma_port_res = res; 55936779f49612 Dave Penkler 2024-09-18 1035 55936779f49612 Dave Penkler 2024-09-18 1036 res = platform_get_resource(fluke_gpib_pdev, IORESOURCE_MEM, 2); 55936779f49612 Dave Penkler 2024-09-18 1037 if (!res) { 55936779f49612 Dave Penkler 2024-09-18 1038 dev_err(&fluke_gpib_pdev->dev, "Unable to locate mmio resource for write transfer counter\n"); 55936779f49612 Dave Penkler 2024-09-18 1039 return -ENODEV; 55936779f49612 Dave Penkler 2024-09-18 1040 } 55936779f49612 Dave Penkler 2024-09-18 1041 55936779f49612 Dave Penkler 2024-09-18 1042 if (request_mem_region(res->start, 55936779f49612 Dave Penkler 2024-09-18 1043 resource_size(res), 55936779f49612 Dave Penkler 2024-09-18 1044 fluke_gpib_pdev->name) == NULL) { 55936779f49612 Dave Penkler 2024-09-18 1045 dev_err(&fluke_gpib_pdev->dev, "cannot claim registers\n"); 55936779f49612 Dave Penkler 2024-09-18 1046 return -ENXIO; 55936779f49612 Dave Penkler 2024-09-18 1047 } 55936779f49612 Dave Penkler 2024-09-18 1048 e_priv->write_transfer_counter_res = res; 55936779f49612 Dave Penkler 2024-09-18 1049 55936779f49612 Dave Penkler 2024-09-18 1050 e_priv->write_transfer_counter = ioremap(e_priv->write_transfer_counter_res->start, 55936779f49612 Dave Penkler 2024-09-18 1051 resource_size(e_priv->write_transfer_counter_res)); 55936779f49612 Dave Penkler 2024-09-18 1052 pr_info("gpib: write transfer counter %lx remapped to %p, length=%d\n", 55936779f49612 Dave Penkler 2024-09-18 1053 (unsigned long)e_priv->write_transfer_counter_res->start, 55936779f49612 Dave Penkler 2024-09-18 1054 e_priv->write_transfer_counter, 55936779f49612 Dave Penkler 2024-09-18 1055 (int)resource_size(e_priv->write_transfer_counter_res)); 55936779f49612 Dave Penkler 2024-09-18 1056 if (!e_priv->write_transfer_counter) { 55936779f49612 Dave Penkler 2024-09-18 1057 dev_err(&fluke_gpib_pdev->dev, "Could not map I/O memory\n"); 55936779f49612 Dave Penkler 2024-09-18 1058 return -ENOMEM; 55936779f49612 Dave Penkler 2024-09-18 1059 } 55936779f49612 Dave Penkler 2024-09-18 1060 55936779f49612 Dave Penkler 2024-09-18 1061 irq = platform_get_irq(fluke_gpib_pdev, 0); 55936779f49612 Dave Penkler 2024-09-18 1062 pr_info("gpib: irq %d\n", irq); 55936779f49612 Dave Penkler 2024-09-18 1063 if (irq < 0) { 55936779f49612 Dave Penkler 2024-09-18 1064 dev_err(&fluke_gpib_pdev->dev, "fluke_gpib: request for IRQ failed\n"); 55936779f49612 Dave Penkler 2024-09-18 1065 return -EBUSY; 55936779f49612 Dave Penkler 2024-09-18 1066 } 55936779f49612 Dave Penkler 2024-09-18 1067 retval = request_irq(irq, fluke_gpib_interrupt, isr_flags, fluke_gpib_pdev->name, board); 55936779f49612 Dave Penkler 2024-09-18 1068 if (retval) { 55936779f49612 Dave Penkler 2024-09-18 1069 dev_err(&fluke_gpib_pdev->dev, 55936779f49612 Dave Penkler 2024-09-18 1070 "cannot register interrupt handler err=%d\n", 55936779f49612 Dave Penkler 2024-09-18 1071 retval); 55936779f49612 Dave Penkler 2024-09-18 1072 return retval; 55936779f49612 Dave Penkler 2024-09-18 1073 } 55936779f49612 Dave Penkler 2024-09-18 1074 e_priv->irq = irq; 55936779f49612 Dave Penkler 2024-09-18 1075 55936779f49612 Dave Penkler 2024-09-18 1076 dma_cap_zero(dma_cap); 55936779f49612 Dave Penkler 2024-09-18 1077 dma_cap_set(DMA_SLAVE, dma_cap); 55936779f49612 Dave Penkler 2024-09-18 1078 e_priv->dma_channel = dma_request_channel(dma_cap, gpib_dma_channel_filter, NULL); 55936779f49612 Dave Penkler 2024-09-18 1079 if (!e_priv->dma_channel) { 55936779f49612 Dave Penkler 2024-09-18 1080 pr_err("fluke_gpib: failed to allocate a dma channel.\n"); 55936779f49612 Dave Penkler 2024-09-18 1081 // we don't error out here because unaccel interface will still 55936779f49612 Dave Penkler 2024-09-18 1082 // work without dma 55936779f49612 Dave Penkler 2024-09-18 1083 } 55936779f49612 Dave Penkler 2024-09-18 1084 55936779f49612 Dave Penkler 2024-09-18 1085 return fluke_init(e_priv, board, handshake_mode); 55936779f49612 Dave Penkler 2024-09-18 1086 } 55936779f49612 Dave Penkler 2024-09-18 1087 :::::: The code at line 1013 was first introduced by commit :::::: 55936779f4961299efa99a6843c8ff3b019d3858 staging: gpib: Add Fluke cda based cards GPIB driver :::::: TO: Dave Penkler :::::: CC: Greg Kroah-Hartman -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki