mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Deepanshu Kartikey <kartikey406@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzbot+94048264da5715c251f9@syzkaller.appspotmail.com,
	viro@zeniv.linux.org.uk, jack@suse.cz
Subject: Re: [PATCH] fs/namespace: fix mntput of ERR_PTR in fsmount error path
Date: Fri, 28 Nov 2025 10:26:35 +0100	[thread overview]
Message-ID: <20251128-leitfaden-aufpassen-c0ecf32c1020@brauner> (raw)
In-Reply-To: <20251128035149.392402-1-kartikey406@gmail.com>

On Fri, 28 Nov 2025 09:21:48 +0530, Deepanshu Kartikey wrote:
> When vfs_create_mount() fails and returns an error pointer, the
> __free(path_put) cleanup attribute causes path_put() to be called
> on the error pointer, which then calls mntput() on an invalid
> pointer value (e.g., -ENOENT = 0xfffffffffffffff4).
> 
> This results in a general protection fault in mntput() when KASAN
> tries to check the shadow memory for the near-null address computed
> from the error pointer offset.
> 
> [...]

Thanks! Heavily rewritten but I retained your authorship.

---

Applied to the vfs-6.19.fd_prepare branch of the vfs/vfs.git tree.
Patches in the vfs-6.19.fd_prepare branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.19.fd_prepare

[1/1] fs/namespace: fix mntput of ERR_PTR in fsmount error path
      https://git.kernel.org/vfs/vfs/c/721ebc9c4a95

      reply	other threads:[~2025-11-28  9:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28  3:51 Deepanshu Kartikey
2025-11-28  9:26 ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251128-leitfaden-aufpassen-c0ecf32c1020@brauner \
    --to=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=kartikey406@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+94048264da5715c251f9@syzkaller.appspotmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®