From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3081299A81 for ; Fri, 28 Nov 2025 08:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764317200; cv=none; b=OJJ+OsF9iposvskJ3oMpvpaI41+vTGspML9kyaYvmLBMfRJM8/vnGbcXdFEvK4/Oug8P+0LNxquZpALS1j+jePZmVSChgnGPEfGE3GoTKxZYlGzL1ykbegqjjsHFkJFV+xVuCQ/HaydaoDo6AlsjEqJMeJ4ByvDrCn5S5PL0Xgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764317200; c=relaxed/simple; bh=RuaSVob/OFTn3DUtIstH7NKQe0aOf/L3fs8hCElKy+8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=cTUNgSdWZkqWQILKt64PPaoMPDYz785fXc/2C7ZRZp7fpbhnrtqJJbPyDJm0Izf+Pt3kS2z402kqAJJIqP5zzxb+GwVbwe6SEGwDK4/jBZ/gdPBoun6R93n0DOaXDfnoj/rwpMsWmsmmwLXQTVg5XYtRWteODDI/SzqBuDydS/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FcknPLZo; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FcknPLZo" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-b73161849e1so348770366b.2 for ; Fri, 28 Nov 2025 00:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764317197; x=1764921997; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GF8qzZ5aC4QFBtOdX1V/ZnNJfJs6kDMMgn4xG0xdpzc=; b=FcknPLZoxpeHF6ymDH+7XUxTj79MeMl9Xe7+Pk6C9xfaywAeugPvcxG15stmoLPUHF vuGgXxbZkXpuB8ADtcGxqae7SlpjHlPrv3qs1Q7TIpf66YNxyOBOBlHr3qpStwX0M4Xn etqmsJEgwIfIzt91PtAHeI+pOc7Xl+m+U2v6MjvxqFsVP7pkebqYWwOt64annvaaq7M6 7DxH0gP4BoFK9h/Kr4Az3A+X5+bru8+Nsg2sSQYrqte49XYwXwOsnEf+/KaGGe7BeZ+r Ut5ESVSFUNGgdwyN4WEEPeIeeR4mfPXoGLPHZ1z7fG0aWPlQUuA6Qc13eoDh1AKgg4ZO eEWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764317197; x=1764921997; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GF8qzZ5aC4QFBtOdX1V/ZnNJfJs6kDMMgn4xG0xdpzc=; b=gjTYirRoEyghnFX2D0Bd9ynq1h9NRSY/9pKraybhLSBDhRLKMKaepKD+nkJ6XJDyZe WtqJ3uLJpgZP0KAHbrvqYR7rNpbk+l5aTPMrOCYvB6b4o6e8I9CominItjQFAYzv6Pz/ mN4Ase6XuxvRCtRydOtJQ8TbrQCH+a5I1Sv9prKoK64QmjLtD2aTFal1A10I2+VaWDxp /S0o+SrpGLpkXD9w51BRYPVitazBxWQNazCuFQrAtZzBrP7EUpw/1hMwrOKK8u+F01Ll aj70bP3P25TxwQk2OSrdeXhFObh/uprtYD4/TKZOlf6bDCaMnLrKM3AZ3GRbG+GeckB2 tw3g== X-Forwarded-Encrypted: i=1; AJvYcCX9x9+lxEcLbq0l0SAVtVcXeSj06xAadRgwLZIdV33CHnGmoeX4HYfivMx2xt/dLL+pGyOCGKOmBZ4QQBE=@vger.kernel.org X-Gm-Message-State: AOJu0YyHomb0uUtSP2/Kc+3qB+TigiD14uVrZ/HFWn2HOGo3UkacS8h6 b36jNS5jLv4Hw9ngg/NrEN4AX1F7a07tXSvNdWYMAIIVlrFmsTzIlCJQ X-Gm-Gg: ASbGncvmwXJHel/2o1B/OoPZP68LJ9Zw27vDEWzlQJmPOYHCyaAEDqx+SAb/JTQ1KiI HIAOusxHYOso3XyJdiz7FdOLtAYE1KNNOTLbP+H8f7jPF5O31SUZlD0QdPP5zO1ckeZubsXPaXz 783NBU1c8LzFbH0mFELtVIsB9p9YAz8iQQCrpxE3V2p4tNSQpzjEn669FH3dBJjMz6pRTe487Ra Iojxf6Vwbd1dJc0Z91fz8JW78l8iZ5JxFhTwCclIT8tAz3P0szz3Hs0XTgKUzMua40EzcGZ5LU7 ULz6W+7E8WIHPxxqfsQqD18X3UB/3JyRSv5DppFrC7UxQQnYG2ePj2eA2/iA78Ttjg+ku2hmLMy CkryJnxxwsxvMt3FosCtVyAUq+OQ/sgVcR96/OqSU3lTYtaAV94DAucOnu07oT0wAQiW1NLYMWp TnPkCeG0lasIodd1KpO3HnDKGeNcBcQNePHv9ZAw8RH6Z1Di9KoB36H4XQt6od8xW88Aw= X-Google-Smtp-Source: AGHT+IG8lMhmASq0Dqj7DDlPWZpnN/HYg/KOE/R9C95kx5h7OgFdH+Cpax+cHXAeZlu2/w6JZnbdgg== X-Received: by 2002:a17:907:97d0:b0:b73:6b85:1a8f with SMTP id a640c23a62f3a-b767170ae15mr2977239666b.49.1764317196535; Fri, 28 Nov 2025 00:06:36 -0800 (PST) Received: from localhost (dslb-002-205-018-238.002.205.pools.vodafone-ip.de. [2.205.18.238]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f51c6c12sm377322766b.29.2025.11.28.00.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 00:06:35 -0800 (PST) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 0/7] net: dsa: b53: fix ARL accesses for BCM5325/65 and allow VID 0 Date: Fri, 28 Nov 2025 09:06:18 +0100 Message-ID: <20251128080625.27181-1-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARL entries on BCM5325 and BCM5365 were broken significantly in two ways: - Entries for the CPU port were using the wrong port id, pointing to a non existing port. - Setting the VLAN ID for entries was not done, adding them all to VLAN 0 instead. While the former technically broke any communication to the CPU port, with the latter they were added to the currently unused VID 0, so they never became effective. Presumably the default PVID was set to 1 because of these issues 0 was broken (and the root cause not found). So fix writing and reading entries on BCM5325/65 by first fixing the CPU port entries, then fixing setting the VLAN ID for entries. Finally, re-allow VID 0 for BCM5325/65 to allow the whole 1-15 VLAN ID range to be available to users, and align VLAN handling with all other switch chips. Sent to net-next as it would cause an ugly, non trivial merge conflict with net-next when added to net, and I don't want to subject the maintainers to that. I will take care of sending adapted versions to stable once it hit linus' tree. Changelog v1 -> v2: * added Review tags from Florian * added Tested tags from Álvaro as far as the patches went unmodified * !is_multicast => is_unicast * only change b53_default_pvid() to always return 0 * stop rejecting vlan 0 for bcm5325() Jonas Gorski (7): net: dsa: b53: fix VLAN_ID_IDX write size for BCM5325/65 net: dsa: b53: fix extracting VID from entry for BCM5325/65 net: dsa: b53: use same ARL search result offset for BCM5325/65 net: dsa: b53: fix CPU port unicast ARL entries for BCM5325/65 net: dsa: b53: fix BCM5325/65 ARL entry multicast port masks net: dsa: b53: fix BCM5325/65 ARL entry VIDs net: dsa: b53: allow VID 0 for BCM5325/65 drivers/net/dsa/b53/b53_common.c | 47 ++++++++++++-------------------- drivers/net/dsa/b53/b53_priv.h | 40 +++++++++++++++++++++------ drivers/net/dsa/b53/b53_regs.h | 19 +++++++++---- 3 files changed, 62 insertions(+), 44 deletions(-) base-commit: ed01d2069e8b40eb283050b7119c25a67542a585 -- 2.43.0