mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Williamson <alex@shazbot.org>
To: <ankita@nvidia.com>
Cc: <jgg@ziepe.ca>, <yishaih@nvidia.com>, <skolothumtho@nvidia.com>,
	<kevin.tian@intel.com>, <aniketa@nvidia.com>, <vsethi@nvidia.com>,
	<mochs@nvidia.com>, <Yunxiang.Li@amd.com>, <yi.l.liu@intel.com>,
	<zhangdongdong@eswincomputing.com>, <avihaih@nvidia.com>,
	<bhelgaas@google.com>, <peterx@redhat.com>, <pstanner@redhat.com>,
	<apopple@nvidia.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <cjia@nvidia.com>,
	<kwankhede@nvidia.com>, <targupta@nvidia.com>, <zhiw@nvidia.com>,
	<danw@nvidia.com>, <dnigam@nvidia.com>, <kjaju@nvidia.com>
Subject: Re: [PATCH v9 0/6] vfio/nvgrace-gpu: Support huge PFNMAP and wait for GPU ready post reset
Date: Fri, 28 Nov 2025 12:44:39 -0700	[thread overview]
Message-ID: <20251128124439.3a30cf93.alex@shazbot.org> (raw)
In-Reply-To: <20251127170632.3477-1-ankita@nvidia.com>

On Thu, 27 Nov 2025 17:06:26 +0000
<ankita@nvidia.com> wrote:

> From: Ankit Agrawal <ankita@nvidia.com>
> 
> NVIDIA's Grace based system have large GPU device memory. The device
> memory is mapped as VM_PFNMAP in the VMM VMA. The nvgrace-gpu
> module could make use of the huge PFNMAP support added in mm [1].
> 
> To achieve this, nvgrace-gpu module is updated to implement huge_fault ops.
> The implementation establishes mapping according to the order request.
> Note that if the PFN or the VMA address is unaligned to the order, the
> mapping fallbacks to the PTE level.
> 
> Secondly, it is expected that the mapping not be re-established until
> the GPU is ready post reset. Presence of the mappings during that time
> could potentially leads to harmless corrected RAS events to be logged if
> the CPU attempts to do speculative reads on the GPU memory on the Grace
> systems.
> 
> It can take several seconds for the GPU to be ready. So it is desirable
> that the time overlaps as much of the VM startup as possible to reduce
> impact on the VM bootup time. The GPU readiness state is thus checked
> on the first fault/huge_fault request which amortizes the GPU readiness
> time. The GPU readiness is checked through BAR0 registers as is done
> at the device probe.
> 
> Patch 1 Refactor vfio_pci_mmap_huge_fault and export the code to map
> at the various levels.
> 
> Patch 2 implements support for huge pfnmap.
> 
> Patch 3 vfio_pci_core_mmap cleanup.
> 
> Patch 4 split the code to check the device readiness.
> 
> Patch 5 reset_done handler implementation
> 
> Patch 6 Ensures that the GPU is ready before re-establishing the mapping
> after reset.
> 
> Applied over 6.18-rc6.
> 
> Link: https://lore.kernel.org/all/20240826204353.2228736-1-peterx@redhat.com/ [1]
> 
> Changelog:
> [v9]

Applied to vfio next branch for v6.19.  Thanks,

Alex

      parent reply	other threads:[~2025-11-28 19:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-27 17:06 ankita
2025-11-27 17:06 ` [PATCH v9 1/6] vfio: refactor vfio_pci_mmap_huge_fault function ankita
2025-11-27 17:06 ` [PATCH v9 2/6] vfio/nvgrace-gpu: Add support for huge pfnmap ankita
2025-11-27 17:06 ` [PATCH v9 3/6] vfio: use vfio_pci_core_setup_barmap to map bar in mmap ankita
2025-11-27 17:06 ` [PATCH v9 4/6] vfio/nvgrace-gpu: split the code to wait for GPU ready ankita
2025-11-27 17:06 ` [PATCH v9 5/6] vfio/nvgrace-gpu: Inform devmem unmapped after reset ankita
2025-11-27 17:06 ` [PATCH v9 6/6] vfio/nvgrace-gpu: wait for the GPU mem to be ready ankita
2025-11-28 19:44 ` Alex Williamson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251128124439.3a30cf93.alex@shazbot.org \
    --to=alex@shazbot.org \
    --cc=Yunxiang.Li@amd.com \
    --cc=aniketa@nvidia.com \
    --cc=ankita@nvidia.com \
    --cc=apopple@nvidia.com \
    --cc=avihaih@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=cjia@nvidia.com \
    --cc=danw@nvidia.com \
    --cc=dnigam@nvidia.com \
    --cc=jgg@ziepe.ca \
    --cc=kevin.tian@intel.com \
    --cc=kjaju@nvidia.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwankhede@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochs@nvidia.com \
    --cc=peterx@redhat.com \
    --cc=pstanner@redhat.com \
    --cc=skolothumtho@nvidia.com \
    --cc=targupta@nvidia.com \
    --cc=vsethi@nvidia.com \
    --cc=yi.l.liu@intel.com \
    --cc=yishaih@nvidia.com \
    --cc=zhangdongdong@eswincomputing.com \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®