From: Amin GATTOUT <amin.gattout@gmail.com>
To: vkoul@kernel.org, thomasandreatta2000@gmail.com
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Amin GATTOUT <amin.gattout@gmail.com>
Subject: [PATCH] shdmac: Remove misleading TODO comment in dmae_set_chcr
Date: Fri, 28 Nov 2025 16:29:48 +0100 [thread overview]
Message-ID: <20251128152947.304976-2-amin.gattout@gmail.com> (raw)
The comment suggested that the dmae_is_busy() check in dmae_set_chcr()
is superfluous and could be removed. However, this check serves as an
important safety net to prevent configuration of a DMA channel while
it is active. Keeping it helps ensure transfer integrity and avoids
unexpected hardware behavior in edge cases.
Signed-off-by: Amin GATTOUT <amin.gattout@gmail.com>
---
drivers/dma/sh/shdmac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c
index 603e15102e45..d0e0437ad916 100644
--- a/drivers/dma/sh/shdmac.c
+++ b/drivers/dma/sh/shdmac.c
@@ -243,7 +243,6 @@ static void dmae_init(struct sh_dmae_chan *sh_chan)
static int dmae_set_chcr(struct sh_dmae_chan *sh_chan, u32 val)
{
- /* If DMA is active, cannot set CHCR. TODO: remove this superfluous check */
if (dmae_is_busy(sh_chan))
return -EBUSY;
--
2.43.0
next reply other threads:[~2025-11-28 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 15:29 Amin GATTOUT [this message]
2025-12-02 10:12 ` Eugen Hristev
2025-12-02 11:54 ` Amin
2025-12-02 12:01 ` Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128152947.304976-2-amin.gattout@gmail.com \
--to=amin.gattout@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomasandreatta2000@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®