mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hithashree Bojanala <bojanalahithashri@gmail.com>
Cc: linux-kernel@vger.kernel.org, marcelo.leitner@gmail.com,
	davem@davemloft.net, edumazet@google.com,
	Hithashree Bojanala <bojanalahithashri@gmail.com>,
	syzbot+e94b93511bda261f4c43@syzkaller.appspotmail.com
Subject: [PATCH] Fix refcount bug in time scheduled paths
Date: Fri, 28 Nov 2025 11:40:23 -0500	[thread overview]
Message-ID: <20251128164025.224958-1-bojanalahithashri@gmail.com> (raw)

The SCTP heartbeat timer callback can cause a refcount underflow when
rescheduling the timer. The issue occurs when mod_timer() is called
inside sctp_generate_heartbeat_event() to reschedule an already-pending
timer.

The current approach only takes a reference if mod_timer() returns 0
(timer was not pending). However, when rescheduling inside a timer
callback, we're consuming the reference that was held for the current
timer firing. If we reschedule without taking a new reference, the
subsequent timer callback will do sctp_transport_put() without a
corresponding hold, leading to refcount underflow.

The fix is to always take a reference when rescheduling inside a timer
callback, since the callback will always drop a reference at the end.

Reported-by: syzbot+e94b93511bda261f4c43@syzkaller.appspotmail.com
Fixes: https://syzkaller.appspot.com/bug?extid=e94b93511bda261f4c43
Signed-off-by: Hithashree Bojanala <bojanalahithashri@gmail.com>
---
 net/sctp/sm_sideeffect.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
index 424f10a6fdba..733617781ed9 100644
--- a/net/sctp/sm_sideeffect.c
+++ b/net/sctp/sm_sideeffect.c
@@ -377,9 +377,10 @@ void sctp_generate_heartbeat_event(struct timer_list *t)
 	if (sock_owned_by_user(sk)) {
 		pr_debug("%s: sock is busy\n", __func__);
 
-		/* Try again later.  */
-		if (!mod_timer(&transport->hb_timer, jiffies + (HZ/20)))
-			sctp_transport_hold(transport);
+		/* Always hold a reference when rescheduling inside timer callback
+		* because this callback will put the reference at the end */
+		sctp_transport_hold(transport);
+		mod_timer(&transport->hb_timer, jiffies + (HZ/20));
 		goto out_unlock;
 	}
 
@@ -388,8 +389,10 @@ void sctp_generate_heartbeat_event(struct timer_list *t)
 	timeout = sctp_transport_timeout(transport);
 	if (elapsed < timeout) {
 		elapsed = timeout - elapsed;
-		if (!mod_timer(&transport->hb_timer, jiffies + elapsed))
-			sctp_transport_hold(transport);
+		/* Always hold a reference when rescheduling inside timer callback
+		* because this callback will put the reference at the end*/
+		sctp_transport_hold(transport);
+		mod_timer(&transport->hb_timer, jiffies + elapsed);
 		goto out_unlock;
 	}
 
-- 
2.47.0


             reply	other threads:[~2025-11-28 16:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28 16:40 Hithashree Bojanala [this message]
2025-11-28 17:05 ` Eric Dumazet
2025-11-28 17:38   ` Marcelo Ricardo Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251128164025.224958-1-bojanalahithashri@gmail.com \
    --to=bojanalahithashri@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=syzbot+e94b93511bda261f4c43@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®