From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BA402949E0 for ; Fri, 28 Nov 2025 16:48:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764348499; cv=none; b=eHbR3wV4O3SStoAKb8vjguQ5dEQjWSQ980pNeG8XAsBAXa9ihG3VA/b2QJhxe2kO9O4veYd033Glyv/5+OlUcYawfsjhMq6TNxw9IWYoaKlOanOPps363GxxtZj2zdmqv732VamJDDT+asVnqqNuLiXG4VdRS7u24lEQawSr/rs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764348499; c=relaxed/simple; bh=pK8K7Pa7QZb6H438w2S79hy/rHjho1lVUg5bIpSNGXc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OV1DNX+81ZQt9FYXqFs/0W0FJTmfvoXH8bRucDZbhfQrdprPIopPv7GSBQSifdyGIsIdZCiqlfcw7kxOOJi96ZfMnugn/wOf3/1q6brCQlvDjyJQod/hePJuqQ95n/TraHNO2Dvc+Y3jR+ePtO8eT+TCL6B8nFvT34gAYsmh2TM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=pBNitPM0; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="pBNitPM0" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-8b21fc25ae1so192236185a.1 for ; Fri, 28 Nov 2025 08:48:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1764348497; x=1764953297; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BAfMjKf1n0EM57yS6vP5/PFm4GU7RlouzaAGnKGJjA4=; b=pBNitPM0X2PjnuKZVt4tx1gqnUt/h9i6ARAJsVKTuXonCONaceOtMdU4vX5FYpFOr8 qu5AwmsgRrN4PjUFOlwUy2UJvmGn5Bey1bXf/HYbCpo6RnrHuC1uKGgNroOtrCIZFHfC ispTUPtYTupJKB9Tj8jEHdRCRwOBL0Wrh0iZ30/8/hNstyIH7M2ozWSgi0dz/mgePJfW kK1j7iN/02fUpW6fjE9T3kBZu7xVSHlWFHAoIXTjYBBeSgMvoDG6Eb2rPR0TMISiytLa pSuzJyqfGmjYIuZly/gtBXhGlacI0Zdn1Q9S4Q5wFxgrSQG8qkC6HgpQ5V0pZFWu1oiL lO8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764348497; x=1764953297; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BAfMjKf1n0EM57yS6vP5/PFm4GU7RlouzaAGnKGJjA4=; b=wegxBTKv6hn7yrWOIo6645nEwfM/SfTpTPVxTEUiqoaN4OqozRybltpVKyFUqivsG/ ZeLGNeHJ6IloVQfb60IGne8OB9+P53KcWIbO+JFXdk9jVB2XGh9V56yZFdoZMjY1JvKl uwa7pQCCSmcBPybert+DT9L+o1jagL8yjSZXHzr1K+8TSxZ2M6jr0KzZgQyDuxbLkcsJ OYaMVZDVlwQfZCe+bFjMtsnJRroDYYN4EetyxcFaOIz5XlmV5L5XNZx4MxpHoY1K5uFu DJTIIBdWoTi/dx+XuX3XUTyyXNIwFIFezGabsMtWKybPadQLLqbFChJBRozH7jx85Y8L 9IUw== X-Forwarded-Encrypted: i=1; AJvYcCUhbsyV171VIYathn2SqoeoDgSdglvg3YXHB3W/C0Zj4sEyEm0/dBfkISMIlJ2E3OAqebyZ1XF68BL+obs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/XbrkkQJv2bmYxeBuduheAADjVUjmPP5/bO/DQr7UcpDhgknC zN1JG/9gVhydrjKXUFz/rbRkTVxI4b53erle3GCXcWsE5YMPgY/vAvRiHWzYy2bPuto= X-Gm-Gg: ASbGncu7d/kXdo6Nf9XU0ebK1zfdSHDZJ08hMVB54/F+UTJGhaNWhK7RoHr4tkaaOzc Pgi+fAzU5vObnEi1mUrDMFocKxBj7qflJ+RAS619V1a6IJkR8peGyEf3xlcjpuT4zTxTSPGhzMe Fs8aSeIEYohXD8KmFZPuoTz3n1NckEgOp79VLsb1/z56yb/5pnjPPidJIIY/imIRUBExOeH0rjw VqO6ht2wYu7odxkxNXP75mELb5gMKn+rYuA6w0uo6PVCAqEaIuO6gswvHpMuKa3L/8slJbewhxs s9ygzSajhW4LlyTGo99wg+Bopa7uojooPTI6q7zH3U7tJPraxcVo7uvacpwpvy3YvklFltGw2hw ALDVs3VAxRbEZRsSa6sbcaAmOgL9gUsRX0FNxfvap/5scjQU5zcy0B1WbZsKwSyYngyoxbDwdE3 cCJpe/abZbNC+zp9WjrqQ6B4Ac6TVzlfTe1qPE0HbeT+5SDNyqaiwg/vBd X-Google-Smtp-Source: AGHT+IHQqaabicTwzKD3aV8B7vGpE1WoUx4p1TCHTluWfNaKtOTmIupEbWyDAmYJQk3capA2QEx8FQ== X-Received: by 2002:a05:620a:4496:b0:8b2:76c6:a7ae with SMTP id af79cd13be357-8b4ebdb0ab9mr2073856685a.50.1764348497176; Fri, 28 Nov 2025 08:48:17 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b5299a5f1dsm335208785a.13.2025.11.28.08.48.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 08:48:16 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vP1do-00000003PwW-0xng; Fri, 28 Nov 2025 12:48:16 -0400 Date: Fri, 28 Nov 2025 12:48:16 -0400 From: Jason Gunthorpe To: Mostafa Saleh Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, joro@8bytes.org, jean-philippe@linaro.org, praan@google.com, danielmentz@google.com, mark.rutland@arm.com, qperret@google.com, tabba@google.com Subject: Re: [PATCH v5 07/27] iommu/arm-smmu-v3: Move IDR parsing to common functions Message-ID: <20251128164816.GC812105@ziepe.ca> References: <20251117184815.1027271-1-smostafa@google.com> <20251117184815.1027271-8-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251117184815.1027271-8-smostafa@google.com> On Mon, Nov 17, 2025 at 06:47:54PM +0000, Mostafa Saleh wrote: > Move parsing of IDRs to functions so that it can be re-used > from the hypervisor. > > Signed-off-by: Mostafa Saleh > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 112 +++----------------- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 111 +++++++++++++++++++ > 2 files changed, 126 insertions(+), 97 deletions(-) I don't see that this slow path stuff needs to be inlined? +10 to my prior remark to not dump all the huge inlines in the main header. Jason