mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vincent Mailhol <mailhol@kernel.org>
To: netdev@vger.kernel.org,
	Stephen Hemminger <stephen@networkplumber.org>,
	 Marc Kleine-Budde <mkl@pengutronix.de>,
	 Oliver Hartkopp <socketcan@hartkopp.net>,
	David Ahern <dsahern@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-can@vger.kernel.org,
	 Vincent Mailhol <mailhol@kernel.org>
Subject: [PATCH 2/7] iplink_can: print_usage: change unit for minimum time quanta to mtq
Date: Sat, 29 Nov 2025 16:29:07 +0100	[thread overview]
Message-ID: <20251129-canxl-netlink-v1-2-96f2c0c54011@kernel.org> (raw)
In-Reply-To: <20251129-canxl-netlink-v1-0-96f2c0c54011@kernel.org>

In the vast majority of the available CAN datasheets, the minimum time
quanta is abbreviated as "mtq". Note that the ISO standard uses "tqmin"
(with the "min" part as a subscript).

One fact is that no one seems to be using "tc". I was actually the one who
initially proposed to use "tc", but I can not recall anymore the reasoning
behind that.

Change the minimum time quanta unit from "tc" to "mtq" to follow what the
majority of the industry does.

Fixes: 0c263d7c36ff ("iplink_can: add new CAN FD bittiming parameters: Transmitter Delay Compensation (TDC)")
Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
---
 ip/iplink_can.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ip/iplink_can.c b/ip/iplink_can.c
index f3640fe0..ee27659c 100644
--- a/ip/iplink_can.c
+++ b/ip/iplink_can.c
@@ -56,9 +56,9 @@ static void print_usage(FILE *f)
 		"\t	PHASE-SEG1	:= { NUMBER in tq }\n"
 		"\t	PHASE-SEG2	:= { NUMBER in tq }\n"
 		"\t	SJW		:= { NUMBER in tq }\n"
-		"\t	TDCV		:= { NUMBER in tc }\n"
-		"\t	TDCO		:= { NUMBER in tc }\n"
-		"\t	TDCF		:= { NUMBER in tc }\n"
+		"\t	TDCV		:= { NUMBER in mtq }\n"
+		"\t	TDCO		:= { NUMBER in mtq }\n"
+		"\t	TDCF		:= { NUMBER in mtq }\n"
 		"\t	RESTART-MS	:= { 0 | NUMBER in ms }\n"
 		);
 }

-- 
2.51.2


  parent reply	other threads:[~2025-11-29 15:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-29 15:29 [PATCH 0/7] iplink_can: add CAN XL support Vincent Mailhol
2025-11-29 15:29 ` [PATCH 1/7] iplink_can: print_usage: fix the text indentation Vincent Mailhol
2025-11-29 15:29 ` Vincent Mailhol [this message]
2025-11-29 15:29 ` [PATCH 3/7] iplink_can: print_usage: describe the CAN bittiming units Vincent Mailhol
2025-11-29 15:29 ` [PATCH 4/7] iplink_can: add the "restricted" option Vincent Mailhol
2025-11-29 17:03   ` Stephen Hemminger
2025-11-29 15:29 ` [PATCH 5/7] iplink_can: add initial CAN XL support Vincent Mailhol
2025-11-29 17:04   ` Stephen Hemminger
2025-11-29 23:13     ` Vincent Mailhol
2025-11-29 15:29 ` [PATCH 6/7] iplink_can: add CAN XL's "tms" option Vincent Mailhol
2025-11-29 17:21   ` Oliver Hartkopp
2025-11-29 23:16     ` Vincent Mailhol
2025-11-29 15:29 ` [PATCH 7/7] iplink_can: add CAN XL's PWM interface Vincent Mailhol
2025-11-29 17:26   ` Oliver Hartkopp
2025-11-29 15:38 ` [PATCH 0/7] iplink_can: add CAN XL support Vincent Mailhol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251129-canxl-netlink-v1-2-96f2c0c54011@kernel.org \
    --to=mailhol@kernel.org \
    --cc=dsahern@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®