From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 355E8A92E for ; Sat, 29 Nov 2025 01:32:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764379936; cv=none; b=U4gd08pzZgmo6PvT47VnjyVSNCiEW7Awj4XuCPbfxB3oLFJgSuppqj6Mydd0RVCJCCnJNJHpzW8ISUVOK44Nh+/6+3wreP9mbcs0uyqIMaqGxO7tsVu7G93sF2+7aQph8ZDa6alVS/AibBO1YHhWtNyjQ3oWPc3U1p2KiMZKDIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764379936; c=relaxed/simple; bh=vdmaUHccWmDVYP5bDCaCaO3XBcciiahtVTW92w0BONc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WkH6R2tvzS0HL76kneIfCedieA+CrMw4BKXvKqMH+MKS9khX3H+BlefOIMspbD5BCYI0Xtc7xx1OpLLGDqGp+Hj5hCQhgkdSATEvLE0oBX7AgtAaccZAgsqIeWyw86bzjy9XMa0rKs8t11fVrsoGEGonyK8SANM7nfmxPMLI+GU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WenNRmBT; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WenNRmBT" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-7c730af8d69so1326364a34.1 for ; Fri, 28 Nov 2025 17:32:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764379933; x=1764984733; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=E7E/BBPbYBPXOHpVXq81S10jr7hBzzUHbxEs5MGnVlk=; b=WenNRmBTYBClOPDBvdjMCVE68wRzVLylbYw2ZtKt56q9YGaeg4G8kl4/XyuItRHgSd oH0tKVlwjPDe7bpaDq8djmp5N7A0KuLAH3DMMDV2FaR0vcOTMOXZfe6jeFsh4LWKhfn3 f8lT8OP2kSjbNlreIKk624myUaP1oxUEn8unnaUhyGCPxsVvEPdA7IoAFDEe55CqU9s1 rFRHEr+qnztIejvK+ssP2GwVLAFS0xebfNM2oAXrTpFU/sXDVVV0Kj89VxcIFDAi7ETs /fgpkSx3V/CPvN0Dt6SPuE5H4ttNzp0rs0J4nlm+HLIa+kyuDq/B3OApt9nXa9zpjeio lJ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764379933; x=1764984733; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E7E/BBPbYBPXOHpVXq81S10jr7hBzzUHbxEs5MGnVlk=; b=B36f+DmmxEuV0I22SaqZhicLtul0QJueF61BLkpvmu7I3g9RrsjfTdHprgGC7OqsRw pQYsKfdrNTf45i+ElgWh+ZLjtsyP3aRqnLerITNhkx6ZxtJ9CT/itOu7sSW8OB7MnGas BN8thUDeygkwAY7406J8Fcht89NpYw/Kvdbvmv0cz9cRviwuK04j0hb9LU5HrEYEcl2A DNoH3+sV8K8bL/4WjpMyQtXzT/4Pj/8Apz1e1tQy0GNCY/A+4c03fVzgrtwmiS5OJnCP /SjMgxBzvjEmOu1OqT9GfrLPsJAaMWiMDrYNmbhpIyw2eHOtqQ957Fdyb3nefShnwIAY hQPA== X-Forwarded-Encrypted: i=1; AJvYcCUf/m5lgjjm2WJHZYnqWIxaGXK3heK8TEjAjwkbhaMVspsaJPE9Rk1EwDlN6GXj8xB+na6Dtwot+eRw9HQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzUT/ME/r2ydPFaRuATQR44ZthO8Pg+/eyWaV2hlknYO9X1l222 5dQNNrl3tEMtT3DVmszowVqDH/8NNiCAkM9Q2k29ACzkf23DF5690cTw X-Gm-Gg: ASbGncvox7xCKAxNKQUSYpl5P0jcMtBDeDvWK5bkaX9wR9ZdgVaANfZ0rg1gkH3yWbu 3JJW+exW/qyfyWW27r9FEIY/4yuj2Cz4/UKLoq1LwLk7IGeuQwAcHlWuDlp+qs1ENmFBpcCt0JS dWKPVcJfmgk2pzwbdlplbw2iVJOfjwAgWwPfOdFliP1L/XIyeo+FUz3CsXNE718LErhNVFR+ZmA pIeAM+HQ0n9HnSubr87UkRHS7+o46J2+scKEvdJiGU5T2MRjIn9Z2M+jdtlc0cPedLwwCfDv5fZ 2FNoeB0t3noTN1KtVX14hG+2RL1cJ9b2uHf24PE9EzE431ilCcHCDN2R1uXuo8ot6hKPERn7tBq /8zCyAt184jcTir4BXHt9wgupcRfrq/3AiwCCsMKAcsGX6kvqF8Md40c5sp3uKmB8aqtkRMsAEd xxxxekbgLp/ntDq+E/6y5H1fK1sCx/XBPgQTzt1n5bm1Ljb9KNfcFOKTfKnGN16RePO9svjuDHU R/EA1hm9LU8qkGj4VgX/fxtPrnP X-Google-Smtp-Source: AGHT+IGmG/wIFDhhCxEyeeVjx/pa04jiRhUZeAmYhFY0IfdPX2GFReTPcNInxsmHWH9sjQAUzkBQcg== X-Received: by 2002:a05:6830:2690:b0:7c6:ca1f:1779 with SMTP id 46e09a7af769-7c7c4414a0fmr7001780a34.30.1764379933355; Fri, 28 Nov 2025 17:32:13 -0800 (PST) Received: from nukework.lan (c-98-57-15-22.hsd1.tx.comcast.net. [98.57.15.22]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7c90fcedce6sm2188742a34.16.2025.11.28.17.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 17:32:11 -0800 (PST) From: Alexandru Gagniuc To: andersson@kernel.org, mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org Cc: p.zabel@pengutronix.de, linux-kernel@vger.kernel.org, Alexandru Gagniuc Subject: [PATCH 1/2] remoteproc: qcom_q6v5_wcss: fix parsing of qcom,halt-regs Date: Fri, 28 Nov 2025 19:32:05 -0600 Message-ID: <20251129013207.3981517-1-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.45.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The "qcom,halt-regs" consists of a phandle reference followed by the three offsets within syscon for halt registers. Thus, we need to request 4 integers from of_property_read_variable_u32_array(), with the halt_reg ofsets at indexes 1, 2, and 3. Offset 0 is the phandle. With MAX_HALT_REG at 3, of_property_read_variable_u32_array() returns -EOVERFLOW, causing .probe() to fail. Increase MAX_HALT_REG to 4, and update the indexes accordingly. Signed-off-by: Alexandru Gagniuc --- drivers/remoteproc/qcom_q6v5_wcss.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c index 07c88623f5978..23ec87827d4f8 100644 --- a/drivers/remoteproc/qcom_q6v5_wcss.c +++ b/drivers/remoteproc/qcom_q6v5_wcss.c @@ -85,7 +85,7 @@ #define TCSR_WCSS_CLK_MASK 0x1F #define TCSR_WCSS_CLK_ENABLE 0x14 -#define MAX_HALT_REG 3 +#define MAX_HALT_REG 4 enum { WCSS_IPQ8074, WCSS_QCS404, @@ -864,9 +864,9 @@ static int q6v5_wcss_init_mmio(struct q6v5_wcss *wcss, return -EINVAL; } - wcss->halt_q6 = halt_reg[0]; - wcss->halt_wcss = halt_reg[1]; - wcss->halt_nc = halt_reg[2]; + wcss->halt_q6 = halt_reg[1]; + wcss->halt_wcss = halt_reg[2]; + wcss->halt_nc = halt_reg[3]; return 0; } -- 2.45.1