From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00EC922A4EE for ; Sat, 29 Nov 2025 04:38:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764391107; cv=none; b=QDAHWtoQc/ECmoCo0uN4Qf1h0y7ksbx7FpSDRbOOfLyMi1jS8jxKEAUm1r4sH5KiE8b4MPt0o/hha1Dhz7t+IQ83OqxfRrxkerhN/eesw6ilhK1IAoTLZUmil2RmuvyxOsrq7kOmM1Yn9ntK41nHu5FmBanupmsLR5wxNk6JnAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764391107; c=relaxed/simple; bh=MY6OepM4iCbQKboU2CzDmLhc+cf4XBwZQTl9an9blRg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=X28B3ZguxJ9tWCj30W2nkwm9pF2SHqAlR/Y/gPy82FwWUHzVX1obAdzt9myTEQOpHSJYEFd4TaQO0/umVQra7PRs3hT+AW+KNlLyyV1T9FyhlAUclglkSOrVOSLi8eg3WD5HKrzlYnKdT/5UKs1/SJpYhhtQB6mm2R7wcM0mQ6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KaT9f2AV; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KaT9f2AV" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-297dc3e299bso24159975ad.1 for ; Fri, 28 Nov 2025 20:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764391105; x=1764995905; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LoUjNl1uE2KTMWSYxjynIphVvFokAcjMOIAnwbmph0g=; b=KaT9f2AVWPNLrm0ULxEbpsToNTOx4XXcs6RFfLUxV/lSuTt8CcBBbl9Pyn0d5N2EVv RBUO9OFGcEb4j3VjCyxY6w1BLQBmdL4f1Zexbj9f6gKWtOagVKXj3cRBAJGYhgXwRqyD 0SB9xMgOYx5Z4RFr9m5i46zFx5C3WNl4LnkIfwb2W+fKW0v5Llk/xnIqRPHO3libEHZC WDBKTjjNosMOJSvJVlB0O+4XMRW16/ErgIZXXJGqnS4OOVrVdFx3m4X4CN3Wi+j3Cqe3 UZOOMYpBa1DE5qjdxsDQxmmT0AQvUomPIRatyq5F/RxFaERQe9Gl9JPTU37l3yDqWtup I4YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764391105; x=1764995905; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LoUjNl1uE2KTMWSYxjynIphVvFokAcjMOIAnwbmph0g=; b=ZVG21B4YBIX8Y6SJmKtxDWHhQ5yGdBTFI6me5rXE6vq1zvIsghcmPYmuIYJ6AuvxHf dLusLn03rdFAM97TU6Sn7aoKjwNryh18f6egS3iac6OhXjpt4ZJ3ZruL6Y6WSH0kdB/Z MZLQ0iVnr7b/HPsZzzJbzpbHBj3YZGoYFR7Jr5fOGBja4IwC3ViZmFDKT38g9KP1GTYH xdxBRQqYuVO2RSvdx+fRfXurRGgaAGoU8kv4pXyLY+OSws4Va9MM9KEKey95gT53WQGy fZ7hSTiLokAd7TwTFcPVf5ISsonkVujmJyCbgYYZ0YBW8yAJljRMmT3foxte9pVTM29V SO1g== X-Forwarded-Encrypted: i=1; AJvYcCUm+L9IB0oItGG70P2TIbfDiICQojiO+sxcoLX0w7DFoHk9d87h7e2nbiE1dUSY++U9p20m1yFvBrSklC8=@vger.kernel.org X-Gm-Message-State: AOJu0YzGAsd8FL6jrOlv1SCi5Krio1thkdw60jMJ5ZCp0s3+djz9fmbX cUguxfM9nRsqBNlBN7BZJeGAKDJlsxL3Q0JxG/k3nu12FrpjCaHpLSYm X-Gm-Gg: ASbGncu0GCWPi8m3T7jhsCQjs5fsfG46C0PX7AFzMqlGmLabpwoomrMZ6bvVqgmgd/i y+hBtxzLj8SyVXW2Mm3ZTFaQlflHFEbEtjD+gWzINoDZPTG3gdCDlFThVzth7gc+HdZa6kAg6mg OMoaKkGasdZshiah41ypFzyBQhy0Suh+YruO18Ij9WHwLZjIvB+VzP22Avi0mnNyZNXHZ0h1uNC DOVZql8/FKOVQ4pAwr9d9D9TBW1Pd7jEIqjGzbWz1sFc7Y3vFDDXZXlcgMYIU5OH2gcyX730TLD Ny+XBC3/xKtEVG3LuGk/WanMMOOLqKlEDokaQ98aw/Da6AByQ86mXgpjHddp9qH2uaR4tVbS9vU pr6U27DLYWqL30OFgOz2ybceKLCtNQeX97aPJ9XnGNfVeW3uaXnYb4PL9UpwKEv5BSsZCh7cKlD fjMsnKGHFY3XL/Zn2ZTSMUssErE7+4C5hgbrp76uL1 X-Google-Smtp-Source: AGHT+IE3d227D6O/a6E8EeYXs1AA4qchJAYZ2y3RerwefcyJ6amSAoYNHYb6emQiTrh6d6t1kWOLlA== X-Received: by 2002:a17:903:1105:b0:23f:fa79:15d0 with SMTP id d9443c01a7336-29bab1a156fmr189382745ad.46.1764391104946; Fri, 28 Nov 2025 20:38:24 -0800 (PST) Received: from fedora ([103.120.31.122]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bceb5c6c9sm60774995ad.97.2025.11.28.20.38.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 20:38:24 -0800 (PST) From: Ankit Khushwaha To: Matthieu Baerts , Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: Shuah Khan , netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Ankit Khushwaha Subject: [PATCH net-next v2] selftests: mptcp: Mark xerror __noreturn Date: Sat, 29 Nov 2025 10:08:08 +0530 Message-ID: <20251129043808.16714-1-ankitkhushwaha.linux@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Compiler reports potential uses of uninitialized variables in mptcp_connect.c when xerror() is called from failure paths. mptcp_connect.c:1262:11: warning: variable 'raw_addr' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] xerror() terminates execution by calling exit(), but it is not visible to the compiler & assumes control flow may continue past the call. Annotate xerror() with __noreturn so the compiler can correctly reason about control flow and avoid false-positive uninitialized variable warnings. Signed-off-by: Ankit Khushwaha --- changelog: v2: - annotate 'xerror()' with __noreturn - remove defining 'raw_addr' to NULL v1: https://lore.kernel.org/all/20251126163046.58615-1-ankitkhushwaha.linux@gmail.com/ --- tools/testing/selftests/net/mptcp/Makefile | 4 ++++ tools/testing/selftests/net/mptcp/mptcp_connect.c | 3 ++- tools/testing/selftests/net/mptcp/mptcp_inq.c | 3 ++- tools/testing/selftests/net/mptcp/mptcp_sockopt.c | 3 ++- 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/Makefile b/tools/testing/selftests/net/mptcp/Makefile index 15d144a25d82..4c94c01b893a 100644 --- a/tools/testing/selftests/net/mptcp/Makefile +++ b/tools/testing/selftests/net/mptcp/Makefile @@ -35,3 +35,7 @@ TEST_INCLUDES := ../lib.sh $(wildcard ../lib/sh/*.sh) EXTRA_CLEAN := *.pcap include ../../lib.mk + +$(OUTPUT)/mptcp_connect: CFLAGS += -I$(top_srcdir)/tools/include +$(OUTPUT)/mptcp_sockopt: CFLAGS += -I$(top_srcdir)/tools/include +$(OUTPUT)/mptcp_inq: CFLAGS += -I$(top_srcdir)/tools/include diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c b/tools/testing/selftests/net/mptcp/mptcp_connect.c index 404a77bf366a..10f6f99cfd4e 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.c +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.c @@ -33,6 +33,7 @@ #include #include #include +#include extern int optind; @@ -140,7 +141,7 @@ static void die_usage(void) exit(1); } -static void xerror(const char *fmt, ...) +static void __noreturn xerror(const char *fmt, ...) { va_list ap; diff --git a/tools/testing/selftests/net/mptcp/mptcp_inq.c b/tools/testing/selftests/net/mptcp/mptcp_inq.c index 8e8f6441ad8b..d4a729814662 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_inq.c +++ b/tools/testing/selftests/net/mptcp/mptcp_inq.c @@ -28,6 +28,7 @@ #include #include +#include #ifndef IPPROTO_MPTCP #define IPPROTO_MPTCP 262 @@ -52,7 +53,7 @@ static void die_usage(int r) exit(r); } -static void xerror(const char *fmt, ...) +static void __noreturn xerror(const char *fmt, ...) { va_list ap; diff --git a/tools/testing/selftests/net/mptcp/mptcp_sockopt.c b/tools/testing/selftests/net/mptcp/mptcp_sockopt.c index 286164f7246e..15cea5e919b5 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_sockopt.c +++ b/tools/testing/selftests/net/mptcp/mptcp_sockopt.c @@ -25,6 +25,7 @@ #include #include +#include static int pf = AF_INET; @@ -139,7 +140,7 @@ static void die_usage(int r) exit(r); } -static void xerror(const char *fmt, ...) +static void __noreturn xerror(const char *fmt, ...) { va_list ap; -- 2.52.0