From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 903582236E8 for ; Sun, 30 Nov 2025 08:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764490945; cv=none; b=Yf88n7TCzN5tk+O53D8+6ALzbNIUwg0dBlHHdD23fBXG7emI3BciPwgFs/KFTz8K+F5hEXEddvgJifjNVQBcEyavIHPBTnR26Cr88oJW3C+24dHd4QeYnu9bxHtI1iRInOtfwI5HGxu1wZvVS5T4N0ut3EfANGxnX9DLGWTGBMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764490945; c=relaxed/simple; bh=FMjxTGWZnc7ZEhZJMTa/55xtVT734ANCN6WX3PTPVUI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P9LL3Enf0U4xIa+u4PEC0W7GdBQxlJbjJSGK7QbDWrahlHfFIdVhbhrUuW7xem/MQD9NKuQuFLVtYZSUhSAT3CewHYE8AYEyA+DJYEv07f2iN+HtR63q/Gkqs5Berx5H7dqnoZYRdRXGPr1VSixJkHxc/1fmCHi79L81yDm+cD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a1r8MlOD; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a1r8MlOD" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4779c9109ceso2497445e9.1 for ; Sun, 30 Nov 2025 00:22:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764490942; x=1765095742; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tMyv7xHpzBEGqAA6Ujonxbq3JvKho8WXoic6wC5QnCg=; b=a1r8MlODyRMePL6XzSaVDGyyJg/GfZUHfz0FLEjHdzwuE4lmldCYRgYG65/jaTTW4H aUEZsgolYvVS4aimOjiUM8VmT7UtblwgM065lUsGa0RmkTr3Ui7QRLY0qmdmt2kvqwXN 7bkDru20lNwEwJJgj7ez3kmjlyNYIp7OWFP0vBrxcQlpqD/MH6Kjc6NBWp3XsZfdJd1v Q6F+xY0aYYB/0qwLzp5wuzlmoRZdZmC51bYR3NE+agY6FW6wrJdUd0q8tpkt7gmUkx26 52Oh+sYgDtLoXXgxqoIete4omxsgIrClYbz/UnylvCMbmwZvqG0As9VvGhpjDFrnosks TmMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764490942; x=1765095742; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tMyv7xHpzBEGqAA6Ujonxbq3JvKho8WXoic6wC5QnCg=; b=eX5K0XFUZqK4F/aqmFpVl0+tVESi3aVIzWk5BHOms3+DkUhnoVIiwJ7quFVjzEctoy pFpuAd++Kuip+r8wS04fm+nxIznDxnp3g+XU5Q0YDtG6gO93OtRj+drbbctZErDEGxf+ fBa0LcaDiyFkRnbHxwLWuoJm799cgu0kADRFykFXDLERuuUhrWGrqsGBViq/mMXikeD+ N5YHcYqamJYZvvdb9+e132ekqRqYNJd1cm2D4Ugpd9toMnETcBsQ1Bccl1f2QSowWpbq x6PGjrRSnrqoSMkWZbSU6AgkWZ/5A6/YuJsB1K3JcB1W0zx75g+oGNNW6I5zntFz5dN8 JOaA== X-Forwarded-Encrypted: i=1; AJvYcCUJNR1eCKakjDPxO+cWm3HWe6B5llsR6ZY5wd1PRCOVSlRUtBTZ1AHWl3mxJ4QFjKABKkOhig7CFehKhcc=@vger.kernel.org X-Gm-Message-State: AOJu0YzLeHI65ZsLPndNJLwix9lGkwhh2HZEEbBD0g0fE35OIH+hv16+ QjAw0es/BRMvz6BWWYUZMeV4HDw5ja4Z5r5XIHxQG9eQur8zcc6kxcYX X-Gm-Gg: ASbGncso8OQh5jwt5mujmQfXNaEgffjOyNdO7B67eHHd22RU+s/ZCuXJX0qdMukAnQw 5MB7Ieahdkep9rdTx2ZvgCoJzyZzIQPZiye+9LIxpzQWcb3qYoJSK7qy2jkih1a3FauKtVNSm5k 4JK/ExqXY+8kyht72s2PuFp1j6rjgYHOkrgtjX32juBLQg0RZOtRySaIFarY8gVu0fCfeHMRqHR yQCCjzyztmWl4IWswbk27ss1DH0xaeAJxa+fTQa1XFN5VVFyQnnYAYjJKmOuH61tBpDkD6t/JD2 wkXSYJN9IahsXri5jC4iD9sNlmmsfu/bA4ZxHYuvNXUZra4E5FADJNd8fmwlLIOrp012vmMBldO Yu0uelUyzGkvi7ZiQQSZ4CIbGY5X5nHfHP63n4CnLdOcNx8gOazi58/VbEq70D2Vj/yFa9BKLoW Eq+g== X-Google-Smtp-Source: AGHT+IFxf5DCmAQb4WegUpiiTFHp05rmbMw9OobLeUqiCuq6pkZ68STqGne2876uNBNRHt3VzIgFBA== X-Received: by 2002:a05:600c:4443:b0:471:1387:377e with SMTP id 5b1f17b1804b1-477c01ddc08mr202058375e9.6.1764490941614; Sun, 30 Nov 2025 00:22:21 -0800 (PST) Received: from skbuf ([2a02:2f04:d106:d600:36d7:677f:b37:8ba9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4791115caa7sm172799055e9.6.2025.11.30.00.22.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 00:22:20 -0800 (PST) Date: Sun, 30 Nov 2025 10:22:18 +0200 From: Vladimir Oltean To: Chen Minqiang Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , "Chester A. Unal" , Daniel Golle , DENG Qingfang , Sean Wang , Andrew Lunn , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 2/2] net: dsa: mt7530: Use GPIO polarity to generate correct reset sequence Message-ID: <20251130082218.mvxlk3p2pxdny2ij@skbuf> References: <20251129234603.2544-1-ptpt52@gmail.com> <20251129234603.2544-2-ptpt52@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251129234603.2544-2-ptpt52@gmail.com> On Sun, Nov 30, 2025 at 07:46:03AM +0800, Chen Minqiang wrote: > This change makes the driver fully backward-compatible with older, > incorrect DTS files that marked the reset line as GPIO_ACTIVE_HIGH The driver _is_ already backward-compatible with incorrect device trees. This patch makes it compatible with "correct" device trees. We need care taken in one more area: when you make updates to the device tree, *old* versions of the kernel are not compatible with the latest device tree, which is not OK. So ideally: - patch 2/2 should be considered a bug fix and backported to stable kernels - you wait for some time to pass between when patch 2/2 is merged, and when patch 1/2 is merged, so that users who get an updated device tree have gotten the kernel compatibility patch through stable channels Then you need to consider that you break "git bisect" if you keep the device tree the same (i.e. the latest) and just change kernels. That is a trade-off that needs to be well justified (cost/benefit).