From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F431221DAD for ; Mon, 1 Dec 2025 19:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764615727; cv=none; b=ZpylT4nvrfCRbScu3WpxHaTKeqjn84dBocVR2bPlNrhmScDU8I0pGeaU363ni5Icd/hIl74IoTfS2gf9KCAU48lG3MEPfr6si/VmZPoL7ya97u53FgeLMpbAl/fdTTb6Xm0MWGhzlT+wc5Dfe2zQbZn8U9uk82nDAcMAitBOeWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764615727; c=relaxed/simple; bh=O7gupK2cqOOeS34AR3ilQOHr7lOlZO9dG6ni/0pPknw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s7BQzzfxksRJwCbZqXpD89stewdTXBF+byaai9hSUTne5RnCqF2bIIp+W2o2OpBzUZc1W1/bJ9YlGCb/iinGtlr8Stzs7SG5dOR06gck6L3eAVP+5TvOie2V0KYu1/fV2kGRJOAJTSGbLWepxd5FBPfSg0TGoaTWUnP+J3eHT2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=fail (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=TWwTLXvs reason="signature verification failed"; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="TWwTLXvs" Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id B81C440E0253; Mon, 1 Dec 2025 19:02:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=fail (4096-bit key) reason="fail (body has been altered)" header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yco2lXAf9vn2; Mon, 1 Dec 2025 19:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1764615715; bh=I8/EHQydKc+/N3YX+dLMTAOBmEPUrE4qlNDYMiFE1i4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TWwTLXvsddCwk8n/Gl+w0XQvlbeyEuQQWAlwFk4PJqx1ARxrXyrK4lgnop5YqKpiQ YVIHdvdMUni/zjn+kv4kcZrL6Uwi//IhCYtqtWPpHIaQ9ZvZIQZWqLTOqQUi+MAskV BcGtm9fjRU7nfNZaOBMQZhcsGGmAu7HOtATLgLziqEHTVAkfx5xVQoyFxKaYkMvnjz Mx8wKHdlP3T0TdBb/fJmIv/JiPDSXSWam3KLFleg9e7M4JjnYGXp67pyXWLeutJnTq u1EdM2yNJQZnhXmmTojr8MD858I2KLPEdehOhg4GtrKHuUNYt0pcMk4MCTSJU3Fz6S xfzE11A3EVldkawVni2bGonHTkHCEUb/UuEqDprWDlCP8VCGAQuS5pxY4iiXRFBinp 08tJA8K5q2a97c2VQ3GaJmaHP5Bov+dd6yRb7Lw+Z5TxjrJ5SS+3MJ34orkeuvy0hO 0qj32eZJbMRmK+aJT1v0bHo8pu7p9GNbuRJoLa6X9ls6gApYZCWdWsfwr531L6SQXy mYMcMHK9+Ana9BAsIcZJUjBH1IWC3vbIbGw3FuOAUXS7MfIamO81w92VSBvwszvS7E AFNwhBYTXXbDAmxjoZ2kGt2tbZnFDeLwXH7ZayQW5RDhWZ0li0ufZIFuwzGvOw0aAe S9IyRo476ED46WeZLdso9h24= Received: from zn.tnic (pd953063a.dip0.t-ipconnect.de [217.83.6.58]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with UTF8SMTPSA id 8214740E0250; Mon, 1 Dec 2025 19:01:44 +0000 (UTC) Date: Mon, 1 Dec 2025 20:01:38 +0100 From: Borislav Petkov To: Adrian Hunter Cc: Masami Hiramatsu , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Jiri Olsa , Dan Williams , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Andy Lutomirski , X86 ML Subject: Re: [PATCH V2 2/4] x86/insn: Add AVX-512 support to the instruction decoder Message-ID: <20251201190138.GDaS3mEm9P5UGfd8jY@fat_crate.local> References: <1469003437-32706-1-git-send-email-adrian.hunter@intel.com> <1469003437-32706-3-git-send-email-adrian.hunter@intel.com> <20251130160528.GBaSxrSFwHscX3vnsB@fat_crate.local> <20251201112526.GBaS17JhPrvYGiWv3L@fat_crate.local> <1e6bfa0c-6733-4de2-80ae-5bc08ccbf58b@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1e6bfa0c-6733-4de2-80ae-5bc08ccbf58b@intel.com> Content-Transfer-Encoding: quoted-printable On Mon, Dec 01, 2025 at 08:15:19PM +0200, Adrian Hunter wrote: > EXTRQ Vo,Uo (66) has a mandatory 66 prefix like vcvtps2uqq/pd2uqq Vx,Wx= (66),(ev) so they end up on the same attribute table, but (ev) results i= n INAT_EVEXONLY which is unwanted. >=20 > Changing that from (ev) to (evo) is probably all that is needed e.g. >=20 > +79: VMWRITE Gy,Ey | EXTRQ Vo,Uo (66) | vcvtps2udq/pd2udq Vx,Wpd (evo) = | vcvtsd2usi Gv,Wx (F2),(ev) | vcvtss2usi Gv,Wx (F3),(ev) | vcvtps2uqq/pd= 2uqq Vx,Wx (66),(evo) >=20 That still sounds to me like a hack: looking at the SDM, that thing: VCVTPS2UQQ=E2=80=94Convert Packed Single Precision Floating-Point Values = to Packed Unsigned Quadword Integer Values *is* EVEX-only insn: EVEX.128.66.0F.W0 the "66" meaning in this case EVEX.pp which are the VEX.pp two bits with = value 1b meaning there's an implied 66 legacy prefix. To make it more concrete, let's take an example from the binutils testsui= te: 62 f1 7d 4f 79 f5[ ]*vcvtps2uqq zmm6\{k7\},ymm5 and that's basically: Extended VEctor prefiX: 0x62 P1: [R:1|X:1|B:1|R':1|rsv:0|mm:1] 0xf1 P2: [W:0|vvvv:0xf |rsv:1|pp:1] 0x7d P3: [z:0|L':1|L:0|b:0|V':1|aaa:7] 0x4f with the opcode 0x79 and EVEX.pp=3D1b, as expected. So there's no real 66 prefix there. But our opcode map says: "# Last Prefix Superscripts # - (66): the last prefix is 0x66" So we're using the marking (66) to mean both an explicit 66 legacy prefix= and an implied *VEX.pp=3D1 66 prefix equivalence. So now the question is, why do the *VEX opcodes need that (66) marking at= all? For operand sizing? Looking at our example insn VCVTPS2UQQ, I don't see any other encoding wh= ere 66 is not present. And there's nothing in the pseudo code either. So VEX.= pp=3D1 is part of the encoding of that insn. So, that (66) there is not really the prefix ... Hmm? --=20 Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette