From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E2EB302CCA for ; Mon, 1 Dec 2025 10:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764584046; cv=none; b=i+6Dq9zNOiNoUB9oKRAkKaPlI/ahI0+wNO6t8kOq0/gXbxruejd+7/zkLCXg9xdax3JVGE14iLIGE7AmKLJdyUfd1Wwxm/Ev1klEO7dsdogapYeGTOh3X5ZcZUgpQE1Sl3bPdVzl0CB3YDDISz585jfSIniT2wAPbIciA87YV6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764584046; c=relaxed/simple; bh=Qx9ZtATPii3IUPLCfrpZlIGQv01IxvcYqaWUxrqqRns=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZLS9Oju1o1rxp0rzALaUxOOZORG2i6WzC34uAPE4FZWxD1D2sYFLjOQ6XHCrLN799Z0E0eG3qY3MVgiGnwiWcdNhjrvDv8TU3DSfZX0mCeJv+faIe+/JOQ7sV0fraV6YHAQs4UzBrXTVqvE+yCGmHwVALjojACvz1iMTWYjRDOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yeK01qT6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yeK01qT6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2448BC4CEF1; Mon, 1 Dec 2025 10:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764584045; bh=Qx9ZtATPii3IUPLCfrpZlIGQv01IxvcYqaWUxrqqRns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yeK01qT6shJ3r9pWaj6JvAn70pI3W863TODZ0anCxyfmo1CQdhJ55lCUGRQTcSJ5y Cu0+mTWBHwZp+Itb9IxKRAIuoAw/n4XSqIHs9pIh/PHNL8XEmVvM06mMRr3bngBGtN yjdB2h17qkDB5HwQpLpaEIkNZMh+WHIXFAdYHu/g= Date: Mon, 1 Dec 2025 11:14:03 +0100 From: Greg KH To: Kuan-Wei Chiu Cc: suzuki.poulose@arm.com, mike.leach@linaro.org, james.clark@linaro.org, alexander.shishkin@linux.intel.com, mathieu.poirier@linaro.org, leo.yan@arm.com, Al.Grant@arm.com, jserv@ccns.ncku.edu.tw, marscheng@google.com, ericchancf@google.com, milesjiang@google.com, nickpan@google.com, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] coresight: etm3x: Fix cntr_val_show() to match cntr_val_store() behavior Message-ID: <2025120149-broadways-upon-ad72@gregkh> References: <20251201095228.1905489-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251201095228.1905489-1-visitorckw@gmail.com> On Mon, Dec 01, 2025 at 09:52:28AM +0000, Kuan-Wei Chiu wrote: > The cntr_val_show() function was intended to print the values of all > counters using a loop. However, due to a buffer overwrite issue with > sprintf(), it effectively only displayed the value of the last counter. > > The companion function, cntr_val_store(), allows users to modify a > specific counter selected by 'cntr_idx'. To maintain consistency > between read and write operations and to align with the ETM4x driver > behavior, modify cntr_val_show() to report only the value of the > currently selected counter. > > This change removes the loop and the "counter %d:" prefix, printing > only the hexadecimal value. It also adopts sysfs_emit() for standard > sysfs output formatting. > > Fixes: a939fc5a71ad ("coresight-etm: add CoreSight ETM/PTM driver") > Signed-off-by: Kuan-Wei Chiu > --- > Build test only. > > Changes in v2: > - Redesigned the fix to match cntr_val_store() logic (display only the > currently selected counter) instead of attempting to list all > counters. > - Removed the loop and the "counter %d:" prefix. > - Switched from sprintf() to sysfs_emit(). > - Refactored control flow to use a single return point. > > v1: https://lore.kernel.org/lkml/20251121002350.1166758-1-visitorckw@gmail.com/ > > .../hwtracing/coresight/coresight-etm3x-sysfs.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot