From: Tomas Melin <tomas.melin@vaisala.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Nuno Sa <nuno.sa@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>,
Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Tomas Melin <tomas.melin@vaisala.com>
Subject: [PATCH v2 1/2] iio: adc: ad9467: fix ad9434 vref mask
Date: Tue, 02 Dec 2025 12:53:08 +0000 [thread overview]
Message-ID: <20251202-ad9434-fixes-v2-1-fa73d4eabbea@vaisala.com> (raw)
In-Reply-To: <20251202-ad9434-fixes-v2-0-fa73d4eabbea@vaisala.com>
The mask setting is 5 bits wide for the ad9434
(ref. data sheet register 0x18 FLEX_VREF). Apparently the settings
from ad9265 were copied by mistake when support for the device was added
to the driver.
Fixes: 4606d0f4b05f ("iio: adc: ad9467: add support for AD9434 high-speed ADC")
Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
---
drivers/iio/adc/ad9467.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c
index f7a9f46ea0dc405e25f312197df4b2131871b4bc..2d8f8da3671dac61994a1864a82cdbef7f54c1af 100644
--- a/drivers/iio/adc/ad9467.c
+++ b/drivers/iio/adc/ad9467.c
@@ -95,7 +95,7 @@
#define CHIPID_AD9434 0x6A
#define AD9434_DEF_OUTPUT_MODE 0x00
-#define AD9434_REG_VREF_MASK 0xC0
+#define AD9434_REG_VREF_MASK GENMASK(4, 0)
/*
* Analog Devices AD9467 16-Bit, 200/250 MSPS ADC
--
2.47.3
next prev parent reply other threads:[~2025-12-02 12:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 12:53 [PATCH v2 0/2] iio: adc: ad9467: fixes for ad9434 Tomas Melin
2025-12-02 12:53 ` Tomas Melin [this message]
2025-12-02 13:51 ` [PATCH v2 1/2] iio: adc: ad9467: fix ad9434 vref mask Nuno Sá
2025-12-02 14:11 ` Andy Shevchenko
2025-12-02 12:53 ` [PATCH v2 2/2] iio: adc: ad9467: support write/read offset Tomas Melin
2025-12-02 13:47 ` Nuno Sá
2025-12-02 14:52 ` Tomas Melin
2025-12-02 15:05 ` Nuno Sá
2025-12-02 15:28 ` David Lechner
2025-12-03 5:38 ` Tomas Melin
2025-12-02 14:11 ` Andy Shevchenko
2025-12-02 15:01 ` Tomas Melin
2025-12-02 16:08 ` Nuno Sá
2025-12-02 18:02 ` Andy Shevchenko
2025-12-03 7:28 ` Tomas Melin
2025-12-03 9:04 ` Andy Shevchenko
2025-12-07 13:04 ` Jonathan Cameron
2025-12-02 16:29 ` [PATCH v2 0/2] iio: adc: ad9467: fixes for ad9434 David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251202-ad9434-fixes-v2-1-fa73d4eabbea@vaisala.com \
--to=tomas.melin@vaisala.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®