From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 207D7274646 for ; Tue, 2 Dec 2025 03:52:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764647571; cv=none; b=BpC9ZZaK8VMMAo3v95dmZhxnLkZJmuMSrrFWsXeKkYCoJIJJH9PUaSyKN/NIq0w3Fuz3KbzDZLD/ZxIMEkSAb16GU3Gx58PxtN0gNpA9WHxX84NBoMm3KINnZvXzxI6V4bsUe7yqGyjeEs7OnGTsLn7BKYGeP88F2pyY2TGFbyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764647571; c=relaxed/simple; bh=pkXKG2GQvk1OEM7BRuyJtmnfW0wRTjwlafvcYL/JLdw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fqzXHvDNzzRbITIuGa5l1Tk32r+SJnZCSTrSEvgGO+FrQTAAuMt6EO8TXhfjq4HQEiSKmPJV8Gt93fv/UkKiSdrGZSSsGIw5ZjvxDIBH/iRNERHEQ9shOvG/Bm+XImz7nMIhiX7LUH8vSvJSDBmJ7AcN1v68bCLHsh+GRfJq9zg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nd/MfoY/; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nd/MfoY/" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-64149f78c0dso7591176a12.3 for ; Mon, 01 Dec 2025 19:52:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764647567; x=1765252367; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P8o+Eh8EpW8XhTpnWYxXlVactBs+R1cj59cC43cOEtg=; b=nd/MfoY/Qo24ZBY9wHu+cDgjyDWg92HaPYym7V73hu20zdmVuJBRUdp5N1TslR+Cd4 o9ATDUzdbXBjINCYTlnB77xgKIJP5ezDgVaT6c7lF9+hGtCubd4xwQmQ5ZHako1wh2Gu X+N4RtbZpk4FH7yhILFPwVPdov6A1ZwOrOeLy3F+QnixIpRNW1J42/vO4M8D7g6Nxw3Q Ab3KhTjxqqoXJPxzfr9UEKp5j1+L3l7VO6tdKQD7HnoxdUvtIo77u0mf86oDijg2Xu7Y A1LZR6xszgttoTcgAgApc1viSTSHgNld0fcucHD52GR/V2yNBU46zmHa8fRBZtf4QABU HVtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764647567; x=1765252367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=P8o+Eh8EpW8XhTpnWYxXlVactBs+R1cj59cC43cOEtg=; b=aPPi7/LMbsGUbTg82wC8omjnRYZAAYnO7VixoaoOzJ8yypAsXCX4wZfLMU/lhM/FX3 kEu8h7M2U2ttqRdmJuJp/B4XYBZwgybunAX592VY7QQEEtTSBSbFQ5G3mv+8TC1FLnaN 7XlbGegBKqkI4uqj0jfzOLzj6lGa2EJAnOkhF9Um30hL+A2qxB2DslHiFo40GLkGATaM kI9H/2/ZFGzRb1TSutSmBqxYr1e9U1834q1BabrrN1u8LLg3B4RYMlEwMf66Rpx9qwvM PIAlr9+PHY87JrIHRvCjeyoDmU9/6LeVr6Kp9KF43cZ6MXf8KMSCevxf1p2NeIHFQbrL T5eA== X-Forwarded-Encrypted: i=1; AJvYcCVO1TTP6dF0IzC5rTwbLLoyWUuwaBtChPDOhTESWpogKzKDhsAzVnoNs+h09GfuqH/g+HzjlxUyKy03hlU=@vger.kernel.org X-Gm-Message-State: AOJu0YwluXijB+l/VjNyqXgqt0QVFDuh0arpf+TM1Q1o+d/OR2AID7Pq Fd0lVG4+8q75Qhbt1dRLN9NUtRRiT1Jn0tl+7HSZli0feP2yb34a+KTU X-Gm-Gg: ASbGncvSrRopCyZRowUVsPoo6gxDjvHrmusAdGlc8126gEmOj4d1QGIzFmYz+AaS8ul b8+BHepFRVymuEE17keJ/Y6tfno9dTkl1UEWx/y7BPdppgwEpDZEFUWNEuxQgXx9PqrqkOBTcX6 jCkNVscjxSkw2+kbohYX9y1+/0bBCNPzqHBMCWssofSDBBxxRpq6mSBms3oGh/1HJkyeAlG+d0D P0BrvGx8ToPm4Tf+KEX3amxqc1LiobXp3BsrnKVqf64rCgiZ/JTy0ENsaDR/y7/6BuSk1AkHw/c QAyIPE4JJqK2dVojkJ73qA0YBaqOkpYk9dLS5U8l3IBDgQtRZIZzLWxuNakzZqZCRs/6GGZlyzS sywAhraKAciLFZ29+kbytt54hrrBz6zsTexuuqSXcH2mm4p62MrEokKWPeioaXrlW5jFUXPb9dC OfVtW1cYpr8Fs= X-Google-Smtp-Source: AGHT+IG06jGTfFPngWqU5kONNdXZ5AeL1NtkquBXAeYGQwQ1JA/HugAKi8S5UOBcmoblocgG3NCdkA== X-Received: by 2002:a17:906:2612:b0:b76:b632:1123 with SMTP id a640c23a62f3a-b76b63214demr2491416866b.42.1764647567357; Mon, 01 Dec 2025 19:52:47 -0800 (PST) Received: from eray-kasa.. ([2a02:4e0:2d14:1a1:8eee:b306:2d20:a328]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5162d3esm1419648266b.8.2025.12.01.19.52.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 19:52:45 -0800 (PST) From: Ahmet Eray Karadag To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com Cc: ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, skhan@linuxfoundation.org, Ahmet Eray Karadag , syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com, Albin Babu Varghese Subject: [PATCH v5] ocfs2: Invalidate inode if i_mode is zero after block read Date: Tue, 2 Dec 2025 06:52:14 +0300 Message-ID: <20251202035213.633096-2-eraykrdg1@gmail.com> In-Reply-To: <20251108120133.37443-3-eraykrdg1@gmail.com> References: <20251108120133.37443-3-eraykrdg1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A panic occurs in ocfs2_unlink due to WARN_ON(inode->i_nlink == 0) when handling a corrupted inode with i_mode=0 and i_nlink=0 in memory. This "zombie" inode is created because ocfs2_read_locked_inode proceeds even after ocfs2_validate_inode_block successfully validates a block that structurally looks okay (passes checksum, signature etc.) but contains semantically invalid data (specifically i_mode=0). The current validation function doesn't check for i_mode being zero. This results in an in-memory inode with i_mode=0 being added to the VFS cache, which later triggers the panic during unlink. Prevent this by adding an explicit check for (i_mode == 0, i_nlink == 0, non-orphan) within ocfs2_validate_inode_block. If the check is true, return -EFSCORRUPTED to signal corruption. This causes the caller (ocfs2_read_locked_inode) to invoke make_bad_inode(), correctly preventing the zombie inode from entering the cache. Reported-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com Fixes: https://syzkaller.appspot.com/bug?extid=55c40ae8a0e5f3659f2b Co-developed-by: Albin Babu Varghese Signed-off-by: Albin Babu Varghese Signed-off-by: Ahmet Eray Karadag Previous link: https://lore.kernel.org/all/20251022222752.46758-2-eraykrdg1@gmail.com/T/ --- v2: - Only checking either i_links_count == 0 or i_mode == 0 - Not performing le16_to_cpu() anymore - Tested with ocfs2-test --- v3: - Add checking both high and low bits of i_links_count --- v4: - Reading i_links_count hi and low bits without helper function to save few cpu cycles --- v5: - Clear i_links_count check - Log the actual i_nlink/i_mode --- fs/ocfs2/inode.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index 14bf440ea4df..08ce0846289c 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c @@ -1456,6 +1456,14 @@ int ocfs2_validate_inode_block(struct super_block *sb, goto bail; } + if ((!di->i_links_count && !di->i_links_count_hi) || !di->i_mode) { + mlog(ML_ERROR, "Invalid dinode #%llu: " + "Corrupt state (nlink = %u or mode = %u) detected!\n", + (unsigned long long)bh->b_blocknr, + (di->i_links_count_hi | di->i_links_count), di->i_mode); + rc = -EFSCORRUPTED; + goto bail; + } /* * Errors after here are fatal. */ -- 2.43.0