From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013061.outbound.protection.outlook.com [40.107.201.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 024533128AB for ; Tue, 2 Dec 2025 09:51:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.61 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764669088; cv=fail; b=jirHAHbp7GXsbUj2ohwcYfFO+Dhw63vlCm/PozszI0YkWaSfOhy2L6LpngRwcxGkDOs+Ouw1PD3ktTplFJ8nLSEep94eYp2KtyWeThGbeexJQEU9WEZBXm9710xZPG6lINp744B7TqBS+BspwGS5Z1R/8xJUKV3/6FvOeZPhTbw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764669088; c=relaxed/simple; bh=RPq7hMedOQDeZ/emZjf7hZlE0Y9GS2/1zrHE575Pw84=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dNv54llFsUzYyUvAnbMY8ZNv4hGJSg5ube6wihJx6IOH00XIAGHQ8Ms7N/YjgbSmJHJk97mHNhVG+u/RK/77m70bzJKex6DTsms9ICO7GYZGlQJKlG1lS19r1K14GWtYBrIeO69e89zd/UWKNfraEzjBABsOOTfVJCFGyAacXFo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=J0/7utQs; arc=fail smtp.client-ip=40.107.201.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="J0/7utQs" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KzFGwOAM1S/I5am4zjqbCatCHatIhBL1Pm8yeB7S4A9IQMAfJzozjDnTpdaZpkFhC0IC+hxoX4UwpKz/1WeGf35+rvZKUeIz3BJbgqK4I7ptuRLCo1NbiDvGMV8wYVq9xEINZTnYvnV+puz38m6fA3dfi4y2yH8PkPHOz7WxSdLI6LSZOu78Dm3+LVmJpXEzPLA/tuwVKQKK4wiiX1rP30qfPzxaZVaNsR3nw9nPRewonbNpgg7p9QtsFovCTioeMtWNIuaDREqkXJtSeDB86mCi4jiK15lqN1BJ2jHM9X6v/TRa/2JrRAXXXClsOPx2DiS7DjpqMxObCeVtiylXxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V2z3VIZ7GA40CA13Fn3mSXgkg3s8RUc1zhwdLYzxGJE=; b=u3Dp1ZiO8cYf+eyd7jexqLiI4rUlWBwfBK6hNbYwiVBN3e+mXH+3lefg7ErN3RhOmQxX+2+ozZjfA12I7aoDAEq/4sLTl9clWgGquooOzMCg33VJPBDBv6Um/rx70UvshQNDer13FyfBys6dGE2mFNGXjLdsETOYRMebO23ysri+Y6+oMlZZlaBBO3Fu2nAWAuI9naGSjwAD7777osVbBbW6r5+4NKeshsbEaBBaG1HxEK7ea5yLe+b9becc+pdckjcF5Ds7gE5JA50WljK9iRzWZPx0LKuF3t5YhChWeAuh3tu8I7LdP42aMYMfxkMPDEU501WK5qjPIx9cZcff+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V2z3VIZ7GA40CA13Fn3mSXgkg3s8RUc1zhwdLYzxGJE=; b=J0/7utQs7dhl4LbA4vsbzQtwtU2SCuFS/nlie38jVeWOJPQiKS5yKKp8y3tPoxEt3ci7ZTMIflb1OP6HasYDcgWbV7zKS7Qmuf34eRB/kORT5WLIkLOXnoCYQ4GTAkNaCu1WX4XsD9khiaiK7WLUo9K8b2GfCo9QDWjjMxnr1WI= Received: from MW4PR03CA0227.namprd03.prod.outlook.com (2603:10b6:303:b9::22) by SN7PR12MB7912.namprd12.prod.outlook.com (2603:10b6:806:341::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.17; Tue, 2 Dec 2025 09:51:12 +0000 Received: from MWH0EPF000A6734.namprd04.prod.outlook.com (2603:10b6:303:b9:cafe::b5) by MW4PR03CA0227.outlook.office365.com (2603:10b6:303:b9::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9366.17 via Frontend Transport; Tue, 2 Dec 2025 09:51:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by MWH0EPF000A6734.mail.protection.outlook.com (10.167.249.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.8 via Frontend Transport; Tue, 2 Dec 2025 09:51:12 +0000 Received: from FRAPPELLOUX01-WSLPUB.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 2 Dec 2025 03:51:04 -0600 From: Pierre-Eric Pelloux-Prayer To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter CC: Pierre-Eric Pelloux-Prayer , , , Subject: [PATCH v4 08/13] drm/amdgpu: add missing lock in amdgpu_benchmark_do_move Date: Tue, 2 Dec 2025 10:47:18 +0100 Message-ID: <20251202094738.15614-9-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251202094738.15614-1-pierre-eric.pelloux-prayer@amd.com> References: <20251202094738.15614-1-pierre-eric.pelloux-prayer@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6734:EE_|SN7PR12MB7912:EE_ X-MS-Office365-Filtering-Correlation-Id: 60a03b7c-279e-4616-4080-08de31885407 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?kvSEgXujRTYcxmXNWzM6eOhkNp3I3nO0XpMXL3BVcuJrLVU3SqhLgxFkZ64W?= =?us-ascii?Q?RcrAZgj8FEZHkWuJ/xq259/Y1YNLo4BQYkJtG8HlBXKYXtlvw3uimzhkj0Ic?= =?us-ascii?Q?A4v+Ye9fHyL9zQBvIJkF6N76RxSHM3QpbfoGg52qw7brGe7hIKRJjDp0ALg4?= =?us-ascii?Q?GJOBQSvJe2xvD/BsqKm7Emz20KewLJb0P0G6O2A50BxHeeCT6e5zD2DmnbUN?= =?us-ascii?Q?MpPxXAJUyTM36l1FrromgEbjYk/tNWYFeKLT2gNz5t2+Ezrz/DLU0sHi9Pzp?= =?us-ascii?Q?PzPA4Epf6K2t/Iw4J+SEyxowSeQC8y9UekYzOIT9puONpK4ahymrv28G8nP5?= =?us-ascii?Q?kQ2Ybal5FGhzRf6NrF5oGzw0DpDHDNHtTlJzgHKa+VRiWJ22qwfUc86u0B8M?= =?us-ascii?Q?kFygbS/tWr3JFP4KqGGi2lMhIH8GKKl0dfGE7WW1tlJ+WWIsNpF/UA8YIN4x?= =?us-ascii?Q?ANTBClAK/r3vJ96QIuDfoOPmVLAUt/Ku9uMgdYSwfrDsEV7ifF7seyLnpJ47?= =?us-ascii?Q?FtcWMoXSvaEvoYiki4Ghcnpn+L7ejzYQt/LRHni4ywKcTqvS/0fwewp3iSAl?= =?us-ascii?Q?Rp8v3m7ZOFDejKeqQTon1r0TbbhsQq60pT++Q9qj4ipDn6eZbyXZcDP5Q9+s?= =?us-ascii?Q?lE3BpTbzCsQidSe+6LDoK5l8WEgytO14QKhkQKGzvcQxCmXOdaulyccoan/4?= =?us-ascii?Q?47Ma1cK94ivTMJCg7Xst5RzayZA+SjmPQFtlko5Z5qNSv4RxaQF+pw2fFtHn?= =?us-ascii?Q?WqjTm9Ps2Nm1zgyCYucC6DDIaKUiR70eTmOj2FWTVfO/y+HBDU6aUOMqtzmO?= =?us-ascii?Q?oP6qIslUcpwyEeIXwCvt0je60/pzO3/LgHDhup58cmHmUt+vp6csnMcMZ+T+?= =?us-ascii?Q?trVxkMWdVu29Y1YwdQZqAMz2D0+EpLSXwFT71/BiSHyEmws/3n/vfzrqCo+X?= =?us-ascii?Q?sPCzQDGq5J6RPSAdOp06ln6NXM4ZEvQhntd05rwRb0sNclqFHND/pAb1j9oB?= =?us-ascii?Q?+61uV65pq3qK44LtpEveQXFOzC3Ts7ww97ljzICTYFt1vRs6/3d3rzRT3auY?= =?us-ascii?Q?TZt/tUHjGC2F0y1DmE3XcQmbwgrwIRA4J12G/iw7bi3LKAR8kCkKKtZs/fKK?= =?us-ascii?Q?aBJvX7P4jcbRdUC+Jxk0Vp2BxOkYiNqcVG/6upXh653Jbz/EyVOYIoyULMbP?= =?us-ascii?Q?eOUllfvVUBFsgTb35rT+wS1FgnKIce/D3ui38L+DFHtxs5nDA/OcvVx9Xpr3?= =?us-ascii?Q?a6UNpL4CKfnZ8YTzxpso60QDiw4+NlBxcxYJ8AsH+KWfCBcpnVlx1momXWtz?= =?us-ascii?Q?XNIh/dQ0pWxJsQvhdl1DtY4tnkgg7W/00S4af2Ntl5S15UVbtNRe4csbh2zA?= =?us-ascii?Q?5PWvaaiI9JvEQF82CUAKQHa1cpH6EPB/OPgp+VTi96kUUgi9tJSTxIfDAdBy?= =?us-ascii?Q?ppMZ1ol6/iiRd1Jr6ESueMoyO0g55iUtGZUFZ6dNRpjAs5p5okZ9on0g29oU?= =?us-ascii?Q?uVoSm9A/3dLqXiQwVD6QkoiSek8akGA1ljYmFojQsDZBeb5mS5RMPL9ot+kP?= =?us-ascii?Q?X4cDX+lUOx74yEGwybI=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2025 09:51:12.6898 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 60a03b7c-279e-4616-4080-08de31885407 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6734.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7912 Taking the entity lock is required to guarantee the ordering of execution. The next commit will add a check that the lock is held. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c index a050167e76a4..832d9ae101f0 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c @@ -35,6 +35,7 @@ static int amdgpu_benchmark_do_move(struct amdgpu_device *adev, unsigned size, struct dma_fence *fence; int i, r; + mutex_lock(&adev->mman.default_entity.lock); stime = ktime_get(); for (i = 0; i < n; i++) { r = amdgpu_copy_buffer(adev, &adev->mman.default_entity, @@ -47,6 +48,7 @@ static int amdgpu_benchmark_do_move(struct amdgpu_device *adev, unsigned size, if (r) goto exit_do_move; } + mutex_unlock(&adev->mman.default_entity.lock); exit_do_move: etime = ktime_get(); -- 2.43.0