From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4D05927FB0E for ; Tue, 2 Dec 2025 16:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764692804; cv=none; b=EBz/180lG7D5XerRRTm+X0tEnsf9Hfxo/C/AanlgUYV85Lts//zaE2q5WuFFlK/pU1BBgcWxtBcpWCM4oUPlC1tpU5TgS8BpD8f8rLRLVxR+7Ou1lt8b180rkF+4SEs3YR1pSVa4V00CO6A+BGs5L7EmdVE1VrNEFuzbsRdS+zQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764692804; c=relaxed/simple; bh=JubwohHdl0/TxPZ+7PmkWPDX1qiRHIKtzAOAj3b/QrQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K3gvqWSFwa/H78/fPJVxZMKGnPT8mtDMb79nQ5NepJC4tHUWmWcZZvQzi0/aEdQeUz+p1SBwLutGhIw4laYUebZPDxvskMRtvylGDQPUWz5YP9kUCTFAWjEnk6kgPdEr9iRLhQXyEe21R/dmuZKZMO9UTlbtlwu5pemzrXYSs24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1DD3B1477; Tue, 2 Dec 2025 08:26:34 -0800 (PST) Received: from localhost (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 15F4D3F73B; Tue, 2 Dec 2025 08:26:40 -0800 (PST) Date: Tue, 2 Dec 2025 16:26:39 +0000 From: Leo Yan To: John Ogness Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Breno Leitao , linux@armlinux.org.uk, paulmck@kernel.org, usamaarif642@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, rmikey@meta.com Subject: Re: [PATCH] printk/nbcon: Restore IRQ in atomic flush after each emitted record Message-ID: <20251202162639.GD724103@e132581.arm.com> References: <20251202135832.156559-1-pmladek@suse.com> <87o6oheywd.fsf@jogness.linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o6oheywd.fsf@jogness.linutronix.de> On Tue, Dec 02, 2025 at 03:39:54PM +0106, John Ogness wrote: [...] > I am not really happy about all the local_irq_restore() usage. Using > guard syntax would be nice here, but AFAICT there is no guard for > local_irq_save()/_restore(). Sorry for suddenly jumping in. Wouldn't guard(irqsave)() be helpful here?