From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F39BA17A303 for ; Tue, 2 Dec 2025 16:39:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764693594; cv=none; b=Ncf7BppkINuhYUUkjjnVJfiiVcN6wjzsU3vRlSdp9Rm1/i+Y183AgQqee4GCKW4s2A9dL4gO2xHu/7NSNPNbNPljNspx/bFB5ivqQkwOoq/dtGgH9zu/ZkYUwRBamUwDuCdSUy7NRLdmcoek/ATyY1w6Vu1U2kdN8sf5/dlF9rk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764693594; c=relaxed/simple; bh=WjgywyX1lYbDuMrcGAQ/Y2C4FPv/9LwidTjkvhpYB3s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N+CEfNuWCMrIWQk90eJ1xurAFDoDZ18vX3KCE7q8F47/XriP2k11C2dCTfwixKHyntEf5LiYMf5lpInd3egwrIAvGfa0UKiJXnRPMHYiYdv2/uFm9lDPNQ9MvKKYTK+VHrTj6iwS3P3RcderQHXdGgGp26/zxqOpRyy2bc9+4/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aMqMcqHz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ilP3+Q1c; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aMqMcqHz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ilP3+Q1c" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B2GBARw1491741 for ; Tue, 2 Dec 2025 16:39:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=FCbQiCm7CuxcEsJFwjxjBZKN8x7WnyE6nCD 9YoQRpr0=; b=aMqMcqHznl10Uhawpx7nMXv6mvMgVgmCyv7z1Z8rWR6GZPRnSZm UL4Lg2nKZ1w39lS7K545VWBq4/zgyntNagk7Kwftd1/yVsv9GjL84rbAhigM31Pn DmZLmEsdj9GvqRyXYpEg1WdqFcxkiJZRVEyGiUHd5utowRPbbhnGLRs5vLBmhdIv CMhVVzG5SV73mXfGZ2Fo27wqdaDodNGFPsK2jQoLBbLTogx4/wTVmKxPcEyc21di Q5wwjUBgcxuWhCOnasOCplq0ZL6gMkduqJS4Lkop8mj/RSnTL3YmHXz5nOgt0OSq 8HsFbzPl8uhO3HHse8hCImoGMbqsiqc/Tcg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4askbd362h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Dec 2025 16:39:52 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b51396f3efso865298985a.1 for ; Tue, 02 Dec 2025 08:39:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764693591; x=1765298391; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FCbQiCm7CuxcEsJFwjxjBZKN8x7WnyE6nCD9YoQRpr0=; b=ilP3+Q1cYUp/ijEsl1T5OihhQEpZClQ/+7dQPL/mn97aOooe/jl6aB8Gju2rGjSe/C laGAf6gZ/FzukmeJe9O2yEEdAVBpM43vFBOnrSfJehRWEeJN9okf6VdZXdJDo9YI4rsU OFgS77FJM++uoqcAOmvzQj63VsyCQlhD4KWpmQDocukMs7yOWwKJwOeArv4z2xKGfW50 OtrSxqCZkYvUE43lXAIC0cYhSFOhKqkEO7399AunstxVh6uYRwUJKdFZdX/36RwXTm55 R+hZT1KSpjmYDC6gtz/fdmr5TUA/1A+oMuaf8GJA2Xc66CWFba0wThP2gwe1zaUOdkfr AgEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764693591; x=1765298391; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FCbQiCm7CuxcEsJFwjxjBZKN8x7WnyE6nCD9YoQRpr0=; b=m6TT2jFYf6Rr0Q3wvqP8+Quco0VU25jGqTWZBHZPBzEK3pcWlXHbLdWZqZQdqyZ6eG TfuOd+iMv1th99EJOmMzYD0tnzNUSp2rwD9utBViP5Bn61DkJfhxgncEX78muKVBWux6 rx4hZ5Buv8hgJJgJmSD9Dk/W6/GgDqkLXYh+J5Xa97LKw1EBjQgKM5XLZcCIQyzCzrfe ib38rD+mW1FSAGK07ur8+nUFy/3VYbEnTJdPuAnF8wlXffdRq3J0Q0GgUCINrpZUFZy/ +kNP6hjT1r2sXOXWjNrX1LN3s6r37BauPlp9dlKp2fce0dwqe4wImN9VeX7x7EHtGA6j +y7w== X-Gm-Message-State: AOJu0Yy2WuRliGnsOihrliduYqeLBIwkmfP7YNkGKqXiSe1IQvN35PfE 0wwn4LE+U3hA2vA+8BxqhgfMIgYZOK+JGnDMShOmU0Ofa9eG8LerMjLtTZ9TfK1rzzYIHn1exs+ LNqVfImNfqjnwN5SlvjtSHRHFw8JyCIwqahwIMkupE42U+GcVBsraIUqOAVYhXywJL6U= X-Gm-Gg: ASbGncvF4ViqoCU3ajhDtmV3z/rDgYf0WWrxEaFa1Fxoi1CdQks/Zoqgqejj6F3QIen j9nzz1CclmZl2rno/hYsFjFVGAeFO1+ehGK21tjLy1kaZkOJLHQE/W8mN2F5CpzIL44d6MpOKbI 1h21oWDByuWOlCegu1eUZ97lLdvA1nGEU6NzkQjGi1Yp2ohZIu0dO7fa5r37hIagCIJGcom0LKq zDZ6zLMpP1k7TEgM1CF5ZIgNcMzeMT4Hn964/wlLp7TuITdsIoTpj9eiMQQTAHQ5zqX/1A/kdrg P9oWQxTF+XvWxslZ+j4htSdmlpbUYLfCM8+zcdAJrBJlaQZqezDynERJsX0Q2YsKIlbiDcIhrJG bxt3kix0VQGsCxXTPhNEG X-Received: by 2002:a05:620a:d86:b0:8b3:14dc:2233 with SMTP id af79cd13be357-8b4ebd6fd15mr3901499485a.23.1764693591161; Tue, 02 Dec 2025 08:39:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IEO26NnNTSs9XrUcMbtr9+1DRrfFMvboCdAQWYJqD4B1+SpY8gp0drOhCOvAQmEliNeqlnyRg== X-Received: by 2002:a05:620a:d86:b0:8b3:14dc:2233 with SMTP id af79cd13be357-8b4ebd6fd15mr3901493985a.23.1764693590663; Tue, 02 Dec 2025 08:39:50 -0800 (PST) Received: from brgl-uxlite ([2a01:cb1d:dc:7e00:cd47:7447:ae30:22fa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1cab9af3sm32867392f8f.41.2025.12.02.08.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 08:39:49 -0800 (PST) From: Bartosz Golaszewski To: Philipp Zabel , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] reset: gpio: check the return value of gpiod_set_value_cansleep() Date: Tue, 2 Dec 2025 17:39:37 +0100 Message-ID: <20251202163937.51165-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: QwphQ38rRtngShSszGf4ZNsX8NYaHjnp X-Proofpoint-GUID: QwphQ38rRtngShSszGf4ZNsX8NYaHjnp X-Authority-Analysis: v=2.4 cv=fLg0HJae c=1 sm=1 tr=0 ts=692f1658 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=K767l_RDbl3L3njzg6EA:9 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAyMDEzMiBTYWx0ZWRfXw7crF1PD9+rx xz29WanlFuX/WFd69ANo/9gF3LJ4/qeQ9axo5Q+vi+3Eu07oetdDNqZsxRNp6AaZGd1qsKOrJoz nZzw9gwe/JjkMq6Zzezo8HK0fomitQfv9FA7mXleRnXlly4BmZpF6QF22dDF7Ejb+z8o5Jf5bb7 SDwES9swhN76ZU4zgLxSDZiAeJWz/4Z9odLj//zxQ0tZqRpJ4f3/Q89jWE7FDRLhzU6iMDPzc0l KGp5PqcrEDHPZMs88Men7NMm7hqOghRihV9X64dqaPRs76udjWEpik6VYWCw4GQ0XNJocu//tLq RlnWHslK14iXe03AgnxfkaVpufwVSPGKXiZn5sskg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-01_01,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512020132 gpiod_set_value_cansleep() now returns an integer and can indicate failures. Propagate the return value to the caller of the reset API. Signed-off-by: Bartosz Golaszewski --- drivers/reset/reset-gpio.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/reset/reset-gpio.c b/drivers/reset/reset-gpio.c index e5512b3b596b..fdbd1c0cbe99 100644 --- a/drivers/reset/reset-gpio.c +++ b/drivers/reset/reset-gpio.c @@ -22,9 +22,7 @@ static int reset_gpio_assert(struct reset_controller_dev *rc, unsigned long id) { struct reset_gpio_priv *priv = rc_to_reset_gpio(rc); - gpiod_set_value_cansleep(priv->reset, 1); - - return 0; + return gpiod_set_value_cansleep(priv->reset, 1); } static int reset_gpio_deassert(struct reset_controller_dev *rc, @@ -32,9 +30,7 @@ static int reset_gpio_deassert(struct reset_controller_dev *rc, { struct reset_gpio_priv *priv = rc_to_reset_gpio(rc); - gpiod_set_value_cansleep(priv->reset, 0); - - return 0; + return gpiod_set_value_cansleep(priv->reset, 0); } static int reset_gpio_status(struct reset_controller_dev *rc, unsigned long id) -- 2.51.0