From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00C7132ED31 for ; Wed, 3 Dec 2025 19:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764789857; cv=none; b=IZWjeuaNliSAO6nysuosPo8/f6W8f829merPOI9+wLAk6wZThLZakly33pkViRY7xu8r7VV26kMVWPraNyaMTOyd6pjBEejjNz1x3PZ1FlLxG3psyhGb/IeT7c89nEpc+huB/JujOCcbNelh7fjZK7MScw42i+1aYuVZCqLxCqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764789857; c=relaxed/simple; bh=g3Xgrj94//qyMMVpCBvSKfTqo7S0ZFf+Bwj5A6l44+8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U5yK0C4M6ecSkvLXmkJ8aPfEyYwa67LqHtwQ53p0a9cCXlSieAlyUCtcv21hG8Cth+5KJ3FvtHYvnc5d6goVl//Dbbhq0Ozkki1c4vy15vLzVgAsgpxaHaS3Bwc1s3g/XG036do8SGowrfNJ7J4XMl5DXpBT+UZFCdj6rjUBqSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=baWSQZ6l; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="baWSQZ6l" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5B3CSrht014351; Wed, 3 Dec 2025 19:23:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=koPbGo f5lylqH/PZkXMVCJ+RshlglAdcJwwgNhJQBhw=; b=baWSQZ6l9Gw/vBb8lluYOA LvdEbOygSz8lJKl6t0yF9Jv7zJUCFZlA2p0guDYDxMyt6/6y5To/oulWHwTvpIzP Cf7JV53RojoB4Xam3VLgvrZH5ds8vv+2Bj4VT8eyDX0ZoOrX7x6oGp+AB1GJLeW8 +0rER5zA2inKUTGG1nr6fRyj75XJ8WspsxEZCmT113P8CYQ5/B8TentPQBIcIC83 9tDFtWBbPHF6lYlFMYnBHOOIx7PHCIj7m6ac2x5POAjCf67pV7jZCCbRiMJCl8SQ bATaJjCANlT6Xhc9hepORo7MDDaHAjS8YKEvseiqjFtoQHnyekkqZQwJbtPKdJOg == Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4aqq8uv74q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Dec 2025 19:23:40 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5B3GY4PI010227; Wed, 3 Dec 2025 19:23:40 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4arcnkbuh3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Dec 2025 19:23:40 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5B3JNciP30212570 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 3 Dec 2025 19:23:38 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 51FBA20043; Wed, 3 Dec 2025 19:23:38 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0723420040; Wed, 3 Dec 2025 19:23:38 +0000 (GMT) Received: from osiris (unknown [9.111.45.204]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 3 Dec 2025 19:23:37 +0000 (GMT) Date: Wed, 3 Dec 2025 20:23:36 +0100 From: Heiko Carstens To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Willy Tarreau , Alexei Starovoitov , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/nolibc: always use 64-bit mode for s390 header checks Message-ID: <20251203192336.19702A2c-hca@linux.ibm.com> References: <20251203-nolibc-headers-check-s390-v1-1-5d35e52a83ba@weissschuh.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251203-nolibc-headers-check-s390-v1-1-5d35e52a83ba@weissschuh.net> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: xwZ7NcwT6KHvIv5YcdFDLB3OdXYojzxs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI5MDAwOCBTYWx0ZWRfX3SEJxGBdj2Mh 1G3nQ1PUFltzuOQJ5lH0PjerjE5oOU8KM/vwYOCkOfK2Ad7pktqrtjPoTe+JCidwe4nte4fIEfJ yvFNhLrms50G1LtptLzxfpKa1faAIPE7WiAy0qFbz277rNwUIx6xtMMdSdhur9EPltEEbyN3dw9 Ss+pwGpFbYCJxbW2yMA718NLM4lJc+s9Iw9Y0/Ivh6BKQPpQ35AuTyIMwSt2tIHYL6JdUdsoHl7 ecxdoqkrKPg5+cRGOMSg5tZ0y0RIESZEpsF9cifbcnqNQZj2gAKQvz5Sv++T4VuCh0phLqhNn3B M7sflxZSWlQZioYpyhVVJxHYX/55tg5cLKGc/A2QEPUM0rSGSSvGPTHLMCQvjo3cJPGf/CxxOYg h28jNr5lr35mA4fb5Un/KrFtMF4dRQ== X-Authority-Analysis: v=2.4 cv=Scz6t/Ru c=1 sm=1 tr=0 ts=69308e3d cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=8nJEP1OIZ-IA:10 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VTue-mJiAAAA:8 a=VnNF1IyMAAAA:8 a=uUpANPHmaWGF-mpaScUA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=S9YjYK_EKPFYWS37g-LV:22 X-Proofpoint-GUID: xwZ7NcwT6KHvIv5YcdFDLB3OdXYojzxs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-03_02,2025-12-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 spamscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2511290008 On Wed, Dec 03, 2025 at 08:08:00PM +0100, Thomas Weißschuh wrote: > 32-bit s390 support was recently removed from nolibc. > If the compiler defaults to 32-bit during the header checks, they fail. > > Make sure to always use 64-bit mode for s390 heafer checks. > > Fixes: 169ebcbb9082 ("tools: Remove s390 compat support") > Signed-off-by: Thomas Weißschuh > --- > tools/include/nolibc/Makefile | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/include/nolibc/Makefile b/tools/include/nolibc/Makefile > index 143c2d2c2ba6..ecc660a2433c 100644 > --- a/tools/include/nolibc/Makefile > +++ b/tools/include/nolibc/Makefile > @@ -107,9 +107,12 @@ headers_standalone: headers > $(Q)$(MAKE) -C $(srctree) headers > $(Q)$(MAKE) -C $(srctree) headers_install INSTALL_HDR_PATH=$(OUTPUT)sysroot > > +CFLAGS_s390 := -m64 > +CFLAGS := $(CFLAGS_$(ARCH)) > + > headers_check: headers_standalone > $(Q)for header in $(filter-out crt.h std.h,$(all_files)); do \ > - $(CC) $(CLANG_CROSS_FLAGS) -Wall -Werror -nostdinc -fsyntax-only -x c /dev/null \ > + $(CC) $(CFLAGS) $(CLANG_CROSS_FLAGS) -Wall -Werror -nostdinc -fsyntax-only -x c /dev/null \ > -I$(or $(objtree),$(srctree))/usr/include -include $$header -include $$header || exit 1; \ > done I wasn't even aware that anybody would build a compiler which defaults to 32 bit, until Arnd pointed this out. Anyway: Acked-by: Heiko Carstens