From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.formilux.org (mta1.formilux.org [51.159.59.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79B5F335573 for ; Wed, 3 Dec 2025 19:32:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.159.59.229 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764790350; cv=none; b=dbMCWmxSRfMh7pZ0qPrYBQ4VUf6cp55bHeNwOC+7z63nQf44k2ktVE1/rqzYgbENjn23fsqq+C9OjQVGiO72WG6Nhhgw7TnLJmD8MoxlYUac645D2ly5B3OoCioex9Y98wtCxzd24hdRhWL03qljhJaEPSx3NnOIdoIJZ/6hZsw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764790350; c=relaxed/simple; bh=j1JvtEqNAap7mCbznkZpomW6HoCtvIP8shJ2VFzewd4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oZ8lgu3VDUth3vk6CLxjCDlYomoPh9UIhfmM38YtSEjonwQfs1A7OdV4KOxSEtNZDL7dO6PHqTHZS8xErpLRYaaEDVx77Xd54G4iv0QGSd3Qq1c8N/cTknYEqYDvCSm90A5n046ap8I0j5hKXnPdrq1EClohDqOFyPBjng9xjr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu; spf=pass smtp.mailfrom=1wt.eu; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b=Ur/iKCOu; arc=none smtp.client-ip=51.159.59.229 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1wt.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b="Ur/iKCOu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1wt.eu; s=mail; t=1764790345; bh=IUygNkAb9qIiJHTK9q3cwFBeo0McJbGKbhjqEq4zNJc=; h=From:Message-ID:From; b=Ur/iKCOu1Pwzwetq9O7Y3fQJZC6m09vmiKPK69tqW/e8siNUqje2WWUfPr4wsOrhv QdRD1VZkJmpXSYKMSAhW7oCFmF8wNBV4kM3Ibv2HL3R43EKt5/p+EFUUrsWPUFNIfN KljftaTBmdUsAh5kARyj6K02pFx7iZ38P4404XAc= Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by mta1.formilux.org (Postfix) with ESMTP id 56393C095D; Wed, 03 Dec 2025 20:32:25 +0100 (CET) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 5B3JWPIT013071; Wed, 3 Dec 2025 20:32:25 +0100 Date: Wed, 3 Dec 2025 20:32:25 +0100 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Alexei Starovoitov , Heiko Carstens , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/nolibc: always use 64-bit mode for s390 header checks Message-ID: <20251203193225.GB12995@1wt.eu> References: <20251203-nolibc-headers-check-s390-v1-1-5d35e52a83ba@weissschuh.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251203-nolibc-headers-check-s390-v1-1-5d35e52a83ba@weissschuh.net> User-Agent: Mutt/1.10.1 (2018-07-13) Hi Thomas, On Wed, Dec 03, 2025 at 08:08:00PM +0100, Thomas Weißschuh wrote: > 32-bit s390 support was recently removed from nolibc. > If the compiler defaults to 32-bit during the header checks, they fail. > > Make sure to always use 64-bit mode for s390 heafer checks. > > Fixes: 169ebcbb9082 ("tools: Remove s390 compat support") > Signed-off-by: Thomas Weißschuh > --- > tools/include/nolibc/Makefile | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/include/nolibc/Makefile b/tools/include/nolibc/Makefile > index 143c2d2c2ba6..ecc660a2433c 100644 > --- a/tools/include/nolibc/Makefile > +++ b/tools/include/nolibc/Makefile > @@ -107,9 +107,12 @@ headers_standalone: headers > $(Q)$(MAKE) -C $(srctree) headers > $(Q)$(MAKE) -C $(srctree) headers_install INSTALL_HDR_PATH=$(OUTPUT)sysroot > > +CFLAGS_s390 := -m64 > +CFLAGS := $(CFLAGS_$(ARCH)) > + > headers_check: headers_standalone > $(Q)for header in $(filter-out crt.h std.h,$(all_files)); do \ > - $(CC) $(CLANG_CROSS_FLAGS) -Wall -Werror -nostdinc -fsyntax-only -x c /dev/null \ > + $(CC) $(CFLAGS) $(CLANG_CROSS_FLAGS) -Wall -Werror -nostdinc -fsyntax-only -x c /dev/null \ > -I$(or $(objtree),$(srctree))/usr/include -include $$header -include $$header || exit 1; \ > done > Interesrting, it reminded me something, I was sure that we had been forcing that one earlier for the case of compilers defaulting to 32-bits, but maybe that was a side effect of us forcing it on other archs. Ah I've found it now it's the commit that introduced s390 support in fact that Brought -m64 from the start, and it was for the test suite: 0043e6f21dbe ("selftests/nolibc: add s390 support") In any case I'm now seeing that Heiko confirmed it as well, so FWIW: Acked-by: Willy Tarreau Thanks, Willy