From: sw.prabhu6@gmail.com
To: James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
bvanassche@acm.org
Cc: linux-kernel@vger.kernel.org, mcgrof@kernel.org,
kernel@pankajraghav.com, Swarna Prabhu <sw.prabhu6@gmail.com>,
Swarna Prabhu <s.prabhu@samsung.com>
Subject: [RFC v2 2/2] scsi: scsi_debug: enable sdebug_sector_size > PAGE_SIZE
Date: Wed, 3 Dec 2025 23:05:47 +0000 [thread overview]
Message-ID: <20251203230546.1275683-3-sw.prabhu6@gmail.com> (raw)
In-Reply-To: <20251203230546.1275683-2-sw.prabhu6@gmail.com>
From: Swarna Prabhu <sw.prabhu6@gmail.com>
Now that block layer can support block size > PAGE_SIZE
and the issue with WRITE SAME(16) and WRITE SAME(10) are
fixed for sector sizes > PAGE_SIZE, enable sdebug_sector_size
> PAGE_SIZE in scsi_debug.
Signed-off-by: Swarna Prabhu <s.prabhu@samsung.com>
---
drivers/scsi/scsi_debug.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index b2ab97be5db3..b5839e62d3bb 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -8459,13 +8459,8 @@ static int __init scsi_debug_init(void)
} else if (sdebug_ndelay > 0)
sdebug_jdelay = JDELAY_OVERRIDDEN;
- switch (sdebug_sector_size) {
- case 512:
- case 1024:
- case 2048:
- case 4096:
- break;
- default:
+ if (sdebug_sector_size < 512 || sdebug_sector_size > BLK_MAX_BLOCK_SIZE ||
+ !is_power_of_2(sdebug_sector_size)) {
pr_err("invalid sector_size %d\n", sdebug_sector_size);
return -EINVAL;
}
--
2.51.0
next prev parent reply other threads:[~2025-12-03 23:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 23:05 [RFC v2 1/2] scsi: sd: fix write_same16 and write_same10 for sector size " sw.prabhu6
2025-12-03 23:05 ` sw.prabhu6 [this message]
2025-12-04 1:40 ` [RFC v2 2/2] scsi: scsi_debug: enable sdebug_sector_size " Luis Chamberlain
2025-12-04 2:02 ` Bart Van Assche
2025-12-04 1:39 ` [RFC v2 1/2] scsi: sd: fix write_same16 and write_same10 for sector size " Luis Chamberlain
2025-12-04 1:59 ` Bart Van Assche
2025-12-04 2:03 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251203230546.1275683-3-sw.prabhu6@gmail.com \
--to=sw.prabhu6@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=kernel@pankajraghav.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=s.prabhu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®