From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fra-out-010.esa.eu-central-1.outbound.mail-perimeter.amazon.com (fra-out-010.esa.eu-central-1.outbound.mail-perimeter.amazon.com [63.178.143.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 990A1221FCF for ; Thu, 4 Dec 2025 19:34:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.178.143.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764876887; cv=none; b=phKt2kl5MaLvfd/BcV9cZ7zbiC7IRGwphgC6LK5v0ZMj6bUOMsSziKhXKpiny4/nk7EZFs8JgqKvfef67j8axMp4bgG3H/nzBWerTuyFYj79Uey8PUo+Sn1VonGUDRVPPqy//RetKRVwMzTfGfkGGGvvLIiUSAeuTMENlv/hXcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764876887; c=relaxed/simple; bh=cNtMnC+OeWKMNetp/Qx2uWGiEUQFfy3pcNG8dm0jzLU=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=stpv/XeQctSiUd7NJ7WdrGpkF9x22Nyed6wwBvmxc1spEOmxeiHkrYfmIWVlA7KpNDeAHdkU66/7asoEZeGw4dOsLdsfJTR4Yh2cAC5oZEKdWnjwjpt8BPF6JiGXss+etbY9K6U1ln1+5pUrT3qV4EIiGz3YAVnJnTUGvbrab1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.de; spf=pass smtp.mailfrom=amazon.de; dkim=pass (2048-bit key) header.d=amazon.de header.i=@amazon.de header.b=YPSFOwzu; arc=none smtp.client-ip=63.178.143.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.de header.i=@amazon.de header.b="YPSFOwzu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazoncorp2; t=1764876885; x=1796412885; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:mime-version: content-transfer-encoding; bh=tt0jeeHG96lYyQ3MRmKmVjXhW+gT4Y5+n4BDpq9oRuM=; b=YPSFOwzu5QElIuieNXA7Yx2fzzqqAe9RVdq3dfi0GRBpiaMIZzKuO/R3 dFkuw6tcTucv2EBhef5J35c02df0ALsdDR1tioxkx8Usxv0kesqw610NL 6otkV/OrpTElyGeo8Kwt3PfCNmfiGSg/fmSaZsVr2nAM5pj4eHJ5g9IVV +orpy5p1VGYLHOxjSy8MUbQ6bg0uyEQ+0+W5NPUtME49in924Opv7BNkv yTq/9uJynaywdDIqthbg45fxFWsHrulaHvru1M88Xfr1IHAUW+39kos7W gA2M6UjNq7LUbxLkFDaNgcN9uMDM02rXFXPomG4BCWnPGPSAKnKkbera7 w==; X-CSE-ConnectionGUID: tUVq+AV9RNqo+IgycCjtvQ== X-CSE-MsgGUID: Mor2QI/JT96/9N6jeVNQag== X-IronPort-AV: E=Sophos;i="6.20,249,1758585600"; d="scan'208";a="6152081" Received: from ip-10-6-3-216.eu-central-1.compute.internal (HELO smtpout.naws.eu-central-1.prod.farcaster.email.amazon.dev) ([10.6.3.216]) by internal-fra-out-010.esa.eu-central-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2025 19:34:27 +0000 Received: from EX19MTAEUC002.ant.amazon.com [54.240.197.228:10065] by smtpin.naws.eu-central-1.prod.farcaster.email.amazon.dev [10.0.37.108:2525] with esmtp (Farcaster) id ddf07f3e-1eb0-4f32-8d0d-4abba4de6cf9; Thu, 4 Dec 2025 19:34:27 +0000 (UTC) X-Farcaster-Flow-ID: ddf07f3e-1eb0-4f32-8d0d-4abba4de6cf9 Received: from EX19D008EUC002.ant.amazon.com (10.252.51.146) by EX19MTAEUC002.ant.amazon.com (10.252.51.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.29; Thu, 4 Dec 2025 19:34:27 +0000 Received: from EX19D008EUC001.ant.amazon.com (10.252.51.165) by EX19D008EUC002.ant.amazon.com (10.252.51.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.29; Thu, 4 Dec 2025 19:34:26 +0000 Received: from EX19D008EUC001.ant.amazon.com ([fe80::9611:c62b:a7ba:aee1]) by EX19D008EUC001.ant.amazon.com ([fe80::9611:c62b:a7ba:aee1%3]) with mapi id 15.02.2562.029; Thu, 4 Dec 2025 19:34:26 +0000 From: "Heyne, Maximilian" To: Keith Busch CC: Jens Axboe , Christoph Hellwig , "Sagi Grimberg" , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] nvme: Let the blocklayer set timeouts for requests Thread-Topic: [PATCH v2] nvme: Let the blocklayer set timeouts for requests Thread-Index: AQHcZVUAJ2T0ZF2M10Kiw4GQ0UHdFg== Date: Thu, 4 Dec 2025 19:34:26 +0000 Message-ID: <20251204-pause-lima-29ecb942@mheyne-amazon> References: <20251204-tests-bryce-8b3b2823@mheyne-amazon> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-ID: <449F71F3AF39C94CA8FB419F2C3D9BC5@amazon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Dec 04, 2025 at 09:13:35AM -0700, Keith Busch wrote: > On Thu, Dec 04, 2025 at 02:11:50PM +0000, Heyne, Maximilian wrote: > > @@ -724,10 +724,8 @@ void nvme_init_request(struct request *req, struct= nvme_command *cmd) > > struct nvme_ns *ns =3D req->q->disk->private_data; > > = > > logging_enabled =3D ns->head->passthru_err_log_enabled; > > - req->timeout =3D NVME_IO_TIMEOUT; > > } else { /* no queuedata implies admin queue */ > > logging_enabled =3D nr->ctrl->passthru_err_log_enabled; > > - req->timeout =3D NVME_ADMIN_TIMEOUT; > > } > = > I was trying to think of any in-kernel path using __submit_sync_cmd with > an IO queue, and quick search shows there's just one: zns report zones. > = > Everything else uses the admin queue, which doesn't have a sysfs tunable > for its request_queue's default timeout. All we have is the nvme module > parameter, which is writable after loading. Since that's the only way a > user can modify the default time for that queue, I think we need to > leave that req->timeout value as-is. Ok sound like a v3 is needed where I only delete the line with NVME_IO_TIMEOUT but leave the NVME_ADMIN_TIMEOUT and add a comment about it. Will prepare such a patch. Thanks for you reviews. Amazon Web Services Development Center Germany GmbH Tamara-Danz-Str. 13 10243 Berlin Geschaeftsfuehrung: Christian Schlaeger, Christof Hellmis Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B Sitz: Berlin Ust-ID: DE 365 538 597