From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f48.google.com (mail-yx1-f48.google.com [74.125.224.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81B082853F1 for ; Thu, 4 Dec 2025 04:34:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764822889; cv=none; b=ei1tatZrLC1jvExJsCxEuoPyiSRVtijB66Vn6eaqXjDUdqeoSFLmnxnNe1K2d+5FkKodMgBcvJMwiqmZ3koNKSPI3R+OE8tQc8phvNPNY4qB1Jr/UKM0cuoVx2MHu7DWOwn8NRcx6GnkBBjbNa1O7b2FMs4JJNRIRcDaAS8gvyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764822889; c=relaxed/simple; bh=GgCOziep81e/EKJzhQH5y0QjEZ56iWmp92jKRaM/sWM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mZ/RxTihHa70rXHvq2GdcWXy1VrovGUgjKPD1cYKmqW/LiRxTFfbdJGPaKEOzA45WXKMc4SLQH478f03YxR45BOT/T9ryk9+FZnjmCdslsgx+b9gCwEN+Cg9ev4uGs/XywI1fWDIYKDEEhUalVmT4xsYC27udefJnn8aM8s27BI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OgarnY1E; arc=none smtp.client-ip=74.125.224.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OgarnY1E" Received: by mail-yx1-f48.google.com with SMTP id 956f58d0204a3-641e942242cso537685d50.1 for ; Wed, 03 Dec 2025 20:34:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764822886; x=1765427686; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nOhogF/bEKUSSSKE3BIN5Xdxnrm5TbeswyD2/DYOGps=; b=OgarnY1E7Gkjw/DevGDJBFY0b8v2+sb6MpJxurlwKQgaJGm7hQqQSZzeFiQT+/ysq/ 8m2dbJcKT4kXSHtXSXXSwmuitQuoIP957gD6fQT66xxlxaJ0/lwcnKaT/VU85TiaVNqs kffs+HgDrTGjeAEsRb83HDRkMtoXeZbfSlbhNXY+hpGNwAJTGXbQIFgJZPMOQWqTGG9E jjhiAY3KiDVr3YyDXKwKMMlA4SVbRNvC/MQjliUnstYCtSy2dAV9bMEUa6MR+AqGW4XJ NeTSNcXqijTCn1AZ1ak8FiT+dhg4dZ1M5oitgNZGdt0X6/EliVPeEPLoQLv8kTkLzXyM XIww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764822886; x=1765427686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nOhogF/bEKUSSSKE3BIN5Xdxnrm5TbeswyD2/DYOGps=; b=bDh1Vbil1qXbD0qlVo//3nDdJ/b7OaDNll/M3rxEf1VihyckTwCBDs58b2wU+6b6tw nQVcbibJgz5TkZCgubAeFCvvWEPR05jI/PLWBcoU+vbm2hyUVfS/djopvtjuhg8gpoAV 5Mwy13uV9x2cvKzSvYOrZ+xSGnaV09/QU9eAu1IeP61uvr36EMBGbyrZCmbwLJAvcuWE VtT70kJdBwJt9huROqWlU0BOLiiB2ydj7GlkQFdv7CrjXTc3fZJAcuYhMatzxDoEFIX+ wOJ1kjlT2T/0xkgasvepF1GWejTuB7MtUlxLYQvhbu1UK323GEMljo/0Bg53sY6BDBMQ Haxg== X-Forwarded-Encrypted: i=1; AJvYcCXgfZI1CT4Ws1hUtsrCevJHOHCLgybdXez+c/fMPwPh4BjdiZEh1o8p7cqnUZEeslGk4MB9zJMYNvxOpp4=@vger.kernel.org X-Gm-Message-State: AOJu0YxmEtaZHM/r0LeC87RR4B5hd/LDcVvfqMItlVp21VXgORDM5lCn 5R+Wfmpny2JCzRZKy9QGKtwQ0FCwrubXIrzx+f3AO/uZmskg4guX9IUs X-Gm-Gg: ASbGncuO8t+Wy15pI3Fn3LiXavQJt/Cd2Q8TclCOpfCXHv/6E7PvEdx3RXiLKe+BiA7 THotU/Kb74o1+i3QaKCGMUKrAYEi0xwN+NBkE0IH3d5puI0CH5yMsEvuBYVUiYZOuX+9uWtTL1m NAzNmjpNABEUBikbBNjvY5VQsI5LkxLKjjRJKy3ShpTfZHdH92NxLj4nRkvtqeqYJxDQQ4Ol9EE X8ubyvO2sz5bhL48i/4QCrDoghrBQdODoUsURfxBGU2jjB7sryTFrnnyFx+/BbjRm7kTvsh07mj pG/dC7RNRBinVN/okbiDmAMeopuozUXaMFDZA1FTZrMXDcHlJf8vHLl3lEUaUosovUmJRYml5c6 8Xyk5j7Z4n6OwX8QCECGcPPY3uR9TQZx5hWPb/JRITTPd4GoWZ4t/Ec8NPQgKHosKh6+Au2WJH9 I/qkNdHnOOnYv5LpmrV8uqExaDaxZgZ9gXZKIvutHfRi5qxdICXc8= X-Google-Smtp-Source: AGHT+IEHsk9cvyWivHQ/qdx/M0oPC+5Tq8/rSqUEJ8fSJ/n8FLJKr7HCddCe5NH32qGcbWy5RlaPRA== X-Received: by 2002:a05:690e:134a:b0:643:ab7e:8dd0 with SMTP id 956f58d0204a3-644370659camr4211118d50.61.1764822886420; Wed, 03 Dec 2025 20:34:46 -0800 (PST) Received: from localhost.localdomain (45.62.117.175.16clouds.com. [45.62.117.175]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6443f2abde8sm264191d50.3.2025.12.03.20.34.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 03 Dec 2025 20:34:46 -0800 (PST) From: Shuran Liu To: song@kernel.org Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, dxu@dxuuu.xyz, eddyz87@gmail.com, electronlsr@gmail.com, ftyg@live.com, gplhust955@gmail.com, haoluo@google.com, haoran.ni.cs@gmail.com, john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-trace-kernel@vger.kernel.org, martin.lau@linux.dev, mathieu.desnoyers@efficios.com, mattbobrowski@google.com, mhiramat@kernel.org, rostedt@goodmis.org, sdf@fomichev.me, shuah@kernel.org, yonghong.song@linux.dev Subject: Re: [PATCH bpf v3 2/2] selftests/bpf: fix and consolidate d_path LSM regression test Date: Thu, 4 Dec 2025 12:34:22 +0800 Message-ID: <20251204043424.7512-1-electronlsr@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Song, Thanks for the review. > I don't get why we add this selftest here. It doesn't appear to be related to > patch 1/2. The regression that patch 1/2 fixes was originally hit by an LSM program calling bpf_d_path() from the bprm_check_security hook. The new subtest is a minimal reproducer for that scenario: without patch 1/2 the string comparison never matches due to verifier's faulty optimization, and with patch 1/2 it behaves correctly. > The paragraph above is not really necessary. Just curious, did some AI > write it? The paragraph was indeed generated with the help of an AI assistant, and I didn’t trim it down enough. I’ll drop it and keep the changelog focused and brief in v4. > This {} block is not necessary. I’ll remove that extra block in v4. Thanks again for the feedback. Best regards, Shuran Liu