From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9927B274B55 for ; Thu, 4 Dec 2025 10:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764845178; cv=none; b=A2Vmx8gXNMeUnDO+TwJjESWFiZfPvXT6y4nsFrXcQntIieGM+odXzR+rcQP0BF/V46CflHajUS6TZ2EGPtQei7yZbfPYhxq1KcTtiMogUfH2bxVbYIKgI9jcfDb0y4/ylJGOr88HyZMBfBuSj1GqWSgOzWLV2Dv0PQpGJ727PBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764845178; c=relaxed/simple; bh=lCQJ3j9F0/Nd0HNMhWmqPX8ZcVBkLyu7xfuL2Y1Qcrs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RUFFgMFfwFqeiXvhN3MXREvpxwJEb/L6/mT0TVbrkVzgtJnfbjrOkxjamVK1ByKd69I4CQ4w+Z9jSRsBHg/9OftMRAtQ4TKPgxe5j86Cng3UlDbKykda9znPw4sILT00VXnpmKsxIBdhXhVnslbTmmV2nEmg3OzABh0q6XIiAEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=RSCBGYFc; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RSCBGYFc" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1Kv5FLBA8MEGnUaqjuMZqeV1BDUWODGC8GoiZVgx0ws=; b=RSCBGYFchSUSxbizQwCrBM6EiD 3SYRW/wS3g7I4TbaTNT4CkN3G+IQe7jkCPIb8J0dsGGcqZzVBdOeg5vtiiyeICma9N+S/oZ2JKZGy LFOwTo3FbS+eMI6+NaM9z5pQAQTXV6Cy5OXaFbP1QKlDywyz2IedEmJ01kQsAtJq1SO+q2LrC68Nv +zy9d6MF3hNooT6A4Kqp+S4UYNMjB9MtCIh17O1uxE8nTQuI+BQj2T2h9GPgSZPF3UorJOjgCnjPl s2BBoT2XNhQ+qlQjJen0mWGjijlWeck/nFF5UF0LlZBWbTZWSNvIMvGAMAJrAdtvgKyP8Qh3SLW6l gZNNt+lw==; Received: from 2001-1c00-8d85-5700-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:5700:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vR6qg-000000044At-0yNH; Thu, 04 Dec 2025 10:46:10 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id C681C3004B8; Thu, 04 Dec 2025 11:46:09 +0100 (CET) Date: Thu, 4 Dec 2025 11:46:09 +0100 From: Peter Zijlstra To: Vincent Guittot Cc: mingo@redhat.com, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, pierre.gondois@arm.com, kprateek.nayak@amd.com, qyousef@layalina.io, hongyan.xia2@arm.com, christian.loehle@arm.com, luis.machado@arm.com Subject: Re: [PATCH 4/6 v8] sched/fair: Add push task mechanism for fair Message-ID: <20251204104609.GH2528459@noisy.programming.kicks-ass.net> References: <20251202181242.1536213-1-vincent.guittot@linaro.org> <20251202181242.1536213-5-vincent.guittot@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251202181242.1536213-5-vincent.guittot@linaro.org> On Tue, Dec 02, 2025 at 07:12:40PM +0100, Vincent Guittot wrote: > +static void fair_add_pushable_task(struct rq *rq, struct task_struct *p) > +{ > + if (sched_push_task_enabled() && fair_push_task(rq, p)) { > + plist_del(&p->pushable_tasks, &rq->cfs.pushable_tasks); > + plist_node_init(&p->pushable_tasks, p->prio); > + plist_add(&p->pushable_tasks, &rq->cfs.pushable_tasks); > + } > +} I might have asked before, but if there was an answer, I have forgotten :/ Why is this a prio-list? It seems to me that we don't particularly care about keeping this push sorted by nice value, right?