From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D6C729B766 for ; Thu, 4 Dec 2025 15:37:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764862649; cv=none; b=l2ah6v3U3h2SZQHUiO0aB23O4ppF8nAhhVafsgihqbvs+fNJT5/ylnJVif7nglekmo0HvtWfTP9VSepJVl0/mA2w0sFt++nt74R80dyjiZMRNxOSQoVenEJlZNGLm65AT2Q74/9ACBdLp5qhWIECwBs0+EKZ4iRZI8sdEeOX4bU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764862649; c=relaxed/simple; bh=TVgnuxlKysk08eelnnKo8pjKu6ntkrgHXUnRDuP7mjE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nSbU0Ibx04vWZCOPOul2lzU84lRgiFhDmTgU0aljEodVU32Dt6F5cEXcFdOMyaAOmCN1EaH0reFDDyd5qGSEj8im13ZKZYRFO1+81G70a2SDotkhgD1DuZAPF/64YTZ+aZGUflbQpaEAuwcbqzE5uXp6oCPnHHvP/NkzNHQ0y54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m3Zx2I80; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m3Zx2I80" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4779cd413b4so699825e9.2 for ; Thu, 04 Dec 2025 07:37:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764862646; x=1765467446; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iasODFwnrpej5ihKsaAUgxOzvlJy+tRXrHwJOSqIP0Q=; b=m3Zx2I80ecf02U53jnpG+oG3M2bVYlJzUIwsiIgxj5/ZI6dDNC8B2B2NGvxNiUG+jK f/SHoGiEe2WuiR5zEiZP/LmM1INIGdZd4RGAHPqLtSm+6wuP+RIDAhCAwm6nZu0mi77h N1BaVHNMHoB5SjBjdufUVwwrRk+YhfEBohR7vSiTVnfYR9iybONeGrRIWEf13AsZHlqO FqRp8yj88K12hGkAnjJe5Bo1n+VdKX9V5TBzd39L0NhEFsWdNsF5Gp2HvHAQh7Txj11k Lkd/9rCrSHTh/35bLVGjOEAve6bF4NRFZTArUW9nmue0Ie2E2/8I8Nka8HK3UIpVXphS ZUXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764862646; x=1765467446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iasODFwnrpej5ihKsaAUgxOzvlJy+tRXrHwJOSqIP0Q=; b=R72XVgrw3Kdp3hIwjf2ENFirBzcwJEP13aSka9jYFxJKBzhOAIWRx/ajH2CtiUkMjg zKjBRVBTEQiPAng00iuyc1M+esk8hvgWNYOqzoxmaqcTQr2WU+4BYWjtF9M2H+xHk3AP N+bc5fIrEUA6n6h0jSdBHedQvDKNBUNA6ixFXT/kz9mJoJr5m5iEU1OClpkexnO2QV0H YZXJ/crs/jcwC45uDvwIBYxTpvFlARCVA7hrP0IynWJ7f8+YRLgolXz9enLSQkOs7c9n DKvLRbzrSJG5NVVvAq6lara0ABasfwDnYEdXwEGUedn/heebEeFcJhkbfocZF/CQv77T AXxw== X-Forwarded-Encrypted: i=1; AJvYcCUOfVHEwzv6grtsUZ36lo2R7rWZgXypNR7JNxoFgVpPPBcIanUxPr2pP/yayaaZu7U2IRKBRsUMlQwEySE=@vger.kernel.org X-Gm-Message-State: AOJu0YyxzzUMpKjvj0QdSbEF86EyAjvIJl8u/pfo2pPqxe3Cfi8hoGfk 3JtURC8lX/uMR4Cbhlfd8tm3Z2cBM53g4VFSoNJn9Gzug4Hwydvpq/7d X-Gm-Gg: ASbGnctpSVnw/Lkam5jC/u+Y+1SqvjVc0503ziF1GXc4GoQ5SzPERYGQXTRPMu+ha5V uOfQec6XRuG29FCQaFI1dddlP0mkyN15w5oKxAXq0gDinznf96FBQOjMaydjh71WUFhrcIvvwOV Ry3NBjB2z4VSGqpaxnY8PcGH4iiWIeIk5lM1aYtX3f4ZucJfXogcIjmzkeBUPxQgFD8St/g7X2A iq18tEkkZOxknHcdRvb3Er0ICpmQ7Won+2cnhSdXuMwciJGc8HYSjulHPE0MdFTGMENZLPXzrzQ Dl757y0p8I0CJvzpoOftSEkZNZs3QEJ8CFTNYzRij4a8blBq+1pxTlYlea6eozp6iyHuJXFLviL 4oHZrP+LGsaon/O0/uuodGfUEO/WECAghphHTUlmctON8vTHthW7YtS6H/L9Wasze1HXQC4zio9 w5jLo= X-Google-Smtp-Source: AGHT+IG0YF6qmFx9hfyT69cJ/NJuiahXcMZFrcwdfYs4/eTXFVZRKEz/Y6SPeFs3HRVMeBHdDKXaRQ== X-Received: by 2002:a05:6000:186c:b0:42b:4219:268 with SMTP id ffacd0b85a97d-42f7568973cmr3423808f8f.4.1764862645565; Thu, 04 Dec 2025 07:37:25 -0800 (PST) Received: from skbuf ([2a02:2f04:d106:d600:dbb2:245d:2cf5:21d3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d353f75sm3948069f8f.42.2025.12.04.07.37.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Dec 2025 07:37:24 -0800 (PST) Date: Thu, 4 Dec 2025 17:37:21 +0200 From: Vladimir Oltean To: Andrew Lunn Cc: Daniel Golle , Frank Wunderlich , Krzysztof Kozlowski , Chen Minqiang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , "Chester A. Unal" , DENG Qingfang , Sean Wang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 2/2] net: dsa: mt7530: Use GPIO polarity to generate correct reset sequence Message-ID: <20251204153721.ubmxifrev4cre6ab@skbuf> References: <20251129234603.2544-1-ptpt52@gmail.com> <20251129234603.2544-2-ptpt52@gmail.com> <0675b35f-217d-4261-9e3f-2eb24753d43c@lunn.ch> <20251130080731.ty2dlxaypxvodxiw@skbuf> <3fbc4e67-b931-421c-9d83-2214aaa2f6ed@lunn.ch> <0d85e1e6-ea75-4f20-aef1-90d446b4bfa1@kernel.org> <00f308a1-a4b1-4f20-8d8e-459ddf4c39b1@gmx.de> <20251204131626.upw77jncqfwxydww@skbuf> <7aacc2c2-50d0-4a08-9800-dc4a572dffcb@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7aacc2c2-50d0-4a08-9800-dc4a572dffcb@lunn.ch> On Thu, Dec 04, 2025 at 04:22:10PM +0100, Andrew Lunn wrote: > > If this is blocking progress for new device trees, can we just construct, > > using of_machine_is_compatible(), a list of all boards where the device > > tree defines incorrect reset polarity that shouldn't be trusted by the > > driver when driving the reset GPIO? If we do this, we can also leave > > those existing device trees alone. > > I've still not seen a good answer to my question, why not just leave > it 'broken', and document the fact. > > Does the fact it is inverted in both DT and the driver prevent us from > making some board work? > > Why do we need to fix this? > > Sometimes it is better to just leave it alone, if it is not hurting > anybody. > > Andrew Frank said that the fact the driver expecting a wrong device tree is forcing him to keep introducing even more wrong device trees for new boards.