mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	 Ingo Molnar <mingo@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	 Eric Dumazet <edumazet@google.com>
Subject: [PATCH] rseq: always inline rseq_debug_syscall_return()
Date: Fri,  5 Dec 2025 10:07:53 +0000	[thread overview]
Message-ID: <20251205100753.4073221-1-edumazet@google.com> (raw)

To get full benefit of commit eaa9088d568c ("rseq: Use static branch
for syscall exit debug when GENERIC_IRQ_ENTRY=y"), clang needs
__always_inline instead of inline qualifier.

Tested:

for i in {1..10}; do taskset -c 4 perf5 bench syscall basic -l 100000000 | grep "ops/sec"; done

Before:
     15,490,350 ops/sec
     15,564,199 ops/sec
     15,450,324 ops/sec
     15,443,986 ops/sec
     15,519,631 ops/sec
     15,400,475 ops/sec
     15,282,792 ops/sec
     15,464,758 ops/sec
     15,344,973 ops/sec
     15,283,429 ops/sec

After:
     15,940,189 ops/sec
     15,971,037 ops/sec
     15,963,332 ops/sec
     15,897,626 ops/sec
     15,824,637 ops/sec
     15,719,760 ops/sec
     15,823,175 ops/sec
     15,745,080 ops/sec
     15,930,646 ops/sec
     15,906,730 ops/sec

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 include/linux/rseq_entry.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/rseq_entry.h b/include/linux/rseq_entry.h
index c92167ff8a7fbd1a0771d5a79c71ee8bc4a0f8bf..a36b472627dec83a9a196eb33b83e8d39061ffbe 100644
--- a/include/linux/rseq_entry.h
+++ b/include/linux/rseq_entry.h
@@ -596,7 +596,7 @@ static __always_inline void rseq_exit_to_user_mode_legacy(void)
 
 void __rseq_debug_syscall_return(struct pt_regs *regs);
 
-static inline void rseq_debug_syscall_return(struct pt_regs *regs)
+static __always_inline void rseq_debug_syscall_return(struct pt_regs *regs)
 {
 	if (static_branch_unlikely(&rseq_debug_enabled))
 		__rseq_debug_syscall_return(regs);
-- 
2.52.0.223.gf5cc29aaa4-goog


             reply	other threads:[~2025-12-05 10:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 10:07 Eric Dumazet [this message]
2025-12-05 13:31 ` Mathieu Desnoyers
2025-12-10  1:12 ` [tip: core/urgent] rseq: Always " tip-bot2 for Eric Dumazet
2025-12-12  9:10 ` tip-bot2 for Eric Dumazet
2025-12-12  9:29 ` tip-bot2 for Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251205100753.4073221-1-edumazet@google.com \
    --to=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®