From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A00A6313E15 for ; Fri, 5 Dec 2025 10:51:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764931897; cv=none; b=IRv3lQRMGOchPxxvXBlUZ7Rfpq7RAiaXQ4f/brRzKgZtjmDKabHtBwIMd/HKwa6X15+VBJGUV9h91hrxlbq8eS9NrpJPui66KmIft0p6Ih/JidHTKUsdABlQ4peJB/eqppxmInqvdSHua9Sk1rf+PlZbMbKMzQ5qiimAWrAyMIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764931897; c=relaxed/simple; bh=zWJF1hs/7NtKiCVHD7z19ZHVDmvF+ta+yv2mvkYN+AE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rU+9vKDGHPMdHXYz1pB1koc7Nwd+b4I2brBgBP2srz4X204bcmv1ng4C7IVqNfj7rve3SBeDMphBq3n8T4z6A3Vt9EMUPB7M6Lhf0JK2NN4cQ02FATnsCpU35jACSPzuDUBR34yksVe27lZfvyzGapQPQUOzNbF9bH4ottFpboM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=rF3ZMlUa; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="rF3ZMlUa" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qBpqqKBm9jcq3b5sG+D/mbVYW8D0LDFoavQ6J4opw5c=; b=rF3ZMlUaV4HZXzHm+AeFMiDcDy /XyjE5sEV8qBsspkm+Us8aZj42ZNmgP6nvckgqEV6/Y0uSA/geZQWYaIrUg/IwQA2TJjHUOZK+cCi 61rOfmUIXZ5m4C6Lmt2Ax7rP2nC7zCVLQogDzKtBdevcfzzGsLZcC9gitc4Bd0Dhwg7Y2TKY0boCB n5er9Nu8assbkFhU7T3dLGm7gn8+Qe3tH+uyi697/9lVzl0ukv/zHNTar9/j71J9oR/pXLocgrgKT uBA/oCm6/GzBlE3uI3ydKgzBjzECGgjyn7OsCLUb8cR1AB1bQrC1Dvuo13sYGqyGpxM7xCtLBqgov rx71nsVg==; Received: from 2001-1c00-8d85-5700-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:5700:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vRSXl-00000005qiJ-1RtH; Fri, 05 Dec 2025 09:56:05 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 7EBD5300499; Fri, 05 Dec 2025 11:51:23 +0100 (CET) Date: Fri, 5 Dec 2025 11:51:23 +0100 From: Peter Zijlstra To: Eric Dumazet Cc: Thomas Gleixner , Andy Lutomirski , linux-kernel , Eric Dumazet Subject: Re: [PATCH] entry: always inline local_irq_{enable,disable}_exit_to_user() Message-ID: <20251205105123.GS2528459@noisy.programming.kicks-ass.net> References: <20251204153127.1321824-1-edumazet@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251204153127.1321824-1-edumazet@google.com> On Thu, Dec 04, 2025 at 03:31:27PM +0000, Eric Dumazet wrote: > clang needs __always_inline instead of inline, even for tiny helpers. > > This saves some cycles in system call fast path, and saves 195 bytes > on x86_64 build: > > $ size vmlinux.before vmlinux.after > text data bss dec hex filename > 34652814 22291961 5875180 62819955 3be8e73 vmlinux.before > 34652619 22291961 5875180 62819760 3be8db0 vmlinux.after > > Signed-off-by: Eric Dumazet Yeah, sometimes these inline heuristics drive me mad. I've picked up this and the rseq one. I'll do something with them after rc1.