From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BD4A3195EA for ; Fri, 5 Dec 2025 12:43:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764938597; cv=none; b=WoHYLnj4jGhjwWcDcaYK40YU+aDU/JWT38WLrrTLZNWtBoRkq92iiaJBBV4V+V+e0wwaS6QAOT/T79qay7ABbsIKqrxwmz9ufdhBHE070YC3BKv07WS5W+d65mgGGmKuZoK5NBTiRNOCei38BEf8p/yb9FwEXcm5t+gNE5ozuLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764938597; c=relaxed/simple; bh=KaL97ixK0CJmN+fUrZlk/rTpAYwbDM/+SZn1YzfU/18=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Emui4nzM2fv1j5HyNgRKir5abkMb4zDyukFrc/FQuXX1knPeFBI1c2JfODXxFGoruGF/Cu8pom2EKDC4KsqJrd7o3QoyrT8KfqE+3GmC0ei91GkPxY2V4MXVn4cFgV9AEsMwG2VzjwBiO89KKEPXrY1IZxRHEphyI2swOmahedg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=NVsBG2z9; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="NVsBG2z9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1764938591; bh=KaL97ixK0CJmN+fUrZlk/rTpAYwbDM/+SZn1YzfU/18=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NVsBG2z9zy7Ot/2Y/8xEGuRkbPpNVkd2AkLIAtu4lroB0Cflld0FwzDteCheRLp2j yQYOkUMIz/pjx321Ntulhn9hwnU8Jshce3cD3K1XY7U4+V8SUE4XMTU5ZmhBVwq3cw bVXw9CGVdQaSxOLL9eTMcHVfDHeMTJ6k4m3yoepVsd4TKF9sdqHlKdDNyc7J4VpiQb 09eFd/paXclvaS3AIPpvZO4S7oGfpVZaUC1/+sZSFYIyam2GLjwJr7FUY1JKA4GsSm JuYaWv8X+EWRNVhB2ARFxXfwk8ccGGOQZ/hheD+HpB6AGRJJ8w7UcF9mNuD9DYFi/n PLQG/QpAKT5qA== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 0A75C17E00A8; Fri, 5 Dec 2025 13:43:11 +0100 (CET) Date: Fri, 5 Dec 2025 13:43:07 +0100 From: Boris Brezillon To: Chia-I Wu Cc: Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Grant Likely , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, tvrtko.ursulin@igalia.com Subject: Re: [PATCH v2] drm/panthor: fix for dma-fence safe access rules Message-ID: <20251205134307.6a06f9e1@fedora> In-Reply-To: <20251204174545.399059-1-olvaffe@gmail.com> References: <20251204174545.399059-1-olvaffe@gmail.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 4 Dec 2025 09:45:45 -0800 Chia-I Wu wrote: > Commit 506aa8b02a8d6 ("dma-fence: Add safe access helpers and document > the rules") details the dma-fence safe access rules. The most common > culprit is that drm_sched_fence_get_timeline_name may race with > group_free_queue. > > Signed-off-by: Chia-I Wu > Reviewed-by: Boris Brezillon > Reviewed-by: Liviu Dudau > Reviewed-by: Steven Price > > --- > v2: collect R-bs and drop misleading Fixes: tag Should we at least Cc: stable@vger.kernel.org so this gets considered for backporting? > --- > drivers/gpu/drm/panthor/panthor_sched.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index 33b9ef537e359..a8b1347e4da71 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -23,6 +23,7 @@ > #include > #include > #include > +#include > > #include "panthor_devfreq.h" > #include "panthor_device.h" > @@ -923,6 +924,9 @@ static void group_release_work(struct work_struct *work) > release_work); > u32 i; > > + /* dma-fences may still be accessing group->queues under rcu lock. */ > + synchronize_rcu(); > + > for (i = 0; i < group->queue_count; i++) > group_free_queue(group, group->queues[i]); >