From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C1853587CE for ; Fri, 5 Dec 2025 18:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764960045; cv=none; b=hkOjMA6gl7Mf8AarYfWPVCLjJN7VkS1GBDf7Vr653hM9Wdmatgbgglhur6MDTlHnU3qxrEfI5Dg01Fd4BBOqMjkVwuDowHbs3W/kKqd+Na1qZo+54K6vpgaLLecTbqT9rtZ7n9xd8bn8VfQisdSFuWzKQpVlzoYVaSwDhJtiIqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764960045; c=relaxed/simple; bh=6Yy3IShQVWKoUdXCDZD3yBqKU2764SqgOZHs7jYW65g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BI2z/EGj/KkCmJ9GPedPfG8V9EH1gxasxKhUCbISFd6Rk+IJJCON6GNs1JuiwYL/z/jtCezfFnczVVKVMXwOZcpdPFo7hMOdZ1HyMdpRbhUFyJqPcMHsuqVp0h0Rpc6KiqrBM9vodnRMRBaRcCF53rN/VhVCZxXaqqAZOz3MAsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OB4B8ACn; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OB4B8ACn" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7aab061e7cbso2948333b3a.1 for ; Fri, 05 Dec 2025 10:40:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764960040; x=1765564840; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gx4zuHCdfmsBvfViSx4dewQ3NC0pwlIv6go7qc93ekw=; b=OB4B8ACnPwttjampNMBOyr5SQc3Lvq62ehcw0tv8++5+w4VkufFKGOxcDXbCKO0ZfO pqHpYswzVY/GbBPI+w8G4ywayCKLapa5R5RRM5i2PHXKwztAC+JznM87b23IhWGIJEVT yG9433rpC9RO7QrY1GfZ+wpMP2+38InsAw4QmJFd1Bjsg6AGdaT1bZaBxwH4CGQ4fMcE aId8rOKhpwqC3YyolpgTi+TLuRH/VfgLCHC0pVdT/YZ6awxPOzVVMl6bTAP733KmyNnW M7SgQvULVcIthAa8zUMJM8LwpiUB1HemuP45Sq/wLzODq6jNbAW4kOyCRQJSdAnQZsSt +pBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764960040; x=1765564840; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gx4zuHCdfmsBvfViSx4dewQ3NC0pwlIv6go7qc93ekw=; b=sw4vMElTOko2Rbdnu4Q3ugPnch3whWvGQ+NoRQ+P+xzv9E0TKegtEUIbNqqLLy+s2T 9/fRriozNi96K99d3B0BJ8kwACWtO+T9biva0Y3Q2OzrkeDcQpbztZGtupj0/kpUmjzX mK3ydWtk3DAi65NY6ZmZk/q0qsR6i2LkOUWssHJl96u+uVxOkCZ7i83x/47oZiymaEKi RvYrw8zpXxOnvwLJxdR3KatFT/HMFfig9GF1PapapHcaZUyCYNU69heqTQZbvcSFcrzF ddFF1HdmdG81jmZu6vMNZmJ2LQMK1uxCNIWueHeM/iIzqzpbEXw8qyQM/J0apWMmwQl1 0/KA== X-Forwarded-Encrypted: i=1; AJvYcCU2RUrBf0FpJqP6KeXItP5FZQJ5ajVT79Vu6xpUnSSkxuNlr/thJ+JzSjoqgDAeu2iQtejU2uK3+mD3BSU=@vger.kernel.org X-Gm-Message-State: AOJu0YzV+LJD/Mp/Y7UDGe2bOEcyOrschyG75jYR1eUaI0OdK+eMA/gc 6A8wliqK/9+0l745gvNFG+9wJAVmMJGYRs5p/8LBC3N/56GG3MncUrUx X-Gm-Gg: ASbGncvTw9pmnBPvuyHR4wTE0sYmotT0aeaSe2ueMm48HLusC9C4E8a/vJd6PddUjOY NIrvVEfniUR0rV3v6Cv0YZGiEc5oQcE43rotCqQlLOauAKzCP5y3W5avxYIjJcRtHHCzZCD1ccQ asKywBF5iwpGZtMNGjFncHXysYhk5C6PvIpL53CgNmZMBdZgdeU+U6by8/61/MW/RJZ7qMMg9Gs rdQQZ/nWGFqN/w4qFgnqwQeJFsx9fx0lzgBtmaG/2O8TPjqV8/gTdNvajvleS3VdJAwNYzAB6Km /c70hFg9aixaJVuO2c4c5ZoF+3Mt9RVfMzIAKtZyi8CJNCVM+MgPde1HKNIMU5saG/y7Dx83Z/m NvI73CtyCB20i1YNWuf5z9GHFHId0Sclf3inTfA9DtPXcAblZLSyPKngMIVjuKdvgC0f1sz7d4O GLjFEuKNwKcf725lGWEQE8VCNF4Q== X-Google-Smtp-Source: AGHT+IFdaIOl2EVfDf53MnHxu6h2Csp/9+fkL7qdsbkngVF7MJLua/LR1xBA2DmFila+UaeQfEKpNw== X-Received: by 2002:a05:6a00:ac3:b0:7e8:4433:8fb5 with SMTP id d2e1a72fcca58-7e8c6cab76fmr135748b3a.61.1764960039751; Fri, 05 Dec 2025 10:40:39 -0800 (PST) Received: from shankari-IdeaPad.. ([103.24.60.188]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7e2a0533f08sm5952079b3a.23.2025.12.05.10.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 10:40:39 -0800 (PST) From: Shankari Anand To: Igor Korotin Cc: Greg Kroah-Hartman , =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Danilo Krummrich , Alice Ryhl , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Alexandre Courbot , "Rafael J . Wysocki" , Miguel Ojeda , Alex Gaynor , Michal Wilczynski , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Daniel Almeida , Abdiel Janulgue , Robin Murphy , Shankari Anand , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH 05/10] rust: kernel: Update ARef and AlwaysRefCounted imports to use sync::aref Date: Sat, 6 Dec 2025 00:10:23 +0530 Message-Id: <20251205184023.7230-1-shankari.ak0208@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <1b7408c5-64a8-42f1-92ab-dd90a883c1a4@gmail.com> References: <1b7408c5-64a8-42f1-92ab-dd90a883c1a4@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello Igor, > > NIT: This module already imports `AlwaysRefCounted`, so please use the > imported name instead of the full path for consistency. > > > fn inc_ref(&self) { > > // SAFETY: The existence of a shared reference guarantees that the refcount is non-zero. > > unsafe { bindings::i2c_get_adapter(self.index()) }; > > Thanks > Igor I apologize for the overlook. I was just focussing on changing the path. I'll make the required changes and send a v2. As this patch is part of a series, am I supposed to send all the patches with a v2, some have been acked by already, hence I had the question? Thanks and regards, Shankari