From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A11040855 for ; Fri, 5 Dec 2025 21:29:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764970152; cv=none; b=P/oVj7B9YJnemiQladcb118bs5e+J9i9cbcrixMlAnLy20TKsA5IcZ4d8yBxMA3f4e25LP1QY7Zk6C237J72z5fgs2ZvkzBtGRa5FO3/98WeQJSl7nnPCV+YYRXOaYMnGe09wny7XIlwtf2AKVcJm9LGM5104lnYBwTn5D4MoJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764970152; c=relaxed/simple; bh=3MEeSB+tL+nPmJ0UwxkPPir86FJ40OMgsk0PPwQsiuI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=p7UTasVNdMob93/SkOXpViACHHi3KVur/7N7SMFSq5yKak7EwbO3uTQC93T0f8NazxeHPDtM9krJ/fJ6LLeAF48UP2C9ImZu5Z70d4V0VO9Fi1RN1BogVmhl9jMFCyXr6S6gHOS9Ix63aL4JMZAapK87Nll6cxckeuyZVE/uLM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U/KfsgQd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U/KfsgQd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDFECC4CEF1; Fri, 5 Dec 2025 21:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764970152; bh=3MEeSB+tL+nPmJ0UwxkPPir86FJ40OMgsk0PPwQsiuI=; h=From:To:Cc:Subject:Date:From; b=U/KfsgQdLBAYy+MOVGAJ/bHj/XtmAx1bVSa9JgJGXoXn2EdLF1fqcJzaQ366bwcz+ NCvBhuxvlmRuuRVAAvfwuhL2Pw4Zo6pnii6Fq39HyyC6MY9nKMSPwRIPbC6Du/5EpK vXAOnWY228FAA71uDh5YQQJ182cTvfELBmcCePjtyhyXIRV37kN8eMA30tdMe7fNUc m7YN9/gFI6ugb/efgrKi3+Pq4TTyMyPOqfNwoHhNQImsrYgjTCfxj4or0WIWUifIiM h8CzoCOcihB0tCYtSil39e65NXTbUd4+lRDE5zWWtAJ8lBSCIfO6qlCas38kVxaFP/ lfQVtW3rXFB5g== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu , stable@kernel.org Subject: [PATCH v2 1/2] f2fs: fix to do sanity check on node folio during its writeback Date: Sat, 6 Dec 2025 05:28:58 +0800 Message-ID: <20251205212900.3969665-1-chao@kernel.org> X-Mailer: git-send-email 2.52.0.223.gf5cc29aaa4-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add more sanity check on node folio during its writeback, if node footer indicates it is an inode: - i_mode should be consistent w/ inode - ofs_of_node should be consistent w/ non-xattr node In addition, if sanity check fails, let's shutdown filesystem to avoid looping to redirty and writeback it. Cc: stable@kernel.org Signed-off-by: Chao Yu --- v2: - fix to not check i_mode due to new inode page may not have valid i_mode - add more check condition for NODE_TYPE_INODE case fs/f2fs/node.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 482a362f2625..83624c302543 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1504,20 +1504,30 @@ static int sanity_check_node_footer(struct f2fs_sb_info *sbi, struct folio *folio, pgoff_t nid, enum node_type ntype) { + bool is_inode; + bool is_xnode; + if (unlikely(nid != nid_of_node(folio))) goto out_err; + is_inode = IS_INODE(folio); + is_xnode = f2fs_has_xattr_block(ofs_of_node(folio)); + switch (ntype) { + case NODE_TYPE_REGULAR: + if (is_inode && is_xnode) + goto out_err; + break; case NODE_TYPE_INODE: - if (!IS_INODE(folio)) + if (!is_inode || is_xnode) goto out_err; break; case NODE_TYPE_XATTR: - if (!f2fs_has_xattr_block(ofs_of_node(folio))) + if (is_inode || !is_xnode) goto out_err; break; case NODE_TYPE_NON_INODE: - if (IS_INODE(folio)) + if (is_inode) goto out_err; break; default: @@ -1751,7 +1761,11 @@ static bool __write_node_folio(struct folio *folio, bool atomic, bool *submitted /* get old block addr of this node page */ nid = nid_of_node(folio); - f2fs_bug_on(sbi, folio->index != nid); + + if (sanity_check_node_footer(sbi, folio, nid, NODE_TYPE_REGULAR)) { + f2fs_handle_critical_error(sbi, STOP_CP_REASON_CORRUPTED_NID); + goto redirty_out; + } if (f2fs_get_node_info(sbi, nid, &ni, !do_balance)) goto redirty_out; -- 2.49.0