From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9425D286422 for ; Sat, 6 Dec 2025 10:10:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765015849; cv=none; b=eAXyODZC1xvzt6jPusNcWelkZm/mGl14rktBKe98xh/mLCygeh9dLAkEQH13eAuBxah9G2hpH6VQ8+njJY7u2Xh3ILxAogYx1vS/oRZ1wkLmDI1si4fhsofGuRcQD+YDULodv9ZHN8wrl+VVfweWEO0pZCAgP+usCzs9tDrnQhk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765015849; c=relaxed/simple; bh=/ahlrs1yQ6z3JUaM/Sxqc6wFL/tkbsIVPryicW9j2H8=; h=From:To:Subject:Date:Message-Id:MIME-Version:Content-Type; b=KRtJ7ClmRcQTFGndlyNx0ziz2Wu1OL/JFp0VRNyrOrV8gBp9KQeh3PKpTARp6V2OeRIsP7fZfK4aFbIH0VQ1A2oz4PQPr+59xewvj+kSzpUKjaC+IWDqOJszSMkir2HoHnJtAJOXybHW49WNw80mjNojSb5zmb/cj8tce483Tv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SU1or0CP; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SU1or0CP" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-477b91680f8so30588555e9.0 for ; Sat, 06 Dec 2025 02:10:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765015846; x=1765620646; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=iiDwBzndnl96hSb/q/NLb44uNYBwPkjb4oD5H7teprs=; b=SU1or0CP+kqj1MQu88WiZsNtu1o3IVduDBfjtVy9ikSBHgAi1WTKrOOdWXYtELy/IX uhHqSwtgZ/R2+nL8CUfyYhEwqpSN4PM2lIZaMxEZaoQkRDIFVJbGzmkLWWrhlyAkyK+O xfXjhcxzsrFFLEEZVSYEaQawdrQijAOI0aqvLHwcEE7wzfcNsu/RM6Q1utzZdyc122Sl g1sN1291Elz5F8MWUPH6noeZo30kW22z0UntXfmZSNPymH0yMUOMwErMe91EKSDqlOze RSeWL310j3cU3jlAZOEBpBQpGDczkB2fOAvtHddZX73itV5qjm/bcTy4cj3QpojZEoUa tuGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765015846; x=1765620646; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iiDwBzndnl96hSb/q/NLb44uNYBwPkjb4oD5H7teprs=; b=UnkM8pnXY/YigrEuhX6Y/vw9LS0rhoeq0yBfaH2gVVeuqWiCrN9V9Fhz7BMyv0F7qP +YU9atH8PZutgECu4g5rcQL+W3DqLGt69gPYV1vNj5vT+zSm38BOEN6oPC3qybD8uzSE PL8k4kcywhzs4Jd2NZt/rZVnGIUD6uhvECr1yNwMQtr53Y//QgoGW7ktLV4ZAyjVjkxr inM121LhKl5zCEeqALlq2+H+GhmVXbBE+bmeZqQKBjGfy6oBn2bQd6JiuPw0d2ZGzqeO ciTH60n4lv13YEpbBiEaCmaWJ+p+DdI1Y1iENfblH/eBORV7qgKeMAD7/yBv+V026cI7 PG8g== X-Forwarded-Encrypted: i=1; AJvYcCWRxDyANhyPTyLxs2ClkWz7U5NeQIBbCgf9qwL1O16CUMz62X0L3OleH+6v4Z5g9saw0VY2sDEew4qjvM8=@vger.kernel.org X-Gm-Message-State: AOJu0YwiDrjDyxaqG5JJB4BjB2Iy6o8j2dJkpAVtdCrW3RYeNVHJdypr uWaFokXnwMh/QaIfJf0lnm4rLQLTX9pC+wfpSXvUhWvOpEO+HWrlx5jW X-Gm-Gg: ASbGncvSlPXH/ers+dgIdnGD6N2tXcypADCHMTedaE8WWClE2aWU5ielXnx5kp4eMy9 +r06hV/9TFhzIBU4ss1GZeh1kINWSxiEij+APRXVoNxQ/jR2s/UwbERiS6L5p3Y22GXK4f2NhRL zUfOWqqdJIwk8qLixJqyawcw5+7lNAl/sybBd601PNUze8tf6g/htVcp/nuwjBpwedoOAQrkkzI SXu7H8RmKOZ7fUlqKBHZ/iPa0H1U4Kg+d5XAzzWWuXiXbPL2BzlqnnwEfji+CiR/S50Vh9KfZbv QEazRyNuZ1nmo2u4kkBJScBoLzBd8W5nFVZtE38AGphSovZ3DYKKxgRQdMmk3IxLsIm4v9cjMov To1uXp4UIN2vTrQUBQ4zRCHl/HXtyviwbcdO664Kvi9J560nm6JKHnSvVosbP+fSTZh+td6Uc+w VlZQG681r3sXDpcgE= X-Google-Smtp-Source: AGHT+IHCCSKpPzDS66jMH4ALE7X9BZR5z4AUj5KRqSpHUrEc/DwbowSb3EPWCQS5cwLW9Z47DlGV3A== X-Received: by 2002:a05:600c:1c0c:b0:477:5cc6:7e44 with SMTP id 5b1f17b1804b1-47939dfa46dmr19757195e9.11.1765009694011; Sat, 06 Dec 2025 00:28:14 -0800 (PST) Received: from toolbox.. ([87.200.95.144]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479310a6d9dsm123094705e9.2.2025.12.06.00.28.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Dec 2025 00:28:13 -0800 (PST) From: Christian Hewitt To: Detlev Casanova , =?UTF-8?q?Olivier=20Cr=C3=AAte?= , Ezequiel Garcia , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Diederik de Haas , Dmitry Osipenko , Thomas Gleixner , Dragan Simic , Chukun Pan , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/4] media: rockchip: rkvdec: add support for the VDPU346 variant Date: Sat, 6 Dec 2025 08:28:05 +0000 Message-Id: <20251206082809.2040679-1-christianshewitt@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This series depends upon Detlev Casanova's current v5 series for VDPU381 and VDPU383 support [0]. Patch 1 is marked DO-NOT-MERGE as it contains fixups for minor nits spotted in Detlev's series. I've flagged them on IRC after v2 but the messages may have been missed as they are still present in v5. Patches 2/3/4 add support for the VDPU346 IP block used for H264, HEVC and (in future work) VP9 on the RK356X boards. VDPU346 appears to be a close relation to VDPU381 used with RK3588, except with a single core, output limited to 4K, and minor feature differences, e.g. HEVC level 5.1 on VDPU346 vs 6.1 on VDPU381. To handle differences we declare a new compatible. The device-tree changes are derived from prior-art in Detlev's patches for RK3576 and RK3588, the vendor kernel [1], and some earlier patch attempts from Piotr Oniszczuk and Diederik de Haas. The register differences between VDPU346 and VDPU381 appear to be minimal so we currently and intentionally reuse the VDPU381 h264, hevc, and regs files to avoid duplicating code. If further register analysis requires separate files for VDPU346 the refactoring to Detlev's drivers is a little beyond my current beginner level c skills. As the overall minor changeset to VDPU381 it would be awesome if this series could be absorbed. I had some discussion with Olivier Crête during VideoLan Dev Days last month that suggested this might be possible? - hence sending now. If not, I'll wait until Detlev's series has been merged before sending a next iteration of these patches. Testing with Jellyfish files of varying bitrates shows that RK356X starts to experience jerky playback above 10mbps, which seems rather low compared to RK3588 which can play 300mbps media without issues. The vendor kernel documents 'advanced' assigned-clock-rates but increasing them does not have any obvious impact so the difference looks to be something deeper. NB: The same is also seen with Detlev's patches for RK3576 (max 15mpbs) so further or follow-up work is likely required. Despite the apparent limitation real- world media from my collection plays well. [0] https://patchwork.kernel.org/project/linux-rockchip/list/?series=1015221 [1] https://github.com/rockchip-linux/kernel/blob/develop-6.6/arch/arm64/boot/dts/rockchip/rk356x.dtsi#L1539 Christian Hewitt (4): media: rkvdec: minor fixes for current DETLEV patches media: dt-bindings: rockchip: Add RK3568 Video Decoder bindings media: rkvdec: Add support for the VDPU346 variant arm64: dts: rockchip: Add the vdpu346 Video Decoders on RK356X .../bindings/media/rockchip,vdec.yaml | 2 + arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 49 ++++++++ .../rockchip/rkvdec/rkvdec-vdpu381-regs.h | 4 +- .../rockchip/rkvdec/rkvdec-vdpu383-hevc.c | 6 +- .../media/platform/rockchip/rkvdec/rkvdec.c | 110 ++++++++++++++++++ 5 files changed, 166 insertions(+), 5 deletions(-) -- 2.34.1