From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C3AB2DC76D for ; Sat, 6 Dec 2025 10:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765015810; cv=none; b=G5/cX77rbqwtBL7miaCvEW97pvD/qxYQG+OEoo5Z/Pid8n/eMm5U9S/nqvS6gjqt+p9/meN53IXRUW18x6XqulmKVUtfwAsVcCrxIztTZ7KQCX5poksxLTkDC68MgE5fKp1hGwfSCQ1qKLqxOF2KqMhJNGzN1MjkkFXEsnQNrYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765015810; c=relaxed/simple; bh=+jGOeCwBw8II32ra0icNbqTPgNqvqPgK5Vys0nmFvas=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dlqtp5F8RRwuAvoUYTQ7o3d0dT7Z4dBZI6mLRavhTtkbPWnvkcIf+61lE9E87A8AE0UAKDX3d4njxzekL9WAEWlkP/JBvvckgzxQl4doJkQxhnTeXuRjvqUq+oAmmkabR2pFlPrDQeL80brkHmL9b9srlAJwXfhMkHHnATiJ22U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hWsA0F3S; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hWsA0F3S" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4775895d69cso14782105e9.0 for ; Sat, 06 Dec 2025 02:10:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765015805; x=1765620605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=e72Qsvat0tIoMqay2xUvf0obYBQDN80gqXGFbCav6vw=; b=hWsA0F3SkrHuXyyJPfuaAC9/vSFJXWqKt7Ec+bvzrDBI8nhGur3I64O+k2EZ98w7y9 g1k77/YzNJYI7kL03+p/gJeya/2A/xO4lI3mU1PA89f5rzzYbqp+Ho4uTGtS+0v2nkdo 60CBSn54azyvvm3QDz0xTSjam0MZxu5FsFNPAVu6TWgjg6CnjMkvziXp06G19jMcmpmw 9lJ9s1rs0eOHbmBCT2NGyHSigQozrbztz2NkUPLyVXGENFLqJV/NgHjwkoJeg5uro5l4 C5IWCU+78St8CKCCxCpGEbpzMuiq6sbf6CTdwvOXYe8X2mhNQbX4Erc5EMKWyp5EkGbH n18Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765015805; x=1765620605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e72Qsvat0tIoMqay2xUvf0obYBQDN80gqXGFbCav6vw=; b=k6CyyybAgSJbWilmeQ3ItZUP6qyuIlrZViXkHyDNeDjYE4PoeJjfOZQCnwW63GZ285 RZu0/yWmNKw+n0Vz25wmFNNSdiwgkND7gJ1+8Os4AEo969vAbzqT+lpN+ZX5MvhkVRam ZfdrZSp5hfp7OtoLfrwu/B4OLn8cDblf3PFdMY3pQxpk+udGOr0NesrtAlvpkRS63PC8 UFRoRttXIgARhEpJUG8S9ipRzuj40ofkG36EPZCpxlu1SASuBg9uPWtqXee+xyZ7nLwh 2snynqAip3e+eHtww5jw5Ac7Vv7sDAJlyjprLAKhbWqbQfBOsB9TpXj3BDker4MNjHqu Pu7A== X-Forwarded-Encrypted: i=1; AJvYcCWIarzLgmjsYoHoaz6/OhW1bXgU2G/Vedb2JbRBZqBFXIv9EVcaDaxP68Enr0nUEOWuqnPmmV/D7XyvScA=@vger.kernel.org X-Gm-Message-State: AOJu0YwcnBgfLv6qHMHNfLKBPtTbzT+Ve9pnn53GBnlioGJopVoLu6c4 yo0lY7vv1LjMAZEU8h0yGN7Kez8eCM1Zt3Dqjjqs1CsqJUGkLC509Z0XES/rdw== X-Gm-Gg: ASbGncsXqy7+AbUiSUfHfxUkEaFxhQxOdE0pPtgciVd/uJxA7T4f4rGc6qIzpBmQk4h rIJxT46ro2X7umgYddatM1tJwC5gO6G7R99/LOf9aKfcq8iaZFoZulY1lvV8kyxMyLDr3VLHN8Z K5Czdta9tM2dHXzGpzBdQNzSp3Airi5R1/GuPp0tKIaQSezgOSwQJkcWZaq8mncWn9YZCVUNDeA /3sOmMXkFQnT0FdGMgEziSIihAbVVF8tcpnqMHJ3cr0Qv5Wotas0hWqtYf/OyMCh+7b+G8ljCDD naU+vVwLRAk3rO9iSKDXh7sYpP+vfTDwdUPq4WP3p81LGGFZo63VgkKBmVY2o+wj4CAbFjoTYLg iWVk8Uo4lkN60u09Yfdf04/35K6TSUrTAak3HcPRCB18TYJJhW7pfYLh6grnAq/NJqPHEzUF0jv BHxOaxAx8Nf7xvHKtCNqg69rCTw33MzDS7x749Y7Xl/HmlcLRZN62u X-Google-Smtp-Source: AGHT+IEmSNHmcH4FFCPuz09y7GCEEGehvT+Ov7sgA5mGuWPM9fGYRimLpF+YjxKKyr6NA1GIzdWOnw== X-Received: by 2002:a05:600c:528d:b0:46e:53cb:9e7f with SMTP id 5b1f17b1804b1-47939e27a9fmr20278105e9.18.1765015804544; Sat, 06 Dec 2025 02:10:04 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47930c747b8sm130665695e9.9.2025.12.06.02.10.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Dec 2025 02:10:04 -0800 (PST) Date: Sat, 6 Dec 2025 10:10:02 +0000 From: David Laight To: Dharanitharan R Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] staging: vme_user: replace (1 << n) with BIT(n) Message-ID: <20251206101002.5e05bed7@pumpkin> In-Reply-To: <20251206063619.30372-1-dharanitharan725@gmail.com> References: <20251206063619.30372-1-dharanitharan725@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 6 Dec 2025 06:36:19 +0000 Dharanitharan R wrote: > In drivers/staging/vme_user/vme.c, the functions vme_register_bridge() > and vme_unregister_bridge() use bit shifts like (1 << i) and > (1 << bridge->num) to manipulate vme_bus_numbers. >=20 > Replace these shifts with the BIT(n) macro for readability, > consistency, and kernel coding style. The whole loop is just doing ffz(). So could be: if (vme_bus_numbers !=3D ~0u) { bus_num =3D ffz(vme_bus_numbers); vme_bus_numbers =3D BIT(bus_num); bridge->num =3D bus_num; ... ret =3D 0; } David =09 >=20 > Changes: > - vme_register_bridge(): (1 << i) =E2=86=92 BIT(i) > - vme_unregister_bridge(): (1 << bridge->num) =E2=86=92 BIT(bridge->num) >=20 > Signed-off-by: Dharanitharan R > --- > drivers/staging/vme_user/vme.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vm= e.c > index 2095de72596a..f62a94ef35fc 100644 > --- a/drivers/staging/vme_user/vme.c > +++ b/drivers/staging/vme_user/vme.c > @@ -1766,8 +1766,8 @@ int vme_register_bridge(struct vme_bridge *bridge) > =20 > mutex_lock(&vme_buses_lock); > for (i =3D 0; i < sizeof(vme_bus_numbers) * 8; i++) { > - if ((vme_bus_numbers & (1 << i)) =3D=3D 0) { > - vme_bus_numbers |=3D (1 << i); > + if ((vme_bus_numbers & BIT(i)) =3D=3D 0) { > + vme_bus_numbers |=3D BIT(i); > bridge->num =3D i; > INIT_LIST_HEAD(&bridge->devices); > list_add_tail(&bridge->bus_list, &vme_bus_list); > @@ -1787,7 +1787,7 @@ void vme_unregister_bridge(struct vme_bridge *bridg= e) > struct vme_dev *tmp; > =20 > mutex_lock(&vme_buses_lock); > - vme_bus_numbers &=3D ~(1 << bridge->num); > + vme_bus_numbers &=3D ~BIT(bridge->num); > list_for_each_entry_safe(vdev, tmp, &bridge->devices, bridge_list) { > list_del(&vdev->drv_list); > list_del(&vdev->bridge_list);