From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Tomas Melin <tomas.melin@vaisala.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Nuno Sa <nuno.sa@analog.com>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ad9467: add support for ad9211
Date: Sat, 6 Dec 2025 20:58:13 +0000 [thread overview]
Message-ID: <20251206205813.08542093@jic23-huawei> (raw)
In-Reply-To: <aTF7qbjbtYqZCR95@smile.fi.intel.com>
On Thu, 4 Dec 2025 14:16:41 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Thu, Dec 04, 2025 at 02:14:49PM +0200, Andy Shevchenko wrote:
> > On Thu, Dec 04, 2025 at 08:01:04AM +0000, Tomas Melin wrote:
> > > The AD9211 is a 10-bit monolithic sampling analog-to-digital
> > > converter optimized for high performance, low power, and ease
>
> Also just noticed that this paragraph is visible shorter than the last one,
> can you make them approximately the same line length?
>
> > > of use. The product operates at up to a 300 MSPS conversion
>
> Is it megasamples? Then MSps?
>
> > > rate and is optimized for outstanding dynamic performance
> > > in wideband carrier and broadband systems.
>
> > > The scale table implemented here is not an exact match with the
> > > datasheet as the table presented there is missing some information.
> > > The reference presents these values as being linear,
> > > but that does not add up. There is information missing in the table.
> > > Implemented scale table matches values at the middle and at the ends,
> > > smoothing the curve towards middle and end.
> > > Impact on end result from deviation in scale factor affects only software
> > > using it for scaling. All the possible hw-settings are also available with
> > > this implementation.
> >
> >
> > Some amendment in the headers would be nice to have,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> ...
>
> > + array_size.h
> >
> > > #include <linux/delay.h>
> > > #include <linux/gpio/consumer.h>
> > > #include <linux/of.h>
> > > +#include <linux/units.h>
> > >
> >
> > You can drop one blank line here.
>
I have nothing to add from a quick read. I thought about fixing up Andy's
comments and applying but meh, it's early in the cycle and beer o'clock,
so please do a v3 tidying those up.
Thanks,
Jonathan
prev parent reply other threads:[~2025-12-06 20:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 8:01 [PATCH v2 0/2] " Tomas Melin
2025-12-04 8:01 ` [PATCH v2 1/2] dt-bindings: " Tomas Melin
2025-12-06 11:03 ` Krzysztof Kozlowski
2025-12-04 8:01 ` [PATCH v2 2/2] iio: " Tomas Melin
2025-12-04 12:14 ` Andy Shevchenko
2025-12-04 12:16 ` Andy Shevchenko
2025-12-06 20:58 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251206205813.08542093@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=tomas.melin@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®