From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E11A017BCA; Mon, 8 Dec 2025 01:55:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.254.200.128 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765158931; cv=none; b=oOUkAA5eoRRowPGmx/wZIo+aBv4niiY3+zw55AxpV0ATRxyVtJv8k5o4ouTQpuNzP1fUBT/bT4bacxAevh6ZD9QHH7ZXtKv9jO/gEJGzxC7I8136/3YDdQ4g6Id9vQPvaJGXuBP439RLxTVpbU5ytGwCwSD/E/JmEIFFyd1Mw48= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765158931; c=relaxed/simple; bh=h0pCZz5+jGdL4jHfqv8SeEm661EwxFMYo52mgmuJj2I=; h=From:To:Cc:Subject:Date:Message-Id; b=W5MrrWGQ1M6TOeaggTrGY9/AZV0OHHQVCkv5soiY5+zaYYhKM6SFw+8xsXT/YMlnDeuskKvkXGXDiT4sfeKy2P8Omux7eBbNKwrp4wizVpmF2zpCcCcdcEhzkMPi75A7Hq3W8H/29X7melu0xIssMieyOWlsdFxi4Uyao6TEF4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=airkyi.com; spf=pass smtp.mailfrom=airkyi.com; dkim=pass (1024-bit key) header.d=airkyi.com header.i=@airkyi.com header.b=DXGGrnA3; arc=none smtp.client-ip=54.254.200.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=airkyi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=airkyi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=airkyi.com header.i=@airkyi.com header.b="DXGGrnA3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=airkyi.com; s=altu2504; t=1765158913; bh=VeyqSoizmqK0bMf9MGWnIxk8N3H7v73/6jd8+9E47AQ=; h=From:To:Subject:Date:Message-Id; b=DXGGrnA3QmRkNRhUVwFKfVWtTPPtpk6Qk5I6t6Koq88ZplCXwMt8OtUAatpAZp13T O+05M63/Imk5qzIG2HJ1ozcTWuoWeOEJjuzM+OmjJiPsSonzvILh/OgsIc8Cw2kGWU 9NPuLMMWk+KngRQRlflHE/ofDpttfinsM+YAryRE= X-QQ-mid: esmtpsz19t1765158910t147938f2 X-QQ-Originating-IP: KLDfxHhOJs+8NkhrLa+Oozmfu+ycX1I5AYKb37jPwLw= Received: from DESKTOP-8BT1A2O.localdomain ( [58.22.7.114]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 08 Dec 2025 09:55:06 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 12026027793739871069 From: Chaoyi Chen To: Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov , Peter Chen , Luca Ceresoli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Chaoyi Chen , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: [PATCH v13 00/11] Add Type-C DP support for RK3399 EVB IND board Date: Mon, 8 Dec 2025 09:54:49 +0800 Message-Id: <20251208015500.94-1-kernel@airkyi.com> X-Mailer: git-send-email 2.17.1 X-QQ-SENDSIZE: 520 Feedback-ID: esmtpsz:airkyi.com:qybglogicsvrgz:qybglogicsvrgz6b-0 X-QQ-XMAILINFO: MXC3SJfZoODLfX7e3CdSHUlmho8jaFALmHYEsqgL20oFmFkcU1dKnWQC 7FrQE4gDIH+D6sJUHeBwMCfVwXo7oLEgPTTxmxU5SzxDtWY6iF7rqroMIiBDZn//PkYAauW J4m8DEnDMv4tnPJwaXa1StV8r142pELzLu1UH4NDmuXvKYdBBun8BjxJPHTRZmcAvoCGC4Z 92eHXfmJQotCDfiJmFgnaE0pC+r/fF7cXXCA9Z88iZYoVWPK1EpABo29zbAfziOGgWsASWv On9+uix60p0RrEOXq2ktsk99ZREMgGL0YifTF6Ahspap4e5LYo/XGAlm2JXwIBMGutzyFGd 6iIQ4OEW0RmKqoIubyAoZ6XO+KK4b4avMkM8vRGmPLsbBMVVZra/vU7sKtPbchXWis8sdFi mgCqcHtnoH34FLgrL/38E7QTO0lEVJhG1vKPKICzmayTo+BYP/Rr3kBHyif5rTVYjGxMZ3F 5nsMKmsxmZu4rpfKe4BUkYHYftncr8781WGPyrJHi9CQUr3I30fo81+PEctFJHReu86OPpl KyKxeDl9pq76drIlBzgjKMQH+Fk1ZoQwv8n5HhoOKMpoedm8UNZ5HBbwLQ76RbWg41lP5lX szUbj+PewJgUe0op1VjokYDFC9Bn5dhvDF6wAotg3OrAn/+yDMF7cWNpypN596zIflIpSXw E80gEWfv3Shh/UXYPro5BfNp1ehi3hcsTvYVAwKHxPYmRVESIA03wMVKFrgl5rxE3IPq3VG oGsFXOsCbk4mfPdG4+EfOGvXC49riH+itYhHy7yWbA/0ip55i0I4Ogn+zcqteBJCWyjuUnc rjU6eZJTczTic1G2ecHzDCmdXfBCIigv3KcWF2EgBXh2RujHvkrNBC+O98hDek/5gnTkwlp 7Itepy+ypMAgm6wVytV8LbKj5zrXPQE/xUwfwht3G4PMAt/V1Twu5KZEKimX0WoSI52i5L/ PVpiP7zw/iPxcyGL7iUaOgEdw1DirBgNFFbA8GQxD04bkXC3zpTdrT/xqZsoWK8mp/3Vy5W RQkUDYgA== X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc= X-QQ-RECHKSPAM: 0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: From: Chaoyi Chen This series focuses on adding Type-C DP support for USBDP PHY and DP driver. The USBDP PHY and DP will perceive the changes in cable status based on the USB PD and Type-C state machines provided by TCPM. Before this, the USBDP PHY and DP controller of RK3399 sensed cable state changes through extcon, and devices such as the RK3399 Gru-Chromebook rely on them. This series should not break them. ==== 1. DisplayPort HPD status notify Before v7, I implemented a variety of DP HPD status notify. However, they all had various problems and it was difficult to become a generic solution. Under the guidance of Heikki and Dmitry, a decoupled notification method between the TypeC and DRM subsystems was introduced in v7. First, a notification is sent when TypeC registers a new altmode. Then, a generic DP AUX HPD bridge is implemented on the DRM side. During v7-v10, we added a new notifier in typec to notify the altmode device register event. With the help of Greg and Heikki, we implemented the reuse of notifiers for the type bus itself in patch1 of v11. That makes it redundant for each Type-C controller driver to implement a similar DP AUX HPD bridge in embedded scenarios. ==== 2. Altmode switching and orientation switching for USBDP PHY For USB Type-C interfaces, an external Type-C controller chip assists by detecting cable attachment, determining plug orientation, and reporting USB PD message. The USB/DP combo PHY supports software configurable pin mapping and DisplayPort lane assignment. Based on these message, the combo PHY can perform both altmode switching and orientation switching via software. The RK3399 EVB IND board has a Type-C interface DisplayPort. It use fusb302 chip as Type-C controller. The connection diagram is shown below: fusb302 chip +---> USB2.0 PHY ----> DWC3 USB controller | +---> USB/DP PHY0 +--> CDN-DP controller | +--> DWC3 USB controller ==== 3. Multiple bridge model for RK3399 CDN-DP The RK3399 has two USB/DP combo PHY and one CDN-DP controller. And the CDN-DP can be switched to output to one of the PHYs. USB/DP PHY0 ---+ | <----> CDN-DP controller USB/DP PHY1 ---+ In previous versions, if both PHY ports were connected to DP, the CDN-DP driver would select the first PHY port for output. On Dmitry's suggestion, we introduced a multi-bridge model to support flexible selection of the output PHY port. For each PHY port, a separate encoder and bridge are registered. The change is based on the DRM AUX HPD bridge, rather than the extcon approach. This requires the DT to correctly describe the connections between the first bridge in bridge chain and DP controller. And Once the first bridge is obtained, we can get the last bridge corresponding to the USB-C connector, and then set the DRM connector's fwnode to the corresponding one to enable HPD notification. ==== Patch1 set the bus also for the port and plug altmodes. Patch2 export typec bus and typec altmode device types. Patch3 add generic USB Type-C DP HPD bridge. Patch4 add new API drm_aux_bridge_register_from_node(). Patch5 add new Type-C mode switch for RK3399 USBDP phy binding. Patch6 add typec_mux and typec_switch for RK3399 USBDP PHY. Patch7 add DRM AUX bridge support for RK3399 USBDP PHY. Patch8 drops CDN-DP's extcon dependency when Type-C is present. Patch9 add multiple bridges to support PHY port selection. Patch10 add missing dp_out port for RK3399 CDN-DP. Patch11 add Type-C DP support for RK3399 EVB IND board. Changes in v13: - Link to V12: https://lore.kernel.org/all/20251204063109.104-1-kernel@airkyi.com/ - Only register drm dp hpd bridge for typec port altmode device. Changes in v12: - Link to V11: https://lore.kernel.org/all/20251128020405.90-1-kernel@airkyi.com/ - Add missing Signed-off-by line. Changes in v11: - Link to V10: https://lore.kernel.org/all/20251120022343.250-1-kernel@airkyi.com/ - Switch to using typec bus notifiers. Changes in v10: - Link to V9: https://lore.kernel.org/all/20251111105040.94-1-kernel@airkyi.com/ - Notify TYPEC_ALTMODE_UNREGISTERED when altmode removed. - Add drm_aux_bridge_register_from_node(). - Fix refcount usage of drm_bridge. Changes in v9: - Link to V8: https://lore.kernel.org/all/20251029071435.88-1-kernel@airkyi.com/ - Remove the exposed DRM_AUX_HPD_BRIDGE option, and select DRM_AUX_HPD_TYPEC_BRIDGE when it is available. - Add usb role switch for Type-C. - Remove USB2 PHY in Type-C connection. - ... Changes in v8: - Link to V7: https://lore.kernel.org/all/20251023033009.90-1-kernel@airkyi.com/ - Export all typec device types for identification. - Merge generic DP HPD bridge into one module. - Fix coding style. Changes in v7: - Link to V6: https://lore.kernel.org/all/20251016022741.91-1-kernel@airkyi.com/ - Add notifier functions for Type-C core. - Add generic USB Type-C DP HPD bridge. Changes in v6: - Link to V5: https://lore.kernel.org/all/20251011033233.97-1-kernel@airkyi.com/ - Fix depend in Kconfig. - Check DP svid in tcphy_typec_mux_set(). - Remove mode setting in tcphy_orien_sw_set(). - Rename some variable names. - Attach the DP bridge to the next bridge. Changes in v5: - Link to V4: https://lore.kernel.org/all/20250922012039.323-1-kernel@airkyi.com/ - Remove the calls related to `drm_aux_hpd_bridge_notify()`. - Place the helper functions in the same compilation unit. - Add more comments about parent device. - Add DRM AUX bridge support for RK3399 USBDP PHY - By parsing the HPD bridge chain, set the connector's of_node to the of_node corresponding to the USB-C connector. - Return EDID cache when other port is already enabled. Changes in v4: - Link to V3: https://lore.kernel.org/all/20250729090032.97-1-kernel@airkyi.com/ - Add default HPD device for DisplayPort altmode. - Introduce multiple bridges for CDN-DP. - ... Changes in v3: - Link to V2: https://lore.kernel.org/all/20250718062619.99-1-kernel@airkyi.com/ - Add more descriptions to clarify the role of the PHY in switching. - Fix wrong vdo value. - Fix port node in usb-c-connector. Changes in v2: - Link to V1: https://lore.kernel.org/all/20250715112456.101-1-kernel@airkyi.com/ - Reuse dp-port/usb3-port in rk3399-typec-phy binding. - Fix compile error when CONFIG_TYPEC is not enabled. - Notify DP HPD state by USB/DP PHY. - Ignore duplicate HPD events. - Add endpoint to link DP PHY and DP controller. - Fix devicetree coding style. Chaoyi Chen (10): usb: typec: Export typec bus and typec altmode device type drm/bridge: Implement generic USB Type-C DP HPD bridge drm/bridge: aux: Add drm_aux_bridge_register_from_node() dt-bindings: phy: rockchip: rk3399-typec-phy: Support mode-switch phy: rockchip: phy-rockchip-typec: Add typec_mux/typec_switch support phy: rockchip: phy-rockchip-typec: Add DRM AUX bridge drm/rockchip: cdn-dp: Support handle lane info without extcon drm/rockchip: cdn-dp: Add multiple bridges to support PHY port selection arm64: dts: rockchip: Add missing dp_out port for RK3399 CDN-DP arm64: dts: rockchip: rk3399-evb-ind: Add support for DisplayPort Heikki Krogerus (1): usb: typec: Set the bus also for the port and plug altmodes .../phy/rockchip,rk3399-typec-phy.yaml | 6 + arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 10 +- .../boot/dts/rockchip/rk3399-evb-ind.dts | 147 +++++++ drivers/gpu/drm/bridge/Kconfig | 10 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/aux-bridge.c | 24 +- .../gpu/drm/bridge/aux-hpd-typec-dp-bridge.c | 49 +++ drivers/gpu/drm/rockchip/Kconfig | 1 + drivers/gpu/drm/rockchip/cdn-dp-core.c | 350 +++++++++++++--- drivers/gpu/drm/rockchip/cdn-dp-core.h | 18 +- drivers/phy/rockchip/Kconfig | 3 + drivers/phy/rockchip/phy-rockchip-typec.c | 373 +++++++++++++++++- drivers/usb/typec/bus.c | 25 +- drivers/usb/typec/bus.h | 6 - drivers/usb/typec/class.c | 36 +- include/drm/bridge/aux-bridge.h | 6 + include/linux/usb/typec.h | 3 + include/linux/usb/typec_altmode.h | 8 + 18 files changed, 974 insertions(+), 102 deletions(-) create mode 100644 drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c -- 2.51.1