From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBE181E1E16 for ; Mon, 8 Dec 2025 16:34:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765211667; cv=none; b=RKWwL1fdeRTU6K20ubwdCH+bTWRkEoOaWZJd0NqrWvQRlDmkbR169QVo0Twt+Pu0CHtb3MPOe+c3KIDiKYL4JssxgylOUzB0LoEC1iOHH96gs3yq2CEQunO/ePo1F6PT3AJcFwgS2pd2vDnqQcODHPRFbwvEInR5lLZfB1kMnCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765211667; c=relaxed/simple; bh=2qErDBVauh8Ob3S6JfCcRQ2e/q+m1zJ6QApTq4vjqtM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iOhxOZd3oIT9os9+2gqtghD8+lGIkHgF/QuInUcgUhcHqhFIZqhiWQbgmP3hZD8TLUO0aDCUzurlqRVj2vv6UKGAQGYsvynyD2st0H1LlHID8onajgjfMAZcr5UwFyjdKXXbATpWdwFM33JyODFSSdaTpuUjlc22MQ5uJNm8gwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MNkfconk; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MNkfconk" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-640d0ec9651so8356287a12.3 for ; Mon, 08 Dec 2025 08:34:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765211664; x=1765816464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WqfAF1JHevk6vjXCbG1Hbz4OFMMsEVR96Z5MujIZe5I=; b=MNkfconkxmhuoqOiupqgo87xSqqalFylj37Bl6/PQPLiWLbMvXZr2eMqUb+yuPs7DK iTNOiXUGfNDIgzjULkuqPmJFjukBbWKanwClBPM6D0CoeCVWay2LCSoMD63OQGr6lJPK 9As+OOXqaBPZjdZVBLIsYlOJl7bsSSg037TyWANynJZS7tirlnMa2y5f8ny4/MErdM7I /X2XMQf1T6iLCsClC5OGWgiTPbdn/q7JcLfZMFhP/yqRnTapmL1GjEwg4TXJMQdbbWEW eDseVpSvq5NGREKzoelTEyiDPxAi+GPiPJyaoFJZQYS9ou+qbxUTC8gGTTsIdskfGYMv YH6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765211664; x=1765816464; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WqfAF1JHevk6vjXCbG1Hbz4OFMMsEVR96Z5MujIZe5I=; b=SdVo84Sltr0u48UAjoOJ0E30CjPPt0x30RF4O9rsni/hnj0IR5jW3uOVj8iSxge8aI LDG3FdMFpXPl4uCTZIOcP1p7Rc2IoMoDFyo+fPtW0sgaf0kBJ94Sahzv6GDTXi8sRIok whJLbdLpP3NGv2mpgdo6KJxC+6WKT0+pI2XO6Y8GRWoUfeG2pGcCJaw0HmXat1oZK367 cGKRa6sXt8/95kOZlJJSFPe2aGjY1M91H/l7HJYPr9vkLpcx2CAY84ismOyNaRMp+zhR 9aMdqGc5mDXctY1AUIj3thrGGtxuh/1MaRgmiujNpjibXrllsJfcr1VYmqH0tFNkiBwT BCAA== X-Forwarded-Encrypted: i=1; AJvYcCWkgv4+s6JSbAhIBUInTcJuuTB9Bh/UpVXQ1vl8fPg7U3FYZoamr9pXY7hmdsOKLwGaHSHOBDet16oDsYE=@vger.kernel.org X-Gm-Message-State: AOJu0YyxQ1UvExIx6Iy14HJH8mtRrURVx6ZcgOpMdl9K1buaFv0qIFt5 epYmMuKN3u1zRwFWTQmimolqM/7bAeSWC4xZAhnXtaa0gPlpTkkPtaXbWl60eGN2 X-Gm-Gg: ASbGncsGltVhp2kKoKAu/D7Fp6Nl3RnPEvyAgn7F0chxxRgRfQGUAAv4LCZWJ8H2SW3 IkqL7LQpW8ZqEOrO+1K5LAnJkufUQ8zqzrAjC2IxAdHocq32QFa4LgaRffv6x9bZoDzkRjF3ZPr F5JnWtsC2adm/vFUe5Af9470VPYu0qG0TtmwxcuMjTwG+gLzDr8pAv7KHvJXAneKQhfZnxBKkiz n2DZB8m4Cy19z6npKVuRPQGvUfRAhmVqylqxlQGAuXyk6MhPfhy3RkpY+I6IaksRE4G5rQZTDfs 7gP/LgVuY0epRiijjzqj0Eo8/opg40fV0Ob7fiUeaY9OP0Whc8vSGHhw8qjqoSeI3DAr1YGCkCi eRsvC1EXKneEg0WCJylfb5o9ynzcRu1MWk2gEnR1DUzqh9IIkogEGG2AVOGEWVAIHxwH4+tY5SW WpAtVZWJOgaLo= X-Google-Smtp-Source: AGHT+IEiw2TGf1PWZBQxUY2nu3fERd+iQzg52B2saUAUqD1f6GMoI4Q/11oFj0qOZJQJ0vDzQ7LW+Q== X-Received: by 2002:a05:6402:35c7:b0:643:1659:7593 with SMTP id 4fb4d7f45d1cf-6491ae11406mr6874241a12.30.1765211663856; Mon, 08 Dec 2025 08:34:23 -0800 (PST) Received: from fedora ([46.248.82.114]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64956402185sm766459a12.25.2025.12.08.08.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Dec 2025 08:34:23 -0800 (PST) From: Uros Bizjak To: bpf@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH] x86/bpf: Avoid emitting LOCK prefix for XCHG atomic ops Date: Mon, 8 Dec 2025 17:33:34 +0100 Message-ID: <20251208163420.7643-1-ubizjak@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The x86 XCHG instruction is implicitly locked when one of the operands is a memory location, making an explicit LOCK prefix unnecessary. Stop emitting the LOCK prefix for BPF_XCHG in the JIT atomic read-modify-write helpers. This avoids redundant instruction prefixes while preserving correct atomic semantics. No functional change for other atomic operations. Signed-off-by: Uros Bizjak Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Andrii Nakryiko Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" --- arch/x86/net/bpf_jit_comp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c index b69dc7194e2c..77d724525808 100644 --- a/arch/x86/net/bpf_jit_comp.c +++ b/arch/x86/net/bpf_jit_comp.c @@ -1305,7 +1305,8 @@ static int emit_atomic_rmw(u8 **pprog, u32 atomic_op, { u8 *prog = *pprog; - EMIT1(0xF0); /* lock prefix */ + if (atomic_op != BPF_XCHG) + EMIT1(0xF0); /* lock prefix */ maybe_emit_mod(&prog, dst_reg, src_reg, bpf_size == BPF_DW); @@ -1347,7 +1348,9 @@ static int emit_atomic_rmw_index(u8 **pprog, u32 atomic_op, u32 size, { u8 *prog = *pprog; - EMIT1(0xF0); /* lock prefix */ + if (atomic_op != BPF_XCHG) + EMIT1(0xF0); /* lock prefix */ + switch (size) { case BPF_W: EMIT1(add_3mod(0x40, dst_reg, src_reg, index_reg)); -- 2.52.0