From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50F871E2606 for ; Tue, 9 Dec 2025 14:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765289908; cv=none; b=Pul4sBjWDXICJYniwVGU7HDr/vniSVxBmTYOXfK4DBb07BcQp11ifuSXmw8S0etTXhX8nwoHto7ZWs8GUu390aKDocgSTcm+bkYLA/wDoUu3WTc/Y8SxsFxSMgrbU4IFDD6R+fKv639lwoNuIYDjgBZXZEmKeAw4c/LinoSmbhQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765289908; c=relaxed/simple; bh=naGFcg1q7wl/HAtjaNYwVakwwLo0ymXGoAp/qkubAUE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PQuTLQqMlcPOHP3zZ13WQbz8Y4TCAkKREmZMamJWjSo2kQADZV9M8sRgS1WrEI3hmmF4XThxpMbYZQMiNEgHyPRaIUyRdnuKXlBoFMLNb9MjadomvXoTQ4y3TeK5BGHQovq5Es8zBK06Tjuou0jX1rs+Qb5feu7DuIUC0FA0658= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SuP8V9x3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SuP8V9x3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C13DC4CEF5; Tue, 9 Dec 2025 14:18:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765289907; bh=naGFcg1q7wl/HAtjaNYwVakwwLo0ymXGoAp/qkubAUE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SuP8V9x3aF9kDJn4UnCqh/LsdlUD5P3wnfrG538Ft0xBvC6Pt8WDfAP8ederos+u9 XNsaWRnvG9gj2jGek+ighc8FaV31sGfD6DZ22CGLED4j+ZNWnYJ7zL+mrsoC+KbaWW mu1gDVD71lLpZaIpKcSXUlHNxNZfBUtlTZIF8N7lmijURe+dnQ6sQseKTCgjyEtQlX WrG8faAdFkh50dxiiRkj3t/49/YVq/ZemgnWAbCJYEFwdn5WT9fUxvqg76CJxROwk7 6fH1QBVb52kN1XQSRzhjQdEPn8TOWJAdhVeDZjmN3l+OjHbgzGnCw3KRJg1Jj34HVq 2lpJCmO7ACp7w== Date: Tue, 9 Dec 2025 15:18:25 +0100 From: Maxime Ripard To: Nicolas Frattaroli Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , David Airlie , Simona Vetter , Maarten Lankhorst , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v5 06/17] drm/display: hdmi-state-helper: Try subsampling in mode_valid Message-ID: <20251209-dramatic-caiman-of-luck-db9d0f@houat> References: <20251128-color-format-v5-0-63e82f1db1e1@collabora.com> <20251128-color-format-v5-6-63e82f1db1e1@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="yxo2br3bzecmdszc" Content-Disposition: inline In-Reply-To: <20251128-color-format-v5-6-63e82f1db1e1@collabora.com> --yxo2br3bzecmdszc Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v5 06/17] drm/display: hdmi-state-helper: Try subsampling in mode_valid MIME-Version: 1.0 On Fri, Nov 28, 2025 at 10:05:42PM +0100, Nicolas Frattaroli wrote: > drm_hdmi_connector_mode_valid assumes modes are only valid if they work > with RGB. The reality is more complex however: YCbCr 4:2:0 > chroma-subsampled modes only require half the pixel clock that the same > mode would require in RGB. >=20 > This leads to drm_hdmi_connector_mode_valid rejecting perfectly valid > 420-only modes. >=20 > Fix this by checking whether the mode is 420-only first. If so, then > proceed by checking it with HDMI_COLORSPACE_YUV420 so long as the > connector has legalized 420, otherwise error out. If the mode is not > 420-only, check with RGB as was previously always the case. >=20 > Fixes: 47368ab437fd ("drm/display: hdmi: add generic mode_valid helper") > Signed-off-by: Nicolas Frattaroli > --- > drivers/gpu/drm/display/drm_hdmi_state_helper.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gp= u/drm/display/drm_hdmi_state_helper.c > index 5da956bdd68c..1800e00b30c5 100644 > --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c > +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c > @@ -892,8 +892,18 @@ drm_hdmi_connector_mode_valid(struct drm_connector *= connector, > const struct drm_display_mode *mode) > { > unsigned long long clock; > + enum hdmi_colorspace fmt; > + > + if (drm_mode_is_420_only(&connector->display_info, mode)) { > + if (connector->ycbcr_420_allowed) > + fmt =3D HDMI_COLORSPACE_YUV420; > + else > + return MODE_NO_420; > + } else { > + fmt =3D HDMI_COLORSPACE_RGB; > + } > =20 > - clock =3D drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB); > + clock =3D drm_hdmi_compute_mode_clock(mode, 8, fmt); I agree on principle, but we need to have a test for this. Maxime --yxo2br3bzecmdszc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaTgvsAAKCRAnX84Zoj2+ dpZUAX41Qku7HK51QFuHnPNqkFC6QPCPqvYd1L2dj5jW84noRXFIzMeW5xGaIeQR gUtLvc8Bf2X/OfEFvCBHbET5lU94V8iwQEiZrfF7/NF+nmd5jhNG1djOHzfUfGSY LcABmHyY4A== =nuaG -----END PGP SIGNATURE----- --yxo2br3bzecmdszc--