From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD3372D4805 for ; Tue, 9 Dec 2025 09:22:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.238.236.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765272123; cv=none; b=SwKTQsY+uIruHveXdXV2dFVFmoQ2ds57uNoNugC4FB0s1HF3GLN/jtFAZkgsMn9qg/SYo0iP32JJNEDD3Mzsscn8315QGjiToXcHCLkMpGH2dbCYIurLHFocQh60ozSUrEuDkXVMVZZHerT7NZtyg42OiKvW5P+L7Llaa11IMsQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765272123; c=relaxed/simple; bh=VcdjfQDEces6ZLP9LJhAT59zNfwxumqS7vf2E0ZFo+A=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FYpW6O7RNr+C6VdZI8YbMQQDrdrGjZ3uF2NQgdRslME4aioVrVIkg9k9Kw+qT3zKwNGto+YiRijyPkD50N8eXqVr5ZzvqIstpcFBIxC8xW1V6a4ZcIbAe0S5uZNgXTlEDuk73wL4reLPvzRu+WfpN2JJ8pvT0pO7zxx6L9AHlCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=LKXze3fZ; arc=none smtp.client-ip=178.238.236.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="LKXze3fZ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=References:In-Reply-To:Cc:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=S9SDupeVaOjuWuchhLm7bl8sYGNWC2v3EkUWhQEYUYc=; b=LKXze3fZtETCIF7ea5UhNvW9KV uF3rpSzs18Z5wHkibO4uAod5TQTPFGQrtZv+R2iAX44dG6xzr86V1X7FcipmwzfLPz2+afJ0NBSFe 3xFKD0SPoTT84VdblP5scpRhOktFnzKtLhyjwX57pNVD6SodUgO4N/bNpa6OVLxSkAGEnME05cA5Z fbWKfh9xUjHWarNU32YLpIymmqRWQR0/9lFoO14AdarljXRJpc7ce2tJjiPolxEhuDY8nJjUn3Jvh /amdi1wF0LPNO/vb76tARd0SUY+P2pIligr/eA6xwemFNMasPj783aNtxPOXhwMOO8TKBcPXk9CaR nQHlnURQ==; Date: Tue, 9 Dec 2025 10:21:49 +0100 From: Andreas Kemnade To: Matti Vaittinen Cc: lee@kernel.org, linux-kernel@vger.kernel.org, sre@kernel.org Subject: Re: [PATCH] mfd: bd71828: Add some missing charger related registers Message-ID: <20251209102149.30c7ce19@kemnade.info> In-Reply-To: <20389a09-1c69-40fa-a937-289a104d57fa@gmail.com> References: <20251207085024.7375-1-andreas@kemnade.info> <20389a09-1c69-40fa-a937-289a104d57fa@gmail.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 8 Dec 2025 09:47:43 +0200 Matti Vaittinen wrote: > On 07/12/2025 10:50, Andreas Kemnade wrote: > > As there are some registers missing which are required for future charger > > extensions, add them. > > > > Signed-off-by: Andreas Kemnade > > Reviewed-by: Matti Vaittinen > > Thanks for working with this driver! Much appreciated :) > [...] > I asked for some clarification from the HQ folks - but they may be quite > busy, and my request(s) may not be at the top of the priority list. So, > let's see... > > Are you planning to expose the current limit values to user-space? Allow > setting the control to AUTO/fixed value? I suppose this is what enabled > you to do some low-power charging, right? > I am thinking about adding input_current_limit property and providing the ILIM_DCIN_EN as a custom sysfs property like maybe "auto_input_current_limitation" I had issues with using my bike hub dynamo and some solar panels without any additional batteries in between, just regulator (and in the bike hub dynamo, of course a rectifier with a smoothing capacitor). I would expect to just see the current limited so that voltage stays at the anticollapse voltage, but that is not the case. I have solved the problem with clearing ILIM_DCIN_EN and setting current accordingly (often to something like 0.4A). I will try to use the next sun ray arriving here to recheck. I have created a script to manipulate things using i2cset in a lonely place in nature where I obviously did not want to spend time with datasheets as short as possible. The key point is not only low-power charging but also power sources with changing properties. Regards, Andreas