From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CD02288525 for ; Tue, 9 Dec 2025 11:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765279789; cv=none; b=JwOmTslt70sVVvbCkJS3RUSJbUtNldLCAPr1UOQ9ipqAB1oNlTbbUBfJxttsxpXt//k7M+WIZr+CXxlKEmrgRJUvM2aJUnIyJvoqK1ZtgpxxfjIO+WauRxtjprE2wvv1EBDvAPAHM79LIn+kiv3TkjU8m/BmH5cWqKGpcyCd8is= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765279789; c=relaxed/simple; bh=kC9wOyBmquCqAs6xK26aZTH0sJvlu7PNU//Uug8x5CU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZTvYF2IoFOcgY6q/ZBL+u1z8dHQzKX4RhMqORkguPR+sAhmXE3BpG5qrvjvhUh+VlNmo4SzEeDu7ET8k6jhIMMa3VtVJS+mVe0pRBCMjZh+s8TXMsW3srCf3raXUwUfBUYOqhjxt+q2xFHZB1739sGQjdMkEbH2ueH5iOMkLjfs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mjik0iJ8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mjik0iJ8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FEE6C4CEF5; Tue, 9 Dec 2025 11:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765279788; bh=kC9wOyBmquCqAs6xK26aZTH0sJvlu7PNU//Uug8x5CU=; h=From:To:Cc:Subject:Date:From; b=mjik0iJ8aOrivS4e5eS8e04r0ljWy7gylI9npG0op37Jvrvz8fwqGNSNhp8IBdDtK BbxezTErceOFgJimu0HAqnfBSv3ZEMq6CYD6fsyrGHR5j8B+nclTS9ZJzSLlMiNDCL x+dWgAdxJ17Vta8dT1FXvu/TSMNcTmoIqiQk8Pn0IR12j0J08HZfIyVtp6B6VSS0Wy IBZj0ZG4dR3XzSe7jLD0jI7GgLFEfrxiwc0hbrDXl7UOOr2jygQwysihv2fQrtHqz4 0oikXcRN4nJyEjUWihnbuLzp369TkPUYZaSUtkCMQIGJYZ+kXfxnzUzsrp7ahXpkWi M9DkPhmxLE6Uw== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu , stable@kernel.org Subject: [PATCH v3 1/2] f2fs: fix to do sanity check on node folio during its writeback Date: Tue, 9 Dec 2025 19:29:37 +0800 Message-ID: <20251209112938.1017229-1-chao@kernel.org> X-Mailer: git-send-email 2.52.0.223.gf5cc29aaa4-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add more sanity check on node folio during its writeback, if node footer indicates it is an inode: - i_mode should be consistent w/ inode - ofs_of_node should be consistent w/ non-xattr node In addition, if sanity check fails, let's shutdown filesystem to avoid looping to redirty and writeback it. Cc: stable@kernel.org Signed-off-by: Chao Yu --- v3: - rebase the code fs/f2fs/node.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 482a362f2625..83624c302543 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1504,20 +1504,30 @@ static int sanity_check_node_footer(struct f2fs_sb_info *sbi, struct folio *folio, pgoff_t nid, enum node_type ntype) { + bool is_inode; + bool is_xnode; + if (unlikely(nid != nid_of_node(folio))) goto out_err; + is_inode = IS_INODE(folio); + is_xnode = f2fs_has_xattr_block(ofs_of_node(folio)); + switch (ntype) { + case NODE_TYPE_REGULAR: + if (is_inode && is_xnode) + goto out_err; + break; case NODE_TYPE_INODE: - if (!IS_INODE(folio)) + if (!is_inode || is_xnode) goto out_err; break; case NODE_TYPE_XATTR: - if (!f2fs_has_xattr_block(ofs_of_node(folio))) + if (is_inode || !is_xnode) goto out_err; break; case NODE_TYPE_NON_INODE: - if (IS_INODE(folio)) + if (is_inode) goto out_err; break; default: @@ -1751,7 +1761,11 @@ static bool __write_node_folio(struct folio *folio, bool atomic, bool *submitted /* get old block addr of this node page */ nid = nid_of_node(folio); - f2fs_bug_on(sbi, folio->index != nid); + + if (sanity_check_node_footer(sbi, folio, nid, NODE_TYPE_REGULAR)) { + f2fs_handle_critical_error(sbi, STOP_CP_REASON_CORRUPTED_NID); + goto redirty_out; + } if (f2fs_get_node_info(sbi, nid, &ni, !do_balance)) goto redirty_out; -- 2.49.0